Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tracy options #14710

Merged
merged 1 commit into from
Jan 25, 2023
Merged

Add tracy options #14710

merged 1 commit into from
Jan 25, 2023

Conversation

jjcasmar
Copy link
Contributor

Specify library name and version: tracy/0.9

This patch fixes two issues with tracy library:

  • Several tracy options where missing from the conan package. This patch adds them
  • Tracy options set to ON are exported as PUBLIC defines in CMake. However, the conan package was not adding the corresponding defines, so the behavior was different between original CMakeLists and conan package. This patch fixes that

@CLAassistant
Copy link

CLAassistant commented Dec 13, 2022

CLA assistant check
All committers have signed the CLA.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@jjcasmar jjcasmar closed this Dec 13, 2022
@jjcasmar jjcasmar reopened this Dec 13, 2022
@conan-center-bot

This comment has been minimized.

2 similar comments
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@uilianries
Copy link
Member

@jjcasmar Have you asked for access request, as described on the comment #14710 (comment) ?

@jjcasmar
Copy link
Contributor Author

@jjcasmar Have you asked for access request, as described on the comment #14710 (comment) ?

No... I have just done it

@jjcasmar jjcasmar closed this Dec 13, 2022
@jjcasmar jjcasmar reopened this Dec 13, 2022
@conan-center-bot

This comment has been minimized.

uilianries
uilianries previously approved these changes Dec 14, 2022
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline

All green in build 9 (f33f7c054e061678e0d78a5c0ad45ef51601d251):

  • tracy/0.9@:
    All packages built successfully! (All logs)

  • tracy/0.8.1@:
    All packages built successfully! (All logs)

  • tracy/0.8.2.1@:
    All packages built successfully! (All logs)

  • tracy/cci.20220130@:
    All packages built successfully! (All logs)

@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit f33f7c0
tracy/0.9
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libTracyClient.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\TracyClient.dll' links to system library 'ws2_32' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\TracyClient.dll' links to system library 'dbghelp' but it is not in cpp_info.system_libs.
tracy/0.8.1
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libTracyClient.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\TracyClient.dll' links to system library 'ws2_32' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\TracyClient.dll' links to system library 'dbghelp' but it is not in cpp_info.system_libs.
tracy/0.8.2.1
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libTracyClient.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\TracyClient.dll' links to system library 'dbghelp' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\TracyClient.dll' links to system library 'ws2_32' but it is not in cpp_info.system_libs.
tracy/cci.20220130
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libTracyClient.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\TracyClient.dll' links to system library 'ws2_32' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\TracyClient.dll' links to system library 'dbghelp' but it is not in cpp_info.system_libs.

@jjcasmar
Copy link
Contributor Author

Any news on this?

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit 1f4f8a3 into conan-io:master Jan 25, 2023
StellaSmith pushed a commit to StellaSmith/conan-center-index that referenced this pull request Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants