pcapplusplus: add version v22.11 #14712

seladb · 2022-12-13T09:05:11Z

Specify library name and version: pcapplusplus/22.11

Update PcapPlusPlus to v22.11

I've read the contributing guidelines.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the conan-center hook activated.

ghost · 2022-12-13T09:14:26Z

I detected other pull requests that are modifying pcapplusplus/all recipe:

pcapplusplus: add version v22.11 (old) #14159

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

seladb · 2022-12-13T09:23:06Z

I detected other pull requests that are modifying pcapplusplus/all recipe:
* [pcapplusplus: add version v22.11 (old) #14159](https://github.com/conan-io/conan-center-index/pull/14159)
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

I keep the previous PR for reference, we can close it later

seladb · 2022-12-13T09:33:13Z

@prince-chrismc this is the PR with the fix we discussed here: #14159

seladb · 2022-12-13T15:25:24Z

Conan v1 pipeline

Failure in build 4 (ddca22d9f845eb903ab7a88efd889a5b770d1191):

pcapplusplus/21.05@:
Visual Studio license has expired, infrastructure team has been notified and will take care of it.

pcapplusplus/22.05@:
Didn't run or was cancelled before finishing

pcapplusplus/21.11@:
Didn't run or was cancelled before finishing

pcapplusplus/22.11@:
Didn't run or was cancelled before finishing

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

Conan team - can you help with this error? Maybe we should rerun it?

uilianries · 2022-12-13T16:08:04Z

I just restarted it now, let's see, because I can't find more PRs with the same status.

seladb · 2022-12-14T09:32:46Z

Conan v1 pipeline

Failure in build 7 (a0aa6fe19bcf2bf29a5bc602cbfa65149ed20c82):
* **pcapplusplus/21.05@:**
  Visual Studio license has expired, infrastructure team has been notified and will take care of it.

* **pcapplusplus/21.11@:**
  Didn't run or was cancelled before finishing

* **pcapplusplus/22.11@:**
  Didn't run or was cancelled before finishing

* **pcapplusplus/22.05@:**
  Didn't run or was cancelled before finishing
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@uilianries I'm not sure what to do... CI failed 3 times with the same error message - any idea how to proceed?

seladb · 2022-12-15T03:46:09Z

Thank you @prince-chrismc ! I think the PR is ready to review

uilianries

Please consider https://github.com/conan-io/conan-center-index/tree/master/docs/package_templates/cmake_package/all as template for test_package and test_v1_package.

recipes/pcapplusplus/all/test_v1_package/CMakeLists.txt

uilianries · 2022-12-15T08:48:51Z

recipes/pcapplusplus/all/test_v1_package/test_package.cpp

@@ -0,0 +1,43 @@
+#include <iostream>


This file can be removed. Re-use directly from test_package folder.

Done in 4a0959d

Co-authored-by: Uilian Ries <uilianries@gmail.com>

seladb · 2022-12-15T09:36:15Z

Conan v1 pipeline

Failure in build 11 (1de5980b938e5558100441f947a4863be17986f1):

* **pcapplusplus/21.05@:**
  Didn't run or was cancelled before finishing

* **pcapplusplus/21.11@:**
  Didn't run or was cancelled before finishing

* **pcapplusplus/22.05@:**
  CI failed to create some packages ([All logs](https://c3i.jfrog.io/c3i/misc/summary.html?json=https://c3i.jfrog.io/c3i/misc/logs/pr/14712/11-linux-gcc/pcapplusplus/22.05//summary.json))
  Logs for packageID `0ad9b72ff7ca8d391072b0c8f15c8cfb5fa0dd3c`:
  ```
  [settings]
  arch=x86_64
  build_type=Release
  compiler=gcc
  compiler.libcxx=libstdc++11
  compiler.version=7
  os=Linux
  ```
  
  
      
        
      
  
        
      
  
      
    
  ```
  [...]
  -- Library Pcap++ found /home/conan/w/prod/BuildSingleReference/.conan/data/pcapplusplus/22.05/_/_/package/0ad9b72ff7ca8d391072b0c8f15c8cfb5fa0dd3c/lib/libPcap++.a
  -- Library Packet++ found /home/conan/w/prod/BuildSingleReference/.conan/data/pcapplusplus/22.05/_/_/package/0ad9b72ff7ca8d391072b0c8f15c8cfb5fa0dd3c/lib/libPacket++.a
  -- Library Common++ found /home/conan/w/prod/BuildSingleReference/.conan/data/pcapplusplus/22.05/_/_/package/0ad9b72ff7ca8d391072b0c8f15c8cfb5fa0dd3c/lib/libCommon++.a
  -- Library pcap found /home/conan/w/prod/BuildSingleReference/.conan/data/libpcap/1.9.1/_/_/package/d50a0d523d98c15bb147b18fa7d203887c38be8b/lib/libpcap.a
  -- Conan: Adjusting default RPATHs Conan policies
  -- Conan: Adjusting language standard
  -- Conan: Compiler GCC>=5, checking major version 7
  -- Conan: Checking correct version: 7
  -- Conan: C++ stdlib: libstdc++11
  -- Conan: called by CMake conan helper
  -- Conan: Adjusting output directories
  -- Conan: Using cmake global configuration
  -- Conan: Adjusting default RPATHs Conan policies
  -- Conan: Adjusting language standard
  -- Conan: Compiler GCC>=5, checking major version 7
  -- Conan: Checking correct version: 7
  -- Conan: C++ stdlib: libstdc++11
  -- Configuring done
  -- Generating done
  -- Build files have been written to: /home/conan/w/prod/BuildSingleReference/conan-center-index/recipes/pcapplusplus/all/test_v1_package/build/ac8e5b135bec2d2511377cc6fdda763812fc2867
  
  ----Running------
  > cmake --build '/home/conan/w/prod/BuildSingleReference/conan-center-index/recipes/pcapplusplus/all/test_v1_package/build/ac8e5b135bec2d2511377cc6fdda763812fc2867' '--' '-j3'
  -----------------
  Scanning dependencies of target test_package
  [ 50%] Building CXX object test_package/CMakeFiles/test_package.dir/test_package.cpp.o
  [100%] Linking CXX executable bin/test_package
  [100%] Built target test_package
  pcapplusplus/22.05 (test package): Running test()
  
  ----Running------
  > bin/test_package /home/conan/w/prod/BuildSingleReference/conan-center-index/recipes/pcapplusplus/all/test_v1_package/1_packet.pcap
  -----------------
  CMake Warning:
    Manually-specified variables were not used by the project:
  
      CMAKE_EXPORT_NO_PACKAGE_REGISTRY
      CMAKE_INSTALL_BINDIR
      CMAKE_INSTALL_DATAROOTDIR
      CMAKE_INSTALL_INCLUDEDIR
      CMAKE_INSTALL_LIBDIR
      CMAKE_INSTALL_LIBEXECDIR
      CMAKE_INSTALL_OLDINCLUDEDIR
      CMAKE_INSTALL_SBINDIR
  
  
  /bin/sh: 1: bin/test_package: not found
  ERROR: pcapplusplus/22.05 (test package): Error in test() method, line 38
  	self.run(f"{bin_path} {pcap_file_path}", run_environment=True)
  	ConanException: Error 127 while executing bin/test_package /home/conan/w/prod/BuildSingleReference/conan-center-index/recipes/pcapplusplus/all/test_v1_package/1_packet.pcap
  ```

* **pcapplusplus/22.11@:**
  Didn't run or was cancelled before finishing

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@uilianries can you help me understand why the test fails? I tried to follow your comments...

seladb · 2022-12-17T22:25:55Z

@uilianries @prince-chrismc can you please guide me on why the build is failing? I followed @uilianries PR comments and it started failing...

seladb · 2022-12-21T08:54:16Z

@uilianries should I revert to the previous commit that works? Please let me know

prince-chrismc · 2022-12-27T22:23:33Z

recipes/pcapplusplus/all/test_package/conanfile.py

+            bin_path = os.path.join(self.cpp.build.bindirs[0], "test_package")
            pcap_file_path = os.path.join(self.source_folder, "1_packet.pcap")
-            self.run(f"{bin_path} {pcap_file_path}", run_environment=True)
+            self.run(f"{bin_path} {pcap_file_path}", env="conanrun")


I think there might have been some confusion, this has not been migrated so the "old" way should still be used AFAIK

I would try with as it previously was using

Suggested change

bin_path = os.path.join(self.cpp.build.bindirs[0], "test_package")

pcap_file_path = os.path.join(self.source_folder, "1_packet.pcap")

self.run(f"{bin_path} {pcap_file_path}", run_environment=True)

self.run(f"{bin_path} {pcap_file_path}", env="conanrun")

bin_path = os.path.join("bin", "test_package")

pcap_file_path = os.path.join(self.source_folder, "1_packet.pcap")

self.run(f"{bin_path} {pcap_file_path}", run_environment=True)

seladb · 2023-01-10T09:37:18Z

@prince-chrismc @uilianries I'm not sure why it doesn't work, can you please assist?
I'm pretty lost here...

Signed-off-by: Uilian Ries <uilianries@gmail.com>

uilianries

@seladb please, consider seladb#2 as an improvement. The idea behind of test package is validating your generate package. Running features like pcap and devices goes beyond the test scope and creates a more complex situation on Windows. Thank you for your contribution and sorry my delay.

[pcapplusplus] Reduce test package

conan-center-bot · 2023-01-21T07:53:16Z

Conan v1 pipeline ✔️

All green in build 17 (63c894faebf9faa37498382fb8d3d16306fb54a9):

pcapplusplus/21.11@:
All packages built successfully! (All logs)
pcapplusplus/21.05@:
All packages built successfully! (All logs)
pcapplusplus/22.05@:
All packages built successfully! (All logs)
pcapplusplus/22.11@:
All packages built successfully! (All logs)

seladb · 2023-01-21T08:28:25Z

Thank you @uilianries for all of your help!

Is the PR ready to merge now?

uilianries

LGTM

@prince-chrismc

* Update recipe to PcapPlusPlus v22.11 * Add `test_v1_package` * Fix typo * Add sources for 22.11 * Trigger CI * Address comment in CMakeLists Co-authored-by: Uilian Ries <uilianries@gmail.com> * Remove `test_package.cpp` from `test_v1_package` * Try fixing the bin path * Apply changes suggested by @prince-chrismc * Fix bin folder * Fix test_v1_package bin dir * Revert bin location change * Simplify test package Signed-off-by: Uilian Ries <uilianries@gmail.com> Signed-off-by: Uilian Ries <uilianries@gmail.com> Co-authored-by: Uilian Ries <uilianries@gmail.com>

Update recipe to PcapPlusPlus v22.11

4b13e20

conan-center-bot added the Failed label Dec 13, 2022