Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MPC Conan 2.0 Compatibility #14770

Merged
merged 20 commits into from
Jan 28, 2023
Merged

MPC Conan 2.0 Compatibility #14770

merged 20 commits into from
Jan 28, 2023

Conversation

System-Arch
Copy link
Contributor

Specify library name and version: mpc/1.2.0

Migrated recipe to Conan 2.0. Resolves #14768. Note that these changes are untested on Windows with Conan 2.0 because some of the required dependencies don't build with 2.0 yet

@github-actions github-actions bot mentioned this pull request Dec 15, 2022
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit b3d588e
mpc/1.1.0 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libmpc.so' links to system library 'm' but it is not in cpp_info.system_libs.
mpc/1.2.0 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libmpc.so' links to system library 'm' but it is not in cpp_info.system_libs.

@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit 2040aab
mpc/1.2.0 
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libmpc.dylib, libmpc.3.dylib
mpc/1.1.0 
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libmpc.dylib, libmpc.3.dylib

StellaSmith
StellaSmith reviewed Jan 20, 2023
View reviewed changes
Copy link
Contributor

@StellaSmith StellaSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://docs.conan.io/en/2.0/reference/tools/apple/other.html#conan-tools-apple-fix-apple-shared-install-name

recipes/mpc/all/conanfile.py Show resolved Hide resolved
recipes/mpc/all/conanfile.py Show resolved Hide resolved
System-Arch and others added 2 commits January 20, 2023 18:54
@System-Arch @StellaSmith
Add call to fix_apple_shared_install_name
0610f48 
Co-authored-by: Stella Smith <40411082+StellaSmith@users.noreply.github.com>
@System-Arch
Removed setting of shared/static options per code review
d62d251
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
StellaSmith
StellaSmith previously approved these changes Jan 21, 2023
View reviewed changes
SpaceIm
SpaceIm suggested changes Jan 22, 2023
View reviewed changes
Copy link
Contributor

@SpaceIm SpaceIm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inject VirtualRunEnv in build scope for native build, otherwise configure step of autotools on Linux & Windows will break if dependencies are shared

recipes/mpc/all/conanfile.py Outdated Show resolved Hide resolved
recipes/mpc/all/conanfile.py Show resolved Hide resolved
SpaceIm
SpaceIm suggested changes Jan 22, 2023
View reviewed changes
recipes/mpc/all/conanfile.py Outdated Show resolved Hide resolved
recipes/mpc/all/conanfile.py Outdated Show resolved Hide resolved
SpaceIm
SpaceIm suggested changes Jan 22, 2023
View reviewed changes
recipes/mpc/all/test_v1_package/CMakeLists.txt Outdated Show resolved Hide resolved
recipes/mpc/all/test_v1_package/conanfile.py Outdated Show resolved Hide resolved
recipes/mpc/all/test_v1_package/test_package.c Outdated Show resolved Hide resolved
System-Arch and others added 2 commits January 22, 2023 18:10
@System-Arch @SpaceIm
Incorporate @spacelm's review feedback
abf0374 
Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>
@System-Arch
Per review feedback
b571908
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 21 (b571908a21138112f8be28d3b1c28cfbaae69683):

  • mpc/1.1.0@:
    All packages built successfully! (All logs)

  • mpc/1.2.0@:
    All packages built successfully! (All logs)

uilianries
uilianries approved these changes Jan 27, 2023
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit ac1a6e1 into conan-io:master Jan 28, 2023
@prince-chrismc prince-chrismc mentioned this pull request Jan 28, 2023
Merged
1 task
StellaSmith added a commit to StellaSmith/conan-center-index that referenced this pull request Feb 2, 2023
@System-Arch @StellaSmith @SpaceIm
(conan-io#14770) MPC Conan 2.0 Compatibility
aa5bf41 
* MPC Conan 2.0 Compatibility

* Fixed lint errors

* Fixed license copying code

* Tweaked how win_bash is set

* Added new metadata for patch

* Try adding VirtrualBuildEnv for v1.x

* Bump required_conan_version

* Define CL-related flag macro values.

* Import is_msvc

* Add automake as a tool_requires

* Fixed typo

* Recognize that recipe lacks Visual Studio support

* Formatting tweak

* Added blank line to trigger CI build

* Use autotools.autoreconf() per review suggestion

* Add "m" as system_libs

* Add call to fix_apple_shared_install_name

Co-authored-by: Stella Smith <40411082+StellaSmith@users.noreply.github.com>

* Removed setting of shared/static options per code review

* Incorporate @spacelm's review feedback

Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>

* Per review feedback

---------

Co-authored-by: Stella Smith <40411082+StellaSmith@users.noreply.github.com>
Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hopobcn Hopobcn Hopobcn left review comments

@SpaceIm SpaceIm SpaceIm requested changes

@StellaSmith StellaSmith StellaSmith approved these changes

@prince-chrismc prince-chrismc prince-chrismc approved these changes

@uilianries uilianries uilianries approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[package] MPC/1.2.0 lacks support for Conan 2.0
7 participants
@System-Arch @conan-center-bot @Hopobcn @uilianries @prince-chrismc @SpaceIm @StellaSmith