[sail] Bump to 0.9.0-rc2, migrate to Conan V2 #14871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This was referenced Dec 25, 2022
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Blocked by #15194 for V2 |
Conan v1 pipelineAll green in build 20 (
|
|
Not blocked by #15194 anymore, can be merged. |
prince-chrismc
approved these changes
Jan 25, 2023
jwillikers
suggested changes
Jan 27, 2023
Comment on lines
+107
to
+110
| # TODO: Remove after fixing https://github.com/conan-io/conan-center-index/issues/13159 | ||
| # C3I workaround to force CMake to choose the highest version of | ||
| # the windows SDK available in the system | ||
| if is_msvc(self) and not self.conf.get("tools.cmake.cmaketoolchain:system_version"): |
There was a problem hiding this comment.
Is it possible to avoid doing this outside of C3I? I know the Qt 6 recipe implements some special validation logic with if os.getenv('NOT_ON_C3I', '0') == '0': to only evaluate in C3I. This allows local devs to set the variable and override this behavior.
Not sure if this should be done, but I wanted to ask. @prince-chrismc Any thoughts?
There was a problem hiding this comment.
Environment should be totally avoided on Conan 2.0, so conan config will be the best and safest approach. About Qt, that variable should be replace by a configuration too. As you should know, env vars are fragile, they can be easily replace, also, depending the user/profile they may change too, so it's not safe using them.
uilianries
approved these changes
Jan 27, 2023
StellaSmith
pushed a commit
to StellaSmith/conan-center-index
that referenced
this pull request
Feb 2, 2023
* Added libjpeg-turbo option
* Use SAIL_ENABLE_CODECS
* [sail] Update to 0.9.0-rc1
* [sail] Fix linter errors
* [sail] Migrate to new CMake
* [sail] Use apply_conandata_patches
* [sail] Update libwebp 1.2.2 -> 1.2.3
* [sail] Fix libjpeg-turbo target name
* [sail] Remove unused imports
* [sail] Refactor libjpeg-turbo usage
* [sail] Added missing self
* [sail] Use copy from CMake tools
* [sail] Remove root CMakeLists and generators
* [sail] Update avif rc1 patch
* [sail] Remove CONFIG
* [sail] Disable pre23 for testing
* [sail] Disable AVIF for testing
* Workaroud Windows SDK bug
* Update to RC2
* Bump versions
* Remove pre23 patch
* V1 test suite
* Update RC1 to RC2 in config.yml
* Added missing CMakeDeps
* Enable AVIF
* Update recipes/sail/all/conanfile.py
Co-authored-by: Uilian Ries <uilianries@gmail.com>
* Update recipes/sail/all/conanfile.py
Co-authored-by: Uilian Ries <uilianries@gmail.com>
* Update recipes/sail/all/conanfile.py
Co-authored-by: Uilian Ries <uilianries@gmail.com>
* Update recipes/sail/all/test_v1_package/CMakeLists.txt
Co-authored-by: Uilian Ries <uilianries@gmail.com>
* Use self.options.rm_safe("fPIC")
* Fix typo
* Delete test_package.c
* Delete test_package.cpp
* Try workaround for check_c_source_compiles
* Test
* Try workaround for check_c_source_compiles for Windows only
* Use str()
* Update libavif version
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: sail/0.9.0-rc2