Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yamllinter: raise if a version has patches but no sources #14911

Merged
merged 4 commits into from
Feb 10, 2023

Conversation

ericLemanissier
Copy link
Contributor

This can happen if "someone" removes an outdated version, but forgets to check if there are patches for this version
(it happened to me yesterday)


@prince-chrismc
Copy link
Contributor

This one I remember did weird stuff

for patch in self.conan_data.get("patches", {}).get("{}-opt".format(self.version), []):

@ericLemanissier

This comment was marked as resolved.

@ericLemanissier ericLemanissier marked this pull request as draft February 3, 2023 12:43
@ericLemanissier

This comment was marked as resolved.

@ericLemanissier ericLemanissier marked this pull request as ready for review February 3, 2023 13:17
@ericLemanissier
Copy link
Contributor Author

just to be clear: one of the job failed, but it is not a blocker for this PR

Copy link
Contributor

@paulharris paulharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit 3d7ae4b into conan-io:master Feb 10, 2023
@ericLemanissier ericLemanissier deleted the patch-1 branch February 10, 2023 09:14
sabelka pushed a commit to sabelka/conan-center-index that referenced this pull request Feb 12, 2023
…urces

* yamllinter: raise if a version has patches but no sources

* Update conandata_yaml_linter.py

* we dont want to make noise se from errors just yet

---------

Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants