Glibmm v2 toolchain #14930

planetmarshall · 2022-12-25T14:57:27Z

Specify library name and version: glibmm

Update glibmm for v2 toolchain
Add version 2.74.0

I've read the contributing guidelines.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the conan-center hook activated.

github-actions · 2023-01-22T13:55:10Z

Hooks produced the following warnings for commit 3686c00

glibmm/2.72.1

post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libglibmm_generate_extra_defs-2.68.dylib, libgiomm-2.68.1.dylib, libglibmm_generate_extra_defs-2.68.1.dylib, libglibmm-2.68.dylib, libgiomm-2.68.dylib, libglibmm-2.68.1.dylib

glibmm/2.74.0

post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libglibmm_generate_extra_defs-2.68.dylib, libgiomm-2.68.1.dylib, libglibmm_generate_extra_defs-2.68.1.dylib, libglibmm-2.68.dylib, libgiomm-2.68.dylib, libglibmm-2.68.1.dylib

glibmm/2.66.4

post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libglibmm-2.4.1.dylib, libglibmm_generate_extra_defs-2.4.1.dylib, libglibmm-2.4.dylib, libglibmm_generate_extra_defs-2.4.dylib, libgiomm-2.4.1.dylib, libgiomm-2.4.dylib

recipes/glibmm/all/conanfile.py

Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>

recipes/glibmm/all/conanfile.py

uilianries

Only a small comment, otherwise, it's really good to go

recipes/glibmm/all/conanfile.py

Co-authored-by: Uilian Ries <uilianries@gmail.com>

uilianries

LGTM

SpaceIm · 2023-02-03T01:11:51Z

recipes/glibmm/all/conanfile.py

+        if hasattr(self, "settings_build") and cross_building(self):
            raise ConanInvalidConfiguration("Cross-building not implemented")


It should work now with MesonToolchain. It was a limitation of the legacy Meson build helper.

SpaceIm · 2023-02-03T01:12:22Z

recipes/glibmm/all/conanfile.py

            else:
-                build.check_min_cppstd(self, 11)
+                check_min_cppstd(self, 11)

        if self.options.shared and not self.options["glib"].shared:


Suggested change

if self.options.shared and not self.options["glib"].shared:

if self.options.shared and not self.dependencies["glib"].options.shared:

SpaceIm

I strongly advise to always call VirtualBuildEnv first to avoid conflicts. VirtualBuildEnv is dumb, while other generators may sanitize similar env vars, so you don't want raw env vars of VirtualBuildEnv to override sanitized env vars of others clever generators.

SpaceIm · 2023-02-03T01:13:08Z

recipes/glibmm/all/conanfile.py

-        files.get(self, **self.conan_data["sources"][self.version], strip_root=True, destination=self._source_subfolder)
+        get(self, **self.conan_data["sources"][self.version], strip_root=True, destination=self.source_folder)
+
+    def generate(self):


Suggested change

def generate(self):

def generate(self):

env = VirtualBuildEnv(self)

env.generate()

SpaceIm · 2023-02-03T01:13:24Z

recipes/glibmm/all/conanfile.py

+
+        env = VirtualBuildEnv(self)
+        env.generate()


Suggested change

env = VirtualBuildEnv(self)

env.generate()

SpaceIm · 2023-02-03T01:16:09Z

recipes/glibmm/all/conanfile.py

-        self.build_requires("meson/0.64.1")
-        self.build_requires("pkgconf/1.9.3")
+        self.tool_requires("meson/1.0.0")
+        self.tool_requires("pkgconf/1.9.3")


Suggested change

self.tool_requires("pkgconf/1.9.3")

if not self.conf.get("tools.gnu:pkg_config", check_type=str):

self.tool_requires("pkgconf/1.9.3")

SpaceIm · 2023-02-03T01:16:28Z

recipes/glibmm/all/conanfile.py

        if self._abi_version == "2.68":
            self.requires("libsigcpp/3.0.7")
        else:
            self.requires("libsigcpp/2.10.8")

    def source(self):
-        files.get(self, **self.conan_data["sources"][self.version], strip_root=True, destination=self._source_subfolder)
+        get(self, **self.conan_data["sources"][self.version], strip_root=True, destination=self.source_folder)


Suggested change

get(self, **self.conan_data["sources"][self.version], strip_root=True, destination=self.source_folder)

get(self, **self.conan_data["sources"][self.version], strip_root=True)

SpaceIm · 2023-02-03T01:17:56Z

recipes/glibmm/all/conanfile.py


            # when using cpp_std=c++NM the /permissive- flag is added which
            # attempts enforcing standard conformant c++ code
            # the problem is that older versions of Windows SDK is not standard
            # conformant! see:
            # https://developercommunity.visualstudio.com/t/error-c2760-in-combaseapih-with-windows-sdk-81-and/185399
-            files.replace_in_file(self, meson_build, "cpp_std=c++", "cpp_std=vc++")
+            replace_in_file(self, meson_build, "cpp_std=c++", "cpp_std=vc++")

    def configure(self):


configure() appears so late when you read this recipe from top to bottom, with a logic to change glib shared option.
I wouldn't be against reordering of methods by order of execution: https://docs.conan.io/en/latest/reference/commands/creator/create.html#methods-execution-order
It's super hard to follow global logic of this recipe.

SpaceIm · 2023-02-03T01:19:35Z

recipes/glibmm/all/conanfile.py


        self.cpp_info.components[giomm_component].set_property("pkg_config_name", giomm_component)
        self.cpp_info.components[giomm_component].libs = [giomm_component]
-        self.cpp_info.components[giomm_component].includedirs = [ os.path.join("include", giomm_component)]
+        self.cpp_info.components[giomm_component].includedirs = [os.path.join("include", giomm_component)]
        self.cpp_info.components[giomm_component].requires = [glibmm_component, "glib::gio-2.0"]

    def package_id(self):


I can't review the line below, but there is a if not self.options["glib"].shared here to replace by if not self.dependencies["glib"].options.shared

SpaceIm · 2023-02-03T01:24:19Z

recipes/glibmm/all/conanfile.py

        if self._abi_version == "2.68":
            self.cpp_info.components[glibmm_component].requires = ["glib::gobject-2.0", "libsigcpp::sigc++"]
        else:
-            self.cpp_info.components[glibmm_component].requires = ["glib::gobject-2.0", "libsigcpp::sigc++-2.0"]
+            self.cpp_info.components[glibmm_component].requires = ["glib::gobject-2.0", "libsigcpp::libsigcpp"]


If you look at libsigcpp recipe, this branching shouldn't exist, it should always be self.cpp_info.components[glibmm_component].requires = ["glib::gobject-2.0", "libsigcpp::libsigcpp"]. Existence of a component in libsigcpp recipe is (or was) just a trick for target name of legacy cmake_find_package*.

SpaceIm · 2023-02-03T01:27:24Z

recipes/glibmm/all/conanfile.py

+            "build-examples": "false",
+            "build-documentation": "false",
+            "msvc14x-parallel-installable": "false",
+            "default_library": "shared" if self.options.shared else "static"


Suggested change

"default_library": "shared" if self.options.shared else "static"

already managed by MesonToolchain

conan-center-bot · 2023-02-03T13:50:54Z

Conan v1 pipeline ✔️

All green in build 13 (24ce0b6763f0cbac54981578df31bff6edfe6245):

glibmm/2.72.1@:
All packages built successfully! (All logs)
glibmm/2.75.0@:
All packages built successfully! (All logs)
glibmm/2.66.4@:
All packages built successfully! (All logs)

Conan v2 pipeline (informative, not required for merge) ❌

Note: Conan v2 builds are informative and they are not required for the PR to be merged.

The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future.

See details:

Failure in build 13 (24ce0b6763f0cbac54981578df31bff6edfe6245):

An unexpected error happened and has been reported. Help is on its way! 🏇

uilianries

LGTM

* [glibmm] add version 2.74.0 * [glibmm] update meson toolchain * [glibmm] update test packages * [glibmm] fix libsigcpp component requires * [glibmm] add v1 test package * [glibmm] disable static builds on msvc * [glibmm] bump glib version * Update recipes/glibmm/all/conanfile.py Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com> * Update recipes/glibmm/all/conanfile.py Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com> * [glibmm] add 2.75.0 * [glibmm] add and document patches for 2.75.0 * Update recipes/glibmm/all/conanfile.py Co-authored-by: Uilian Ries <uilianries@gmail.com> * [glibmm] enable cross compilation * [glibmm] reorder methods * [glibmm] review suggestions --------- Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com> Co-authored-by: Uilian Ries <uilianries@gmail.com>

github-actions bot mentioned this pull request Dec 25, 2022

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

conan-center-bot added the Failed label Dec 25, 2022

This comment has been minimized.

Sign in to view

planetmarshall added 3 commits January 5, 2023 08:54

[glibmm] add version 2.74.0

41c35fa

[glibmm] update meson toolchain

c463312

[glibmm] update test packages

e683952

planetmarshall force-pushed the glibmm-v2 branch from 9554f99 to e683952 Compare January 5, 2023 09:10

[glibmm] fix libsigcpp component requires

4367f31

This comment has been minimized.

Sign in to view

[glibmm] add v1 test package

284f82f

This comment has been minimized.

Sign in to view

[glibmm] disable static builds on msvc

8bb99c2

This comment has been minimized.

Sign in to view

prince-chrismc removed the Failed label Jan 15, 2023

[glibmm] bump glib version

3686c00

This comment has been minimized.

Sign in to view

SpaceIm suggested changes Jan 22, 2023

View reviewed changes

recipes/glibmm/all/conanfile.py Outdated Show resolved Hide resolved

recipes/glibmm/all/conanfile.py Show resolved Hide resolved

planetmarshall and others added 2 commits January 22, 2023 18:54

Update recipes/glibmm/all/conanfile.py

7e59726

Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>

Update recipes/glibmm/all/conanfile.py

08d7136

Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>

SpaceIm reviewed Jan 22, 2023

View reviewed changes

recipes/glibmm/all/conanfile.py Outdated Show resolved Hide resolved

SpaceIm reviewed Jan 22, 2023

View reviewed changes

recipes/glibmm/all/conanfile.py Show resolved Hide resolved

SpaceIm reviewed Jan 22, 2023

View reviewed changes

recipes/glibmm/all/conanfile.py Outdated Show resolved Hide resolved

planetmarshall added 2 commits January 23, 2023 17:41

[glibmm] add 2.75.0

ff369e6

[glibmm] add and document patches for 2.75.0

4bfbfa8

This comment has been minimized.

Sign in to view

uilianries reviewed Jan 27, 2023

View reviewed changes

recipes/glibmm/all/conanfile.py Outdated Show resolved Hide resolved

Update recipes/glibmm/all/conanfile.py

bd51331

Co-authored-by: Uilian Ries <uilianries@gmail.com>

This comment has been minimized.

Sign in to view

prince-chrismc mentioned this pull request Jan 28, 2023

Rank effort to review a given PR prince-chrismc/conan-center-index-pending-review#109

Merged

1 task

uilianries previously approved these changes Jan 30, 2023

View reviewed changes

SpaceIm reviewed Feb 3, 2023

View reviewed changes

SpaceIm suggested changes Feb 3, 2023

View reviewed changes

SpaceIm reviewed Feb 3, 2023

View reviewed changes

planetmarshall added 3 commits February 3, 2023 11:29

[glibmm] enable cross compilation

49a583f

[glibmm] reorder methods

d4b6ddc

[glibmm] review suggestions

24ce0b6

planetmarshall dismissed uilianries’s stale review via 24ce0b6 February 3, 2023 11:42

SpaceIm approved these changes Feb 3, 2023

View reviewed changes

uilianries approved these changes Feb 3, 2023

View reviewed changes

conan-center-bot merged commit 8a35a97 into conan-io:master Feb 3, 2023

planetmarshall deleted the glibmm-v2 branch March 4, 2024 22:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Glibmm v2 toolchain #14930

Glibmm v2 toolchain #14930

planetmarshall commented Dec 25, 2022

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Jan 22, 2023

This comment has been minimized.

uilianries left a comment

This comment has been minimized.

uilianries left a comment

SpaceIm Feb 3, 2023

SpaceIm Feb 3, 2023

SpaceIm left a comment •

edited

Loading

SpaceIm Feb 3, 2023

SpaceIm Feb 3, 2023

SpaceIm Feb 3, 2023

SpaceIm Feb 3, 2023

SpaceIm Feb 3, 2023 •

edited

Loading

SpaceIm Feb 3, 2023

SpaceIm Feb 3, 2023 •

edited

Loading

SpaceIm Feb 3, 2023

conan-center-bot commented Feb 3, 2023

uilianries left a comment

		if hasattr(self, "settings_build") and cross_building(self):
		raise ConanInvalidConfiguration("Cross-building not implemented")

	if self.options.shared and not self.options["glib"].shared:
	if self.options.shared and not self.dependencies["glib"].options.shared:

	self.tool_requires("pkgconf/1.9.3")
	if not self.conf.get("tools.gnu:pkg_config", check_type=str):
	self.tool_requires("pkgconf/1.9.3")

	get(self, **self.conan_data["sources"][self.version], strip_root=True, destination=self.source_folder)
	get(self, **self.conan_data["sources"][self.version], strip_root=True)

Glibmm v2 toolchain #14930

Glibmm v2 toolchain #14930

Conversation

planetmarshall commented Dec 25, 2022

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Jan 22, 2023

This comment has been minimized.

uilianries left a comment

Choose a reason for hiding this comment

This comment has been minimized.

uilianries left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SpaceIm left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SpaceIm Feb 3, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SpaceIm Feb 3, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

conan-center-bot commented Feb 3, 2023

Conan v1 pipeline ✔️

Conan v2 pipeline (informative, not required for merge) ❌

uilianries left a comment

Choose a reason for hiding this comment

SpaceIm left a comment •

edited

Loading

SpaceIm Feb 3, 2023 •

edited

Loading

SpaceIm Feb 3, 2023 •

edited

Loading