Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miniscript: add recipe #15000

Merged
merged 5 commits into from
Jan 30, 2023
Merged

Conversation

toge
Copy link
Contributor

@toge toge commented Dec 29, 2022

Specify library name and version: miniscript/1.5.1


@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit e6ea61c
miniscript/1.5.1
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libminiscript.so' links to system library 'm' but it is not in cpp_info.system_libs.

@conan-center-bot

This comment has been minimized.

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost good to go. Thank you for providing the cmake too.

@@ -0,0 +1,66 @@
cmake_minimum_required(VERSION 3.8)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a Makefile in the project, but I agree in adding this CMake file, as the original Makefile is very limited and it seems be compatible only Unix systems.

recipes/miniscript/all/CMakeLists.txt Outdated Show resolved Hide resolved
@@ -0,0 +1,4 @@
sources:
"1.5.1":
url: "https://github.com/JoeStrout/miniscript/archive/172bea8e762c96b1b2a5ea743228ff6a58702cc3.tar.gz"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

recipes/miniscript/all/conanfile.py Outdated Show resolved Hide resolved
toge and others added 2 commits January 13, 2023 21:19
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline

All green in build 5 (987389715c89ac2bef872b99f8817f9105cebd8c):

  • miniscript/1.5.1@:
    All packages built successfully! (All logs)

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit b0f1b59 into conan-io:master Jan 30, 2023
StellaSmith pushed a commit to StellaSmith/conan-center-index that referenced this pull request Feb 2, 2023
* miniscript: add recipe

* specify cxx_std_11

* link math lib

* fix license

Co-authored-by: Uilian Ries <uilianries@gmail.com>

* use target_include_directories

Co-authored-by: Uilian Ries <uilianries@gmail.com>

---------

Co-authored-by: Uilian Ries <uilianries@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants