Automake: drop old version and recipe fixes #15023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
ghost
mentioned this pull request
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@System-Arch thanks for picking up my slack, give a shout if you need some help |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ghost
mentioned this pull request
|
I detected other pull requests that are modifying automake/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
StellaSmith
previously approved these changes
Jan 20, 2023
jcar87
requested changes
Jan 20, 2023
This comment has been minimized.
This comment has been minimized.
StellaSmith
previously approved these changes
Jan 21, 2023
SpaceIm
reviewed
Jan 22, 2023
This comment has been minimized.
This comment has been minimized.
prince-chrismc
previously approved these changes
Jan 25, 2023
ericLemanissier
previously approved these changes
Jan 25, 2023
prince-chrismc
dismissed stale reviews from ericLemanissier, StellaSmith, and themself
via
7fa1b39
jcar87
changed the title
prince-chrismc
approved these changes
Jan 25, 2023
jcar87
approved these changes
Jan 25, 2023
Conan v1 pipeline ✔️All green in build 26 ( |
paulharris
added a commit
to paulharris/conan-center-index
that referenced
this pull request
Feb 1, 2023
StellaSmith
pushed a commit
to StellaSmith/conan-center-index
that referenced
this pull request
Feb 2, 2023
* Automake Conan 2.0 compatibility * Fixed lint and v1 issues * Need autoconf for autoreconf * Annotate patches per lint * Deleted spurious blank line at EOF * Try working around v1 quirks * Removed redundant setting of win_bash * Don't specify env in call to self.run() * See if reordering build requirements appeases Conan 1.x * Try adding VirtualBuildEnv to appease Conan 1.x * Bump required_conan_version to trigger rebuild now that autoconf has been updated * Removed environment variables per discussion in conan-io/conan:conan-io#12812 * Still need automake_dataroot_path * Fixed definition of automake_dataroot_path * Replaced env. vars. with script-based paths * Removed extra blank line at EOF * Merge in changes from mainline * Remove obsolete patch files * Bump required_conan_version * Fixed lint warning * Tweak required_conan_version() to restart CI after merge * Removed autoconf as a build_requirement * Update recipes/automake/all/conanfile.py Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: automake/1.16.5
This pull request started out building on the work of @jellespijker in PR #12898 and is an effort to close #15022. PRs #15245 and #15358 have subsumed/augmented most of this effort. This PR is now reduced to dropping support for the unused 1.16.1 version.