[rotor/0.25] add rotor, v0.25 relax boost requirements #15081

basiliscos · 2023-01-03T11:18:00Z

rotor/0.25

I've read the contributing guidelines.
I've used a recent Conan client version close to the currently deployed.
I've tried at least one configuration locally with the conan-center hook activated.

github-actions · 2023-01-03T12:39:42Z

Hooks produced the following warnings for commit 5eb7702

rotor/0.23

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/librotor.so' links to system library 'm' but it is not in cpp_info.system_libs.

rotor/0.25

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/librotor.so' links to system library 'm' but it is not in cpp_info.system_libs.

rotor/0.24

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/librotor.so' links to system library 'm' but it is not in cpp_info.system_libs.

github-actions · 2023-01-05T20:50:50Z

Hooks produced the following warnings for commit fdbe83b

rotor/0.24

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/librotor.so' links to system library 'm' but it is not in cpp_info.system_libs.

rotor/0.23

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/librotor.so' links to system library 'm' but it is not in cpp_info.system_libs.

rotor/0.25

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/librotor.so' links to system library 'm' but it is not in cpp_info.system_libs.

github-actions · 2023-01-06T08:13:12Z

Hooks produced the following warnings for commit 61b0ccd

rotor/0.24

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/librotor.so' links to system library 'm' but it is not in cpp_info.system_libs.

rotor/0.23

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/librotor.so' links to system library 'm' but it is not in cpp_info.system_libs.

rotor/0.25

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/librotor.so' links to system library 'm' but it is not in cpp_info.system_libs.

recipes/rotor/all/conanfile.py

prince-chrismc · 2023-01-09T06:49:35Z

recipes/rotor/all/conanfile.py


+    def generate(self):
+        tc = CMakeToolchain(self)
+        tc.cache_variables["BUILD_BOOST_ASIO"] = self.options.enable_asio


I'd suggest using variable if it's possible instead of the cache one

recipes/rotor/all/conanfile.py

prince-chrismc · 2023-01-09T06:50:32Z

recipes/rotor/all/conanfile.py

            self.output.warn(
-                "%s requires a compiler that supports at least C++%s" % (self.name, minimal_cpp_standard))
+                f"{self.name} requires a compiler that supports at least C++{minimal_cpp_standard}")


Suggested change

f"{self.name} requires a compiler that supports at least C++{minimal_cpp_standard}")

f"{self.ref} requires a compiler that supports at least C++{minimal_cpp_standard}")

recipes/rotor/all/conanfile.py

github-actions · 2023-01-16T14:38:45Z

Hooks produced the following warnings for commit 754a5a7

rotor/0.23

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/librotor.so' links to system library 'm' but it is not in cpp_info.system_libs.

rotor/0.25

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/librotor.so' links to system library 'm' but it is not in cpp_info.system_libs.

rotor/0.24

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/librotor.so' links to system library 'm' but it is not in cpp_info.system_libs.

conan-center-bot · 2023-01-18T08:04:20Z

Conan v1 pipeline

All green in build 8 (6ff1256d50437dbb1136fe8468cd709086b9d48a):

rotor/0.21@:
All packages built successfully! (All logs)
rotor/0.23@:
All packages built successfully! (All logs)
rotor/0.24@:
All packages built successfully! (All logs)
rotor/0.25@:
All packages built successfully! (All logs)

github-actions · 2023-01-18T08:06:08Z

Hooks produced the following warnings for commit 6ff1256

rotor/0.23

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/librotor.so' links to system library 'm' but it is not in cpp_info.system_libs.

rotor/0.24

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/librotor.so' links to system library 'm' but it is not in cpp_info.system_libs.

rotor/0.25

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/librotor.so' links to system library 'm' but it is not in cpp_info.system_libs.

AbrilRBS · 2023-01-27T11:17:09Z

Let us know once the hook errors are resolved, and otherwise this looks good, thanks for taking the time to get this working :) (Sorry about the delay, we're working hard in the 2.0 launch and the holidays gave us a bit of a backlog to review)

basiliscos · 2023-01-27T11:29:23Z

@RubenRBS . Hi, thanks for feedback. There are no error-hooks, but only warning-hooks; I think you refer them.

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/librotor.so' links to system library 'm' but it is not in cpp_info.system_libs.

However, rotor does not links with m library directly, most likely it is linked indirectly via boost dependency. I'm not sure, that I should explicitly list it in system_libs, cz it is part of external lib. Do you agree?

PS. There is no math (sin/cos/etc.) used in the library nor in it's direcly used dependencies.

uilianries · 2023-01-27T12:32:10Z

@basiliscos @RubenRBS That hook runs objdump executable, which lists all system library related. In that case, Boost already lists libm as system library, so, you don't need to update this recipe. I see no #include <cmath> in Rotor project, so it's a false positive warning.

uilianries

LGTM

AbrilRBS

Thanks for clearing my doubt up @uilianries and sorry @basiliscos for the scare :)

* add rotor, v0.25 relax boost requirements * modernize for usage with conan v2 * copy license? * handle fpic * Add CMakeDeps * minor cleanup * apply feedback * apply feedback

add rotor, v0.25 relax boost requirements

5eb7702

github-actions bot mentioned this pull request Jan 3, 2023

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

conan-center-bot added the Failed label Jan 3, 2023

This comment has been minimized.

Sign in to view

This was referenced Jan 3, 2023

Updatable recipes qchateau/conan-center-bot#1

Open

[request] Updatable recipes #3470

Closed

modernize for usage with conan v2

43768d2

This comment has been minimized.

Sign in to view

copy license?

67bfa5a

This comment has been minimized.

Sign in to view

handle fpic

6279dda

This comment has been minimized.

Sign in to view

Add CMakeDeps

fdbe83b

This comment has been minimized.

Sign in to view

minor cleanup

61b0ccd

This comment has been minimized.

Sign in to view

ericLemanissier mentioned this pull request Jan 6, 2023

[service] Incorrect Failed label on PRs #15130

Closed

prince-chrismc reviewed Jan 9, 2023

View reviewed changes

recipes/rotor/all/conanfile.py Outdated Show resolved Hide resolved

prince-chrismc reviewed Jan 9, 2023

View reviewed changes

recipes/rotor/all/conanfile.py Outdated Show resolved Hide resolved

prince-chrismc reviewed Jan 9, 2023

View reviewed changes

recipes/rotor/all/conanfile.py Outdated Show resolved Hide resolved

prince-chrismc removed the Failed label Jan 15, 2023

conan-center-bot requested a review from danimtb January 16, 2023 11:59

apply feedback

754a5a7

This comment has been minimized.

Sign in to view

basiliscos requested review from prince-chrismc and removed request for danimtb January 17, 2023 07:08

apply feedback

6ff1256

uilianries approved these changes Jan 27, 2023

View reviewed changes

AbrilRBS approved these changes Jan 27, 2023

View reviewed changes

conan-center-bot merged commit 83add2e into conan-io:master Jan 27, 2023

basiliscos deleted the v0.25-rotor branch January 27, 2023 14:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[rotor/0.25] add rotor, v0.25 relax boost requirements #15081

[rotor/0.25] add rotor, v0.25 relax boost requirements #15081

basiliscos commented Jan 3, 2023

This comment has been minimized.

github-actions bot commented Jan 3, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Jan 5, 2023

This comment has been minimized.

github-actions bot commented Jan 6, 2023

prince-chrismc Jan 9, 2023

prince-chrismc Jan 9, 2023

This comment has been minimized.

github-actions bot commented Jan 16, 2023

conan-center-bot commented Jan 18, 2023

github-actions bot commented Jan 18, 2023

AbrilRBS commented Jan 27, 2023 •

edited

Loading

basiliscos commented Jan 27, 2023

uilianries commented Jan 27, 2023

uilianries left a comment

AbrilRBS left a comment

	f"{self.name} requires a compiler that supports at least C++{minimal_cpp_standard}")
	f"{self.ref} requires a compiler that supports at least C++{minimal_cpp_standard}")

[rotor/0.25] add rotor, v0.25 relax boost requirements #15081

[rotor/0.25] add rotor, v0.25 relax boost requirements #15081

Conversation

basiliscos commented Jan 3, 2023

This comment has been minimized.

github-actions bot commented Jan 3, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Jan 5, 2023

This comment has been minimized.

github-actions bot commented Jan 6, 2023

prince-chrismc Jan 9, 2023

Choose a reason for hiding this comment

prince-chrismc Jan 9, 2023

Choose a reason for hiding this comment

This comment has been minimized.

github-actions bot commented Jan 16, 2023

conan-center-bot commented Jan 18, 2023

Conan v1 pipeline

github-actions bot commented Jan 18, 2023

AbrilRBS commented Jan 27, 2023 • edited Loading

basiliscos commented Jan 27, 2023

uilianries commented Jan 27, 2023

uilianries left a comment

Choose a reason for hiding this comment

AbrilRBS left a comment

Choose a reason for hiding this comment

AbrilRBS commented Jan 27, 2023 •

edited

Loading