[boost] Fix issues building with Conan 2 and with python #15105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
1 task
czoido
previously approved these changes
Jan 4, 2023
ghost
mentioned this pull request
|
I detected other pull requests that are modifying boost/all recipe:
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This was referenced Jan 4, 2023
Merged
jwillikers
previously approved these changes
Jan 4, 2023
jcar87
force-pushed
the
maintenance/fix-boost-conanv2-issues
branch
from
86b2905 to
651c5bd
Compare
jwillikers
previously approved these changes
Jan 4, 2023
czoido
previously approved these changes
Jan 5, 2023
AbrilRBS
previously approved these changes
Jan 5, 2023
jcar87
dismissed stale reviews from AbrilRBS, czoido, and jwillikers
via
246fa13
czoido
approved these changes
Jan 5, 2023
SSE4
approved these changes
Jan 5, 2023
jwillikers
approved these changes
Jan 5, 2023
|
Could you please bump to the latest as well 🙏 |
Conan v1 pipelineAll green in build 4 (
Conan v2 pipeline (informative, not required for merge)Failure in build 4 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
Hooks produced the following warnings for commit 246fa13boost/1.80.0boost/1.81.0boost/1.79.0boost/1.76.0boost/1.75.0boost/1.74.0boost/1.77.0boost/1.78.0boost/1.73.0boost/1.72.0boost/1.71.0boost/1.70.0 |
SpaceIm
reviewed
Jan 6, 2023
| @@ -539,7 +539,7 @@ def requirements(self): | |||
| if self._with_zstd: | |||
| self.requires("zstd/1.5.2") | |||
| if self._with_stacktrace_backtrace: | |||
| self.requires("libbacktrace/cci.20210118") | |||
| self.requires("libbacktrace/cci.20210118", transitive_headers=True) | |||
There was a problem hiding this comment.
Transitive headers but not transitive libs for a non-header only lib?
AbrilRBS
pushed a commit
to AbrilRBS/conan-center-index
that referenced
this pull request
Jan 16, 2023
…thon * Fix issues with boost in conan 2 (and boost python) * Fix linker issues with NumPy on Windows * Use run scope when checking python version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: boost/all
Summary of changes
Fix issues to make recipe cross compatible with Conan v1 and v2
self.output.warninginstead ofself.output.warnwhich has been removed from Conan 2transitive_headers=Truefor the dependency onlibbacktrace, to reflect that downstream consumers are exposed to these headers - this is ignored by Conan 1.xself.run()instead of named arguments, as the name for the output differs in Conan 1.x and Conan 2self.dependenciesinstead ofself.requiresto check for the presence of direct dependenciesself.dependencies[].optionsin thetest()method (see this issue), and Conan 2.x cannot accessself.optionsin the test method - the logic to register which executables to run is now moved to CMake - perhaps not ideal but avoids having to mirror logic in bothgenerate()andtest(). The logic can be restored once the recipe targets only Conan 2 onward.conf_infoinstead ofuser_info(the latter is kept for backwards compatibility as it is ignored by Conan 2)Fixes #15003
Fix issues building with Python support (
without_python=False)self._python_versioninside thepackage_id()method, which evaluatesself.optionswhich is forbidden in Conan 2 - at this stage the option already has the correct value and no further check is needed.self.runto query the interpreter version, use therunscope - as the default build scope will implicitly activate vcvars on Windows (altering the expected output of the command) - vcvars is not necessary here.Boost::numpyandBoost::pythontargets, to mirror the upstream usage (the versioned ones are only kept for compatibility according to boost comments).Local testing