[linter] reduce pylint to just one command

[technic]

We can make linter rules for conanfiles simpler by checking folder where conanfile.py is located from the pylint checker.
Then same rule can be applied both to test_package and regular recipe.

---

• I've read the contributing guidelines.
• I've used a recent Conan client version close to the currently deployed.
• I've tried at least one configuration locally with the conan-center hook activated.

[CLAassistant]

All committers have signed the CLA.

[prince-chrismc]

Is the intention here to remove

conan-center-index/linter/pylintrc_testpackage

Line 20 in aeb068b

enable=conan-test-no-name,

?

It seems odd right now the PR in duplicating some of the other code 😳 but this is very very interesting

[technic]

Is the intention here to remove

conan-center-index/linter/pylintrc_testpackage

Line 20 in aeb068b

enable=conan-test-no-name,

I didn't notice difference between test_package and regular recipe pylintrc except conan-missing-name and conan-test-no-name. The intention is to have one pylintrc file and don't use that enable/disable lines which you have mentioned.

If you like this change then pylintrc rules and ci scripts can be adjusted.

[prince-chrismc]

I think it's really good, there's discussion internally about the linter being a pain point for contributing so I think this will be well received

Make sure to comment in #4 :)

[conan-center-bot]

Conan v1 pipeline

Sorry, the build is only launched for Access Request users. You can request access writing in this issue.

---

Conan v2 pipeline (informative, not required for merge)

Sorry, the build is only launched for Access Request users. You can request access writing in this issue.

[AbrilRBS]

This looks great, thanks for your work, we really appreciate it :) (Sorry about the delay in getting this reviewed, we're hard at work for the 2.0 launch)

Just leaving myself a reminder that as #15177 aims to implement pre-commit hooks, it would need to be updated to support this new syntax.

Also could you please update the docs regarding these commands so that they reflect the unified call?

[ericLemanissier]

@technic can you please merge current master into your master, in order to get the fix to pylint workflow 448983c ?

[technic]

rebased

[AbrilRBS]

Thanks, we'll look into this as soon as we can!
We are currently super busy with the imminent 2.0 release so expect this PR to be delayed a bit :)

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[AbrilRBS]

NOT stale, just in the backlog (Sorry @technic to keep you waiting! We really appreciate your patience)

[prince-chrismc]

@technic, we finally agreed to move forward with this change but we need to update the GitHub Actions and delete the dedicated test_package linter since those will be obsolete.

I will push some commit to help ensure this gets moving again :)

[prince-chrismc]

🤔 Not sure if these are supposed to be reported

EDIT:

No they are not

[prince-chrismc]

That matches better to https://github.com/conan-io/conan-center-index/actions/runs/4165393769 with was the last PR

[SpaceIm]

Is this PR responsible of this error https://github.com/conan-io/conan-center-index/actions/runs/4736184559/jobs/8407382514?pr=17062? Seems to be a regression.

[prince-chrismc]

Yes... Someone added checks but only in 1 of the two spots 😵‍💫 alrighty then!

[prince-chrismc]

#17103 :)