Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libcap: Modernize #15135

Merged
merged 2 commits into from
Jan 16, 2023
Merged

Conversation

jwillikers
Copy link
Contributor

@jwillikers jwillikers commented Jan 6, 2023

Specify library name and version: libcap/*


@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline

All green in build 2 (68133793154cf4590d0163e1de87a57b357524b4):

  • libcap/2.45@:
    All packages built successfully! (All logs)

  • libcap/2.48@:
    All packages built successfully! (All logs)

  • libcap/2.46@:
    All packages built successfully! (All logs)

  • libcap/2.57@:
    All packages built successfully! (All logs)

  • libcap/2.58@:
    All packages built successfully! (All logs)

  • libcap/2.65@:
    All packages built successfully! (All logs)

  • libcap/2.50@:
    All packages built successfully! (All logs)

  • libcap/2.62@:
    All packages built successfully! (All logs)

  • libcap/2.66@:
    All packages built successfully! (All logs)


Conan v2 pipeline (informative, not required for merge)

Failure in build 2 (68133793154cf4590d0163e1de87a57b357524b4):

  • libcap/2.45@:
    Cannot cast object 'capabilities' with class 'java.lang.String' to class 'java.util.Set'

  • libcap/2.46@:
    Cannot cast object 'capabilities' with class 'java.lang.String' to class 'java.util.Set'

  • libcap/2.50@:
    Cannot cast object 'capabilities' with class 'java.lang.String' to class 'java.util.Set'

  • libcap/2.58@:
    Cannot cast object 'capabilities' with class 'java.lang.String' to class 'java.util.Set'

  • libcap/2.48@:
    Cannot cast object 'capabilities' with class 'java.lang.String' to class 'java.util.Set'

  • libcap/2.57@:
    Cannot cast object 'capabilities' with class 'java.lang.String' to class 'java.util.Set'

  • libcap/2.66@:
    Cannot cast object 'capabilities' with class 'java.lang.String' to class 'java.util.Set'

  • libcap/2.62@:
    Cannot cast object 'capabilities' with class 'java.lang.String' to class 'java.util.Set'

  • libcap/2.65@:
    Cannot cast object 'capabilities' with class 'java.lang.String' to class 'java.util.Set'


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -64,8 +61,10 @@ def generate(self):
env.define("lib", "lib")

if cross_building(self) and not env.vars(self).get("BUILD_CC"):
native_cc = "cc"
self.output.info("Using native compiler '{}'".format(native_cc))
native_cc = VirtualBuildEnv(self).vars().get("CC")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice trick! The global.conf has compiler_executables which can configure which compiler should be used, but it's automatically managed in Toolchain generators.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uilianries I don't think BUILD_CC is set automatically, is it? I used @SpaceIm's trick from the Boost recipe here, but I can't actually determine the compiler_executables in the build context, see issue #12860.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BUILD_CC is not a standard env variable

@conan-center-bot conan-center-bot merged commit 6bbc98e into conan-io:master Jan 16, 2023
pass
self.options.rm_safe("fPIC")
self.settings.rm_safe("compiler.libcxx")
self.settings.rm_safe("compiler.cppstd")

def validate(self):
if self.info.settings.os != "Linux":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self.settings

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SpaceIm I must be missing something obvious here, what needs corrected?

Copy link
Contributor

@SpaceIm SpaceIm Jan 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self.info is not allowed in validate() in conan v2 anymore. This is why I think it's urgent to not worry that much about small details of conan v2 beta to avoid polluting recipes with stuff we'll have to revert anyway.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha, thanks!

AbrilRBS pushed a commit to AbrilRBS/conan-center-index that referenced this pull request Jan 16, 2023
* libcap: Modernize

* Add VirtualBuildEnv too
@jwillikers jwillikers deleted the libcap-modernize branch January 16, 2023 14:08
@jwillikers jwillikers mentioned this pull request Jan 16, 2023
3 tasks
franramirez688 pushed a commit to franramirez688/conan-center-index that referenced this pull request Jan 20, 2023
* libcap: Modernize

* Add VirtualBuildEnv too
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants