confu_json: support for c++17 #15199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This was referenced Jan 10, 2023
This was referenced Jan 22, 2023
|
I detected other pull requests that are modifying confu_json/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
AbrilRBS
previously approved these changes
Jan 27, 2023
There was a problem hiding this comment.
Hi! Thanks for your patience, sorry that this took so long to get reviewed, we're hard at work for the 2.0 launch. We really appreciate the time you took to implement this.
I can only see one small issue here to help with Conan2 compatibility, but otherwise looks great.
uilianries
reviewed
Jan 27, 2023
Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 15 (
Conan v2 pipeline (informative, not required for merge) ❌
The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future. See details:Failure in build 15 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
1 task
prince-chrismc
approved these changes
Jan 30, 2023
StellaSmith
pushed a commit
to StellaSmith/conan-center-index
that referenced
this pull request
Feb 2, 2023
* new version. support for c++17 * hook feedback * replaced missing property with magic number. * new line * new line * imports * import * import * import * bug fix comparing * msvc version check * Update recipes/confu_json/all/conanfile.py Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es> * Update recipes/confu_json/all/conanfile.py Co-authored-by: Uilian Ries <uilianries@gmail.com> * Update recipes/confu_json/all/conanfile.py Co-authored-by: Uilian Ries <uilianries@gmail.com> * missing include. new sha because of rerelease * gcc is only supported in versions greater than or equal 1.0.0. --------- Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es> Co-authored-by: Uilian Ries <uilianries@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: confu_json/1.0.0
removed c++20 dependency. This lib should now compile with c++17