libavrocpp: install either static or shared + fix discovery of Snappy + do not sugget unofficial imported target names #15274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libavrocpp doesn't install a CMake config file, so there is no reason to change default target name of CMakeDeps
|
There is one more problem in this recipe: shared & static are installed together. |
SpaceIm
changed the title
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jwillikers
approved these changes
Jan 25, 2023
Conan v1 pipeline ✔️All green in build 4 (
Conan v2 pipeline (informative, not required for merge) ❌
The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future. See details:Failure in build 4 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
StellaSmith
pushed a commit
to StellaSmith/conan-center-index
that referenced
this pull request
Feb 2, 2023
…scovery of Snappy + do not sugget unofficial imported target names * use self.dependencies * do not suggest unofficial imported target name libavrocpp doesn't install a CMake config file, so there is no reason to change default target name of CMakeDeps * robust discovery & link to Snappy * install either static or shared * bum min conan version to 1.54.0 to avoid injection of CMP0077 * only propagate required boost components * more fix for snappy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no config file upstream, so the rational for defining custom target names was wrong. Upstream logical target names don't matter, only matters imported target names in config file if it's created.
closes #15495