-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libsvm: modernize more #15285
Merged
conan-center-bot
merged 3 commits into
conan-io:master
from
SpaceIm:libsvm-few-improvements
Jan 27, 2023
Merged
libsvm: modernize more #15285
conan-center-bot
merged 3 commits into
conan-io:master
from
SpaceIm:libsvm-few-improvements
Jan 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SpaceIm
commented
Jan 16, 2023
•
edited
Loading
edited
- I've read the contributing guidelines.
- I've used a recent Conan client version close to the currently deployed.
- I've tried at least one configuration locally with the conan-center hook activated.
SpaceIm
force-pushed
the
libsvm-few-improvements
branch
from
January 16, 2023 00:43
701e476
to
e3e862b
Compare
This comment has been minimized.
This comment has been minimized.
SpaceIm
force-pushed
the
libsvm-few-improvements
branch
from
January 16, 2023 08:44
e3e862b
to
84eded1
Compare
SpaceIm
changed the title
libsvm: export symbols with .def for msvc + remove compiler.libcxx + modernize more
libsvm: export symbols with .def for msvc + modernize more
Jan 16, 2023
This comment has been minimized.
This comment has been minimized.
This reverts commit 812bd61.
SpaceIm
changed the title
libsvm: export symbols with .def for msvc + modernize more
libsvm: modernize more
Jan 16, 2023
jwillikers
approved these changes
Jan 25, 2023
uilianries
approved these changes
Jan 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
StellaSmith
pushed a commit
to StellaSmith/conan-center-index
that referenced
this pull request
Feb 2, 2023
* use .def to export symbols for msvc shared * modernize more for conan v2 * Revert "use .def to export symbols for msvc shared" This reverts commit 812bd61.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.