Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libsvm: modernize more #15285

Merged
merged 3 commits into from
Jan 27, 2023

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Jan 16, 2023


@conan-center-bot

This comment has been minimized.

@SpaceIm SpaceIm force-pushed the libsvm-few-improvements branch from e3e862b to 84eded1 Compare January 16, 2023 08:44
@SpaceIm SpaceIm changed the title libsvm: export symbols with .def for msvc + remove compiler.libcxx + modernize more libsvm: export symbols with .def for msvc + modernize more Jan 16, 2023
@conan-center-bot

This comment has been minimized.

@SpaceIm SpaceIm changed the title libsvm: export symbols with .def for msvc + modernize more libsvm: modernize more Jan 16, 2023
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline

All green in build 4 (561ed01bc6219fe65579588880d6ea0ed34f33d7):

  • libsvm/325@:
    All packages built successfully! (All logs)

  • libsvm/324@:
    All packages built successfully! (All logs)

  • libsvm/330@:
    All packages built successfully! (All logs)

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit b7414d7 into conan-io:master Jan 27, 2023
@SpaceIm SpaceIm deleted the libsvm-few-improvements branch January 27, 2023 19:51
StellaSmith pushed a commit to StellaSmith/conan-center-index that referenced this pull request Feb 2, 2023
* use .def to export symbols for msvc shared

* modernize more for conan v2

* Revert "use .def to export symbols for msvc shared"

This reverts commit 812bd61.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants