Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spix/0.5 #15293

Merged
merged 14 commits into from
Feb 11, 2023
Merged

Add spix/0.5 #15293

merged 14 commits into from
Feb 11, 2023

Conversation

fdgStilla
Copy link
Contributor

@fdgStilla fdgStilla commented Jan 16, 2023

Specify library name and version: spix/0.5

Fixes #15292

Tested locally with Visual Studio 2019.


@conan-center-bot

This comment has been minimized.

@fdgStilla
Copy link
Contributor Author

Note: the test_v1_package is working well.
However the test_package is returning this error:

-- Conan: Target declared 'harfbuzz::harfbuzz'
-- Conan: Component target declared 'glib::glib-2.0'
-- Conan: Component target declared 'glib::gmodule-no-export-2.0'
-- Conan: Component target declared 'glib::gmodule-export-2.0'
-- Conan: Component target declared 'glib::gmodule-2.0'
-- Conan: Component target declared 'glib::gobject-2.0'
-- Conan: Component target declared 'glib::gthread-2.0'
-- Conan: Component target declared 'glib::gio-2.0'
-- Conan: Component target declared 'glib::gresource'
-- Conan: Component target declared 'glib::gio-windows-2.0'
-- Conan: Target declared 'glib::glib'
CMake Error at build/generators/cmakedeps_macros.cmake:39 (message):
Library 'gio-2.0' not found in package. If 'gio-2.0' is a system library,
declare it with 'cpp_info.system_libs' property
Call Stack (most recent call first):
build/generators/glib-Target-debug.cmake:34 (conan_package_library_targets)
build/generators/glibTargets.cmake:26 (include)
build/generators/glib-config.cmake:10 (include)
C:/Program Files (x86)/Microsoft Visual Studio/2019/Professional/Common7/IDE/CommonExtensions/Microsoft/CMake/CMake/share/cmake-3.20/Modules/CMakeFindDependencyMacro.cmake:47 (find_package)
build/generators/harfbuzz-config.cmake:18 (find_dependency)
C:/Program Files (x86)/Microsoft Visual Studio/2019/Professional/Common7/IDE/CommonExtensions/Microsoft/CMake/CMake/share/cmake-3.20/Modules/CMakeFindDependencyMacro.cmake:47 (find_package)
build/generators/Qt6Config.cmake:18 (find_dependency)
C:/Program Files (x86)/Microsoft Visual Studio/2019/Professional/Common7/IDE/CommonExtensions/Microsoft/CMake/CMake/share/cmake-3.20/Modules/CMakeFindDependencyMacro.cmake:47 (find_package)
build/generators/SpixConfig.cmake:18 (find_dependency)
CMakeLists.txt:5 (find_package)

Which does not seem to be linked to this package (I tested 0.4 on master and it has the same issue).

@conan-center-bot

This comment has been minimized.

uilianries
uilianries previously approved these changes Jan 27, 2023
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Expat is not listed in spix project, removing it makes sense.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

prince-chrismc
prince-chrismc previously approved these changes Feb 7, 2023
recipes/spix/all/conanfile.py Show resolved Hide resolved
Copy link
Contributor

@jwillikers jwillikers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add msvc support?

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 9 (81b588121752b371bbd5ea294bddfb9e3ecf97f5):

  • spix/0.4@:
    All packages built successfully! (All logs)

  • spix/0.5@:
    All packages built successfully! (All logs)


Conan v2 pipeline (informative, not required for merge) ❌

Note: Conan v2 builds are informative and they are not required for the PR to be merged.

The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future.

See details:

Failure in build 9 (81b588121752b371bbd5ea294bddfb9e3ecf97f5):

  • spix/0.4@:
    Error running command conan graph info --requires spix/0.4@#b85c514fb6f8aa88b24ce9d52aa06acf -f json -pr:h /home/conan/w/prod-v2_cci_PR-15293/9/b2d733d8-d9d6-4596-b866-3fb5e0fa9ff9/profile_linux_11_libstdcpp11_gcc_release_64.-shared-False.txt -pr:b /home/conan/w/prod-v2_cci_PR-15293/9/b2d733d8-d9d6-4596-b866-3fb5e0fa9ff9/profile_linux_11_libstdcpp11_gcc_release_64.-shared-False.txt:

    -------- Input profiles --------
    Profile host:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.libcxx=libstdc++11
    compiler.version=11
    os=Linux
    [options]
    */*:shared=False
    
    Profile build:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.libcxx=libstdc++11
    compiler.version=11
    os=Linux
    [options]
    */*:shared=False
    
    
    -------- Computing dependency graph --------
    anyrpc/1.0.2: Not found in local cache, looking in remotes...
    anyrpc/1.0.2: Checking remote: conan-center-v2
    Graph root
        virtual
    Requirements
        spix/0.4#b85c514fb6f8aa88b24ce9d52aa06acf - Cache
    Graph error
        Package 'anyrpc/1.0.2' not resolved: Unable to find 'anyrpc/1.0.2' in remotes
    ERROR: Package 'anyrpc/1.0.2' not resolved: Unable to find 'anyrpc/1.0.2' in remotes
    
  • spix/0.5@:
    Error running command conan graph info --requires spix/0.5@#68351cf0a46019f1fd887fc069ab2127 -f json -pr:h /home/conan/w/prod-v2_cci_PR-15293/9/d1e65ec5-f2cc-46d4-b7fb-4bb1f8152132/profile_linux_11_libstdcpp11_gcc_release_64.-shared-False.txt -pr:b /home/conan/w/prod-v2_cci_PR-15293/9/d1e65ec5-f2cc-46d4-b7fb-4bb1f8152132/profile_linux_11_libstdcpp11_gcc_release_64.-shared-False.txt:

    -------- Input profiles --------
    Profile host:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.libcxx=libstdc++11
    compiler.version=11
    os=Linux
    [options]
    */*:shared=False
    
    Profile build:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.libcxx=libstdc++11
    compiler.version=11
    os=Linux
    [options]
    */*:shared=False
    
    
    -------- Computing dependency graph --------
    anyrpc/1.0.2: Not found in local cache, looking in remotes...
    anyrpc/1.0.2: Checking remote: conan-center-v2
    Graph root
        virtual
    Requirements
        spix/0.5#68351cf0a46019f1fd887fc069ab2127 - Cache
    Graph error
        Package 'anyrpc/1.0.2' not resolved: Unable to find 'anyrpc/1.0.2' in remotes
    ERROR: Package 'anyrpc/1.0.2' not resolved: Unable to find 'anyrpc/1.0.2' in remotes
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@conan-center-bot conan-center-bot merged commit 56030ac into conan-io:master Feb 11, 2023
sabelka pushed a commit to sabelka/conan-center-index that referenced this pull request Feb 12, 2023
* Add version 0.5

* Bump dependencies

* Always use c++17 for test_package (test_v1_package was not working)

* Add version in config.yml

* Review: replace deps_cpp_info by dependencies

* Review: replace info.settings by settings

* Review: Set AnyRpc target name with CMakeDeps

* Review: lint test_package recipes imports

* trigger ci

* Revert "trigger ci"

This reverts commit 2f87f79.

* Fix KB-H041

* Apply suggestions from code review

* use rm_Safe

* fix typos

---------

Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
@fdgStilla
Copy link
Contributor Author

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[request] spix/0.5
5 participants