-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add spix/0.5 #15293
Add spix/0.5 #15293
Conversation
This comment has been minimized.
This comment has been minimized.
Note: the test_v1_package is working well.
Which does not seem to be linked to this package (I tested 0.4 on master and it has the same issue). |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Expat is not listed in spix project, removing it makes sense.
This comment has been minimized.
This comment has been minimized.
This reverts commit 2f87f79.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add msvc
support?
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 9 (
Conan v2 pipeline (informative, not required for merge) ❌
The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future. See details:Failure in build 9 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
* Add version 0.5 * Bump dependencies * Always use c++17 for test_package (test_v1_package was not working) * Add version in config.yml * Review: replace deps_cpp_info by dependencies * Review: replace info.settings by settings * Review: Set AnyRpc target name with CMakeDeps * Review: lint test_package recipes imports * trigger ci * Revert "trigger ci" This reverts commit 2f87f79. * Fix KB-H041 * Apply suggestions from code review * use rm_Safe * fix typos --------- Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
Thanks ! |
Specify library name and version: spix/0.5
Fixes #15292
Tested locally with Visual Studio 2019.