Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lua: conan v2 support & v5.3.6 #15316

Merged
merged 10 commits into from
Jan 27, 2023
Merged

Lua: conan v2 support & v5.3.6 #15316

merged 10 commits into from
Jan 27, 2023

Conversation

StellaSmith
Copy link
Contributor

No description provided.

@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@StellaSmith
Copy link
Contributor Author

StellaSmith commented Jan 17, 2023 •
edited
Loading

Huh. The string didn't get escaped? Is this intended behavior?

@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions github-actions bot mentioned this pull request Jan 17, 2023
Open
uilianries
uilianries reviewed Jan 20, 2023
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating it. Just a small change on test package to re-use same files, so we don't need to update more files. That suggestiong is already integrated to CCI cmake template: https://github.com/conan-io/conan-center-index/tree/master/docs/package_templates/cmake_package/all

recipes/lua/all/conanfile.py Outdated Show resolved Hide resolved
recipes/lua/all/test_v1_package/CMakeLists.txt Outdated Show resolved Hide resolved
recipes/lua/all/test_v1_package/test_package.cpp Outdated Show resolved Hide resolved
StellaSmith and others added 2 commits January 20, 2023 13:52
@StellaSmith @uilianries
Update required_conan_version
5043bfa 
Co-authored-by: Uilian Ries <uilianries@gmail.com>
@StellaSmith @uilianries
Reuse test_package code in test_v1_package
6a721a7 
Co-authored-by: Uilian Ries <uilianries@gmail.com>
@conan-center-bot

This comment has been minimized.

Sign in to view
uilianries
uilianries previously approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StellaSmith @uilianries
End files with newline
8ab8d82 
Co-authored-by: Uilian Ries <uilianries@gmail.com>
uilianries
uilianries previously approved these changes Jan 20, 2023
View reviewed changes
@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit 8ab8d82
lua/5.4.1 
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: liblua.dylib
lua/5.3.6 
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: liblua.dylib
lua/5.4.3 
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: liblua.dylib
lua/5.3.5 
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: liblua.dylib
lua/5.4.4 
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: liblua.dylib

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 9 (6cd98d0180223ab651b5e79587cddad505742478):

  • lua/5.4.4@:
    All packages built successfully! (All logs)

  • lua/5.4.3@:
    All packages built successfully! (All logs)

  • lua/5.3.5@:
    All packages built successfully! (All logs)

  • lua/5.3.6@:
    All packages built successfully! (All logs)

  • lua/5.4.1@:
    All packages built successfully! (All logs)

uilianries
uilianries approved these changes Jan 21, 2023
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

AbrilRBS
AbrilRBS approved these changes Jan 27, 2023
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@conan-center-bot conan-center-bot merged commit 18d4f5f into conan-io:master Jan 27, 2023
StellaSmith added a commit to StellaSmith/conan-center-index that referenced this pull request Feb 2, 2023
@StellaSmith @uilianries
(conan-io#15316) Lua: conan v2 support & v5.3.6
6394186 
* Lua: conan v2 support & v5.3.6

* Also check in test_package this time

* Fix patch

* Use cmake layout

* Use src_folder="src" for layout

* Add package_type & fix cmake syntax error

* Update required_conan_version

Co-authored-by: Uilian Ries <uilianries@gmail.com>

* Reuse test_package code in test_v1_package

Co-authored-by: Uilian Ries <uilianries@gmail.com>

* End files with newline

Co-authored-by: Uilian Ries <uilianries@gmail.com>

* fix apple relocatable shared libs

Co-authored-by: Uilian Ries <uilianries@gmail.com>
@StellaSmith StellaSmith deleted the lua-conan2 branch February 3, 2023 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbrilRBS AbrilRBS AbrilRBS approved these changes

@uilianries uilianries uilianries approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@StellaSmith @conan-center-bot @uilianries @AbrilRBS