Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opencv 2.x: refactor to allow fine-grained selection of each module #15371

Merged
merged 3 commits into from
Jan 31, 2023
Merged

opencv 2.x: refactor to allow fine-grained selection of each module #15371

merged 3 commits into from
Jan 31, 2023

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Jan 19, 2023

Similar to #15193 but much simpler since there are far less modules in OpenCV 2.x

@github-actions github-actions bot mentioned this pull request Jan 20, 2023
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit 12dc173
opencv/2.4.13.7 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\opencv_highgui2413.dll' links to system library 'avifil32' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\opencv_highgui2413.dll' links to system library 'msvfw32' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\opencv_highgui2413d.dll' links to system library 'msvfw32' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\opencv_highgui2413d.dll' links to system library 'avifil32' but it is not in cpp_info.system_libs.

jwillikers
jwillikers previously approved these changes Jan 20, 2023
View reviewed changes
@SpaceIm
check again internal dependencies between options in validate()
4e68692 
in conan v2 downstream options values always have precedence, so we have to check again in validate() that combination of opencv options is still valid
@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit 4e68692
opencv/2.4.13.7 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\opencv_highgui2413.dll' links to system library 'msvfw32' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\opencv_highgui2413.dll' links to system library 'avifil32' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\opencv_highgui2413d.dll' links to system library 'msvfw32' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\opencv_highgui2413d.dll' links to system library 'avifil32' but it is not in cpp_info.system_libs.

jwillikers
jwillikers previously approved these changes Jan 23, 2023
View reviewed changes
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 3 (295d34b904cbf4c6e75951626251cddc68fcba74):

  • opencv/2.4.13.7@:
    All packages built successfully! (All logs)

@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit 295d34b
opencv/2.4.13.7 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\opencv_highgui2413.dll' links to system library 'msvfw32' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\opencv_highgui2413.dll' links to system library 'avifil32' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\opencv_highgui2413d.dll' links to system library 'avifil32' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\opencv_highgui2413d.dll' links to system library 'msvfw32' but it is not in cpp_info.system_libs.

@prince-chrismc prince-chrismc mentioned this pull request Jan 28, 2023
Merged
1 task
uilianries
uilianries approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice job!

@conan-center-bot conan-center-bot merged commit 0043d65 into conan-io:master Jan 31, 2023
@SpaceIm SpaceIm deleted the opencv-2.x-modular branch January 31, 2023 13:05
StellaSmith pushed a commit to StellaSmith/conan-center-index that referenced this pull request Feb 2, 2023
@SpaceIm @StellaSmith
(conan-io#15371) opencv 2.x: refactor to allow fine-grained selection…
3015346 
… of each module

* add options allowing to enable/disable all modules

* check again internal dependencies between options in validate()

in conan v2 downstream options values always have precedence, so we have to check again in validate() that combination of opencv options is still valid

* add world option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwillikers jwillikers jwillikers approved these changes

@uilianries uilianries uilianries approved these changes

@franramirez688 franramirez688 Awaiting requested review from franramirez688

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SpaceIm @conan-center-bot @uilianries @jwillikers