flac: add 1.4.2 #15372

chausner · 2023-01-19T23:56:13Z

Specify library name and version: flac/1.4.2

This PR continues the work started by @Croydon in #13800. The problem in that older PR was that the patches had not been applied.

I've read the contributing guidelines.
I've used a recent Conan client version close to the currently deployed.
I've tried at least one configuration locally with the conan-center hook activated.

Flac 1.4.2 removed the build dependency on nasm https://github.com/xiph/flac/releases/tag/1.4.2 Also switching to the official source download which we can't use for 1.3.3 because it does not include the CMake files.

Croydon

Thank you!

recipes/flac/all/conanfile.py

prince-chrismc

Few extras for this recipe we can sneak in 🙏

https://github.com/conan-io/conan-center-index/pull/15372/files#diff-46e0f445c2645cf966c3341c9e8b009d71467ca87c6418b7a824fa6a9c333559R39 should use rm_safe (bump min conan to 1.53)

https://github.com/conan-io/conan-center-index/pull/15372/files#diff-46e0f445c2645cf966c3341c9e8b009d71467ca87c6418b7a824fa6a9c333559R30-R31
can be replace with the new export_conandata_patches helper

chausner · 2023-01-25T22:06:59Z

Few extras for this recipe we can sneak in 🙏

https://github.com/conan-io/conan-center-index/pull/15372/files#diff-46e0f445c2645cf966c3341c9e8b009d71467ca87c6418b7a824fa6a9c333559R39 should use rm_safe (bump min conan to 1.53)

https://github.com/conan-io/conan-center-index/pull/15372/files#diff-46e0f445c2645cf966c3341c9e8b009d71467ca87c6418b7a824fa6a9c333559R30-R31 can be replace with the new export_conandata_patches helper

Addressed in 9bda74c and 955ef84

prince-chrismc · 2023-01-25T22:29:28Z

SpaceIm

this PR suffered from CI issues, so here some extra reviews to take advantage that another build is required.

CMAKE_POLICY_DEFAULT_CMP0077 not required since conan 1.54.0
keep the TODO to track conan v1 stuff

recipes/flac/all/conanfile.py

Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>

chausner · 2023-02-03T19:52:58Z

this PR suffered from CI issues, so here some extra reviews to take advantage that another build is required.

CMAKE_POLICY_DEFAULT_CMP0077 not required since conan 1.54.0

keep the TODO to track conan v1 stuff

Thank you, I applied all your suggestions.

conan-center-bot · 2023-02-04T08:40:04Z

Conan v1 pipeline ✔️

All green in build 4 (b6a02cf47e604247b9a714bb28087709e8719d49):

flac/1.3.3@:
All packages built successfully! (All logs)
flac/1.4.2@:
All packages built successfully! (All logs)

Conan v2 pipeline (informative, not required for merge) ❌

Note: Conan v2 builds are informative and they are not required for the PR to be merged.

The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future.

See details:

Failure in build 4 (b6a02cf47e604247b9a714bb28087709e8719d49):

An unexpected error happened and has been reported. Help is on its way! 🏇

* flac: add 1.4.2 Flac 1.4.2 removed the build dependency on nasm https://github.com/xiph/flac/releases/tag/1.4.2 Also switching to the official source download which we can't use for 1.3.3 because it does not include the CMake files. * flac: delete CMake and pkgconfig files * Fix shared builds * Adapt patches * Add patch descriptions and types * Remove obsolete Conan version check * Use rm_safe * Use export_conandata_patches * Apply suggestions from code review Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com> --------- Co-authored-by: Cr0ydon <git@cr0ydon.com> Co-authored-by: chausner <chausner@users.noreply.github.com> Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>

Croydon and others added 4 commits October 27, 2022 10:24

flac: add 1.4.2

45da6d3

Flac 1.4.2 removed the build dependency on nasm https://github.com/xiph/flac/releases/tag/1.4.2 Also switching to the official source download which we can't use for 1.3.3 because it does not include the CMake files.

flac: delete CMake and pkgconfig files

e146442

Fix shared builds

902bd8e

Adapt patches

e63f09f

chausner marked this pull request as ready for review January 20, 2023 00:03

Add patch descriptions and types

7a57a02

github-actions bot mentioned this pull request Jan 20, 2023

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

This comment has been minimized.

Sign in to view

This was referenced Jan 20, 2023

Updatable recipes qchateau/conan-center-bot#1

Open

[request] Updatable recipes #3470

Closed

Croydon previously approved these changes Jan 22, 2023

View reviewed changes

jwillikers previously approved these changes Jan 25, 2023

View reviewed changes

prince-chrismc reviewed Jan 25, 2023

View reviewed changes

recipes/flac/all/conanfile.py Outdated Show resolved Hide resolved

prince-chrismc reviewed Jan 25, 2023

View reviewed changes

chausner added 3 commits January 25, 2023 23:05

Remove obsolete Conan version check

91c53fc

Use rm_safe

9bda74c

Use export_conandata_patches

955ef84

chausner dismissed stale reviews from jwillikers and Croydon via 955ef84 January 25, 2023 22:05

jwillikers previously approved these changes Jan 25, 2023

View reviewed changes

prince-chrismc previously approved these changes Jan 25, 2023

View reviewed changes

prince-chrismc mentioned this pull request Jan 28, 2023

Rank effort to review a given PR prince-chrismc/conan-center-index-pending-review#109

Merged

1 task

Croydon previously approved these changes Jan 28, 2023

View reviewed changes

SpaceIm suggested changes Feb 3, 2023

View reviewed changes

recipes/flac/all/conanfile.py Outdated Show resolved Hide resolved

recipes/flac/all/conanfile.py Outdated Show resolved Hide resolved

recipes/flac/all/conanfile.py Show resolved Hide resolved

chausner dismissed Croydon’s stale review via b6a02cf February 3, 2023 19:52

Apply suggestions from code review

b6a02cf

Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>

chausner dismissed prince-chrismc’s stale review via b6a02cf February 3, 2023 19:52

chausner dismissed jwillikers’s stale review via b6a02cf February 3, 2023 19:52

SpaceIm approved these changes Feb 3, 2023

View reviewed changes

prince-chrismc approved these changes Feb 4, 2023

View reviewed changes

conan-center-bot merged commit f993e04 into conan-io:master Feb 4, 2023

MartinDelille mentioned this pull request Feb 4, 2023

[ffmpeg] Modernize #15035

Closed

3 tasks

chausner deleted the flac-1.4.2 branch February 11, 2023 19:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

flac: add 1.4.2 #15372

flac: add 1.4.2 #15372

chausner commented Jan 19, 2023 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

Croydon left a comment

prince-chrismc left a comment

chausner commented Jan 25, 2023

prince-chrismc commented Jan 25, 2023

SpaceIm left a comment •

edited

Loading

chausner commented Feb 3, 2023

conan-center-bot commented Feb 4, 2023

flac: add 1.4.2 #15372

flac: add 1.4.2 #15372

Conversation

chausner commented Jan 19, 2023 • edited Loading

This comment has been minimized.

This comment has been minimized.

Croydon left a comment

Choose a reason for hiding this comment

prince-chrismc left a comment

Choose a reason for hiding this comment

chausner commented Jan 25, 2023

prince-chrismc commented Jan 25, 2023

SpaceIm left a comment • edited Loading

Choose a reason for hiding this comment

chausner commented Feb 3, 2023

conan-center-bot commented Feb 4, 2023

Conan v1 pipeline ✔️

Conan v2 pipeline (informative, not required for merge) ❌

chausner commented Jan 19, 2023 •

edited

Loading

SpaceIm left a comment •

edited

Loading