Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update tcl/* dependencies #15384

Merged
merged 2 commits into from
Feb 1, 2023
Merged

update tcl/* dependencies #15384

merged 2 commits into from
Feb 1, 2023

Conversation

EricAtORS
Copy link
Contributor

Update tcl dependencies for #15383

@github-actions github-actions bot mentioned this pull request Jan 20, 2023
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@EricAtORS EricAtORS marked this pull request as draft January 20, 2023 22:11
@EricAtORS EricAtORS marked this pull request as ready for review January 23, 2023 22:29
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 3 (aa3f1523abaf3121418483f338d5a36ff9ff0c8b):

  • tcl/8.6.10@:
    All packages built successfully! (All logs)

  • tcl/8.6.11@:
    All packages built successfully! (All logs)

@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit aa3f152
tcl/8.6.10 
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libtcl8.6.dylib
tcl/8.6.11 
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libtcl8.6.dylib

@prince-chrismc prince-chrismc mentioned this pull request Jan 28, 2023
Merged
1 task
uilianries
uilianries approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good enough to be merged now. In future we will need to update for Conan 2.0. Thank you for your contribution.

recipes/tcl/all/conanfile.py
@@ -137,7 +139,8 @@ def _build_nmake(self, targets):
@functools.lru_cache(1)
def _configure_autotools(self):
autotools = AutoToolsBuildEnvironment(self, win_bash=tools.os_info.is_windows)
yes_no = lambda v: "yes" if v else "no"
def yes_no(v):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please, avoid updating methods which are working already, like this lamdba which largely used in CCI (around 470 occurrences)

@conan-center-bot conan-center-bot merged commit ab8b2b1 into conan-io:master Feb 1, 2023
StellaSmith pushed a commit to StellaSmith/conan-center-index that referenced this pull request Feb 2, 2023
@EricAtORS @EricTheMagician @StellaSmith
(conan-io#15384) update tcl/* dependencies
bf5fc0f 
* update tcl dependencies

* update for conan v2

---------

Co-authored-by: Eric Yen <eric@ericyen.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uilianries uilianries uilianries approved these changes

@ericLemanissier ericLemanissier ericLemanissier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@EricAtORS @conan-center-bot @ericLemanissier @uilianries @EricTheMagician