-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
arrow/10.0.0: link re2 to libparquet
and libarrow
#15420
Conversation
recipes/arrow/all/conanfile.py
Outdated
for comp in ["libgandiva", "libparquet", "libarrow"]: | ||
self.cpp_info.components[comp].requires.append("re2::re2") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems wrong when gandiva
or parquet
options are False.
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit ba1fc7aarrow/10.0.0
arrow/8.0.1
arrow/1.0.0
arrow/7.0.0
arrow/2.0.0
arrow/8.0.0
|
I detected other pull requests that are modifying arrow/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
@@ -637,7 +637,11 @@ def package_info(self): | |||
if self.options.with_mimalloc: | |||
self.cpp_info.components["libarrow"].requires.append("mimalloc::mimalloc") | |||
if self._with_re2(): | |||
self.cpp_info.components["libgandiva"].requires.append("re2::re2") | |||
if self.options.gandiva: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kou could you please confirm - does this change make sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. It makes sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks you taking the time to answer!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 4 (
Conan v2 pipeline (informative, not required for merge) ❌
The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future. See details:Failure in build 3 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
* link re2 to `libparquet` and `libarrow` fixes conan-io#15413 * require re2 only from enabled components
fixes #15413
Specify library name and version: arrow/10.0.0