cppcheck: put all resources back in bin folder #15424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otherwise cppcheck does not find them fixes conan-io#15421
SpaceIm
approved these changes
Jan 23, 2023
SpaceIm
reviewed
Jan 23, 2023
| @@ -44,7 +44,7 @@ def generate(self): | |||
| tc.variables["HAVE_RULES"] = self.options.have_rules | |||
| tc.variables["USE_MATCHCOMPILER"] = "Auto" | |||
| tc.variables["ENABLE_OSS_FUZZ"] = False | |||
| tc.variables["FILESDIR"] = os.path.join(self.package_folder, "res").replace('\\', '/') | |||
| tc.variables["FILESDIR"] = os.path.join(self.package_folder, "bin").replace('\\', '/') | |||
There was a problem hiding this comment.
maybe extend the test to check that nobody will break it again?
There was a problem hiding this comment.
unfortunately I don't think we can make a breaking test, because cppcheck stores the absolute path to this FILESDIR folder at build time and uses it as a fallback if the .cfg files cannot be found in the folder next to the cppcheck executable. It means we can only break by downloading an existing package binary into a package folder different from the one used during build :/
Conan v1 pipeline ✔️All green in build 1 ( |
jwillikers
approved these changes
Jan 23, 2023
EstebanDugueperoux2
approved these changes
Jan 24, 2023
prince-chrismc
approved these changes
Jan 25, 2023
StellaSmith
pushed a commit
to StellaSmith/conan-center-index
that referenced
this pull request
Feb 2, 2023
otherwise cppcheck does not find them fixes conan-io#15421
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
otherwise cppcheck does not find them
fixes #15421
Specify library name and version: cppcheck/*