Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qhull: add version 8.0.2 #15428

Closed
wants to merge 2 commits into from
Closed

qhull: add version 8.0.2 #15428

wants to merge 2 commits into from

Conversation

toge
Copy link
Contributor

@toge toge commented Jan 23, 2023

Specify library name and version: qhull/8.0.2

retry #14114


@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 1 (4d6537a47b421bbeb1e50a8006bdd321f873abb3):

  • qhull/8.0.0@:
    All packages built successfully! (All logs)

  • qhull/8.0.1@:
    All packages built successfully! (All logs)

  • qhull/7.3.2@:
    All packages built successfully! (All logs)

  • qhull/8.0.2@:
    All packages built successfully! (All logs)

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SpaceIm
Copy link
Contributor

SpaceIm commented Jan 31, 2023

Build and packaging of 8.0.2 still looks wrong to me (slightly different than #14114 (comment), but still incorrect).

  • 8.0.1:

    • Linux static:

      qhull/8.0.1 package(): Packaged 2 '.a' files: libqhullstatic.a, libqhullstatic_r.a
      
    • Linux shared:

      qhull/8.0.1 package(): Packaged 2 '.1' files: libqhull.so.8.0.1, libqhull_r.so.8.0.1
      qhull/8.0.1 package(): Packaged 2 '.so' files: libqhull_r.so, libqhull.so
      qhull/8.0.1 package(): Packaged 2 '.0' files: libqhull_r.so.8.0, libqhull.so.8.0
      
  • 8.0.2:

    • Linux static:

      qhull/8.0.2 package(): Packaged 3 '.a' files: libqhullstatic.a, libqhullcpp.a, libqhullstatic_r.a
      
    • Linux shared:

      qhull/8.0.2 package(): Packaged 1 '.so' file: libqhull_r.so
      qhull/8.0.2 package(): Packaged 1 '.0' file: libqhull_r.so.8.0
      qhull/8.0.2 package(): Packaged 1 '.2' file: libqhull_r.so.8.0.2
      

So we see that non-reentrant shared qhull is missing in 8.0.2, and libqhullcpp is built & packaged if static while it should not.

@toge
Copy link
Contributor Author

toge commented Jan 31, 2023

@SpaceIm
Thank you for the detailed information.
I understand what you said very well.
I will try to solve the problem and create PR if I am successful.

@toge toge marked this pull request as draft January 31, 2023 16:59
@ghost ghost mentioned this pull request Feb 28, 2023
3 tasks
@stale
Copy link

stale bot commented Mar 11, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 11, 2023
@stale
Copy link

stale bot commented Apr 25, 2023

This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions.

@stale stale bot closed this Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants