-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update strong_type, v10 #15447
Update strong_type, v10 #15447
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@@ -23,6 +25,8 @@ def package_id(self): | |||
def validate(self): | |||
if self.settings.compiler.get_safe("cppstd"): | |||
check_min_cppstd(self, 14) | |||
if self.settings.compiler == "gcc" and Version(self.settings.compiler.version) < "7": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this only limited to the the newer version? the old one passed in previous PRs ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Previous versions did not trigger that gcc bug.
But it's not worth keeping that combination alive for old compilers and adding branches in that recipe.
Nobody using that lib is tied to such old compilers. That's a different scene, so a simpler recipe wins. (IMHO)
Conan v1 pipeline ✔️All green in build 4 (
Conan v2 pipeline (informative, not required for merge) ❌
The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future. See details:Failure in build 4 ( An unexpected error happened and has been reported. Help is on its way! 🏇 |
* Update strong_type, v9 * Set minimum GCC to 7 * Add version v10
Specify library name and version: strong_type/v9