Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update strong_type, v10 #15447

Merged
merged 3 commits into from
Feb 5, 2023
Merged

Conversation

a4z
Copy link
Contributor

@a4z a4z commented Jan 24, 2023

Specify library name and version: strong_type/v9


@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@@ -23,6 +25,8 @@ def package_id(self):
def validate(self):
if self.settings.compiler.get_safe("cppstd"):
check_min_cppstd(self, 14)
if self.settings.compiler == "gcc" and Version(self.settings.compiler.version) < "7":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this only limited to the the newer version? the old one passed in previous PRs ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Previous versions did not trigger that gcc bug.
But it's not worth keeping that combination alive for old compilers and adding branches in that recipe.
Nobody using that lib is tied to such old compilers. That's a different scene, so a simpler recipe wins. (IMHO)

@a4z a4z requested a review from prince-chrismc January 30, 2023 13:23
uilianries
uilianries previously approved these changes Feb 3, 2023
@a4z a4z requested review from uilianries and prince-chrismc and removed request for prince-chrismc and uilianries February 3, 2023 21:40
@prince-chrismc prince-chrismc changed the title Update strong_type, v9 Update strong_type, v10 Feb 4, 2023
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 4 (c7e253e0a666f231c0be6e98912e1139cd304959):

  • strong_type/v8@:
    All packages built successfully! (All logs)

  • strong_type/v10@:
    All packages built successfully! (All logs)

  • strong_type/v7@:
    All packages built successfully! (All logs)

  • strong_type/v9@:
    All packages built successfully! (All logs)


Conan v2 pipeline (informative, not required for merge) ❌

Note: Conan v2 builds are informative and they are not required for the PR to be merged.

The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future.

See details:

Failure in build 4 (c7e253e0a666f231c0be6e98912e1139cd304959):

An unexpected error happened and has been reported. Help is on its way! 🏇

@a4z a4z requested a review from uilianries February 4, 2023 09:01
@conan-center-bot conan-center-bot merged commit f9bc58b into conan-io:master Feb 5, 2023
sabelka pushed a commit to sabelka/conan-center-index that referenced this pull request Feb 12, 2023
* Update strong_type, v9

* Set minimum GCC to 7

* Add version v10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants