fixes for linking with qtwebengine and qtpdf in qt/6.4.x #15472
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I detected other pull requests that are modifying qt/6.x.x recipe:
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This was referenced Jan 25, 2023
jwillikers
approved these changes
Jan 26, 2023
ghost
mentioned this pull request
3 tasks
1 task
|
An internal error occurred and just restarted this CI build now. |
Conan v1 pipeline ✔️All green in build 2 (
Conan v2 pipeline (informative, not required for merge) ❌Failure in build 1 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
Hooks produced the following warnings for commit baa3cccqt/6.4.2qt/6.4.1qt/6.2.4qt/6.3.2 |
ericLemanissier
suggested changes
Feb 1, 2023
Comment on lines
+289
to
+291
| if not self.options.with_glib: | ||
| # it's not really needed, it's only for the pdf reader inside of chromium | ||
| raise ConanInvalidConfiguration("option qt:webengine requires also qt:with_glib on Linux") |
There was a problem hiding this comment.
if it's not actually required, please don't raise an exception. It will break some users which don't care about pdf reader.
Instead, you could either print a warning message, or add an option to the recipe for the pdf reader.
There was a problem hiding this comment.
I understand.
At the moment, the qtpdf is automatically brought in when compiling the qtwebengine and I don't know how to explicitly disable it. Since it's automatically brought it, it does make it a required component in that sense, but if there was a away to disable qtpdf, then it would become optional.
There was a problem hiding this comment.
My impression has been that qtpdf is really a portion of qtwebengine.
There was a problem hiding this comment.
I can see why you say that.
So just to confirm that I understand, the suggestion is that I expose the qtpdf module as a build option in conan add that extra check in the validatiion for glib?
This was referenced Feb 2, 2023
This was referenced Feb 27, 2023
ghost
mentioned this pull request
3 tasks
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This was referenced Mar 16, 2023
Closed
|
This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: qt/6.4.x
These changes addresses the remaining linking issues in #14884