Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cppunit: modernize more for conan v2 #15759

Merged
merged 6 commits into from
Feb 20, 2023

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Feb 6, 2023

Specify library name and version: lib/1.0


@conan-center-bot

This comment has been minimized.

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Feb 6, 2023

error: /Applications/conan/xcode/11.0/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/install_name_tool: changing install names or rpaths can't be redone for: /Users/jenkins/w/prod/BuildSingleReference@3/.conan/data/cppunit/1.15.1/_/_/package/d182ba58b0d1d0d375072af5bab5ee0790f469dd/bin/DllPlugInTester (for architecture x86_64) because larger updated load commands do not fit (the program must be relinked, and you may need to use -headerpad or -headerpad_max_install_names)
cppunit/1.15.1: WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
ERROR: cppunit/1.15.1: Error in package() method, line 111
	fix_apple_shared_install_name(self)
	ConanException: Error 1 while executing install_name_tool /Users/jenkins/w/prod/BuildSingleReference@3/.conan/data/cppunit/1.15.1/_/_/package/d182ba58b0d1d0d375072af5bab5ee0790f469dd/bin/DllPlugInTester -add_rpath @executable_path/../lib

@jcar87 here is an example of the reason why passing -headerpad_max_install_names is important in conan-center recipes.

jwillikers
jwillikers previously approved these changes Feb 6, 2023
@conan-center-bot

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2023

Hooks produced the following warnings for commit fc3e70f
cppunit/1.15.1
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libcppunit.so' links to system library 'm' but it is not in cpp_info.system_libs.

jwillikers
jwillikers previously approved these changes Feb 6, 2023
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

jwillikers
jwillikers previously approved these changes Feb 15, 2023
prince-chrismc
prince-chrismc previously approved these changes Feb 16, 2023
@prince-chrismc prince-chrismc dismissed stale reviews from jwillikers and themself via 576b985 February 16, 2023 06:18
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 5 (576b9855a1a2f5eba3cbaa117844c7bf0ff80157):

  • cppunit/1.15.1@:
    All packages built successfully! (All logs)

Conan v2 pipeline (informative, not required for merge) ❌

Note: Conan v2 builds are informative and they are not required for the PR to be merged.

The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future.

See details:

Failure in build 5 (576b9855a1a2f5eba3cbaa117844c7bf0ff80157):

  • cppunit/1.15.1@:
    CI failed to create some packages (All logs)

    Logs for packageID ae9eaf478e918e6470fe64a4d8d4d9552b0b3606:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=msvc
    compiler.runtime=dynamic
    compiler.runtime_type=Release
    compiler.version=192
    os=Windows
    [options]
    */*:shared=True
    
    [...]
    make[3]: Nothing to be done for 'install-exec-am'.
    make[3]: Nothing to be done for 'install-data-am'.
    make[3]: Leaving directory '/c/J/w/prod-v2/BuildSingleReference/p/t/cppun6140e627ade00/b/build-release/examples/DumperPlugIn'
    make[2]: Leaving directory '/c/J/w/prod-v2/BuildSingleReference/p/t/cppun6140e627ade00/b/build-release/examples/DumperPlugIn'
    Making install in money
    make[2]: Entering directory '/c/J/w/prod-v2/BuildSingleReference/p/t/cppun6140e627ade00/b/build-release/examples/money'
    make[3]: Entering directory '/c/J/w/prod-v2/BuildSingleReference/p/t/cppun6140e627ade00/b/build-release/examples/money'
    make[3]: Nothing to be done for 'install-exec-am'.
    make[3]: Nothing to be done for 'install-data-am'.
    make[3]: Leaving directory '/c/J/w/prod-v2/BuildSingleReference/p/t/cppun6140e627ade00/b/build-release/examples/money'
    make[2]: Leaving directory '/c/J/w/prod-v2/BuildSingleReference/p/t/cppun6140e627ade00/b/build-release/examples/money'
    make[2]: Entering directory '/c/J/w/prod-v2/BuildSingleReference/p/t/cppun6140e627ade00/b/build-release/examples'
    make[3]: Entering directory '/c/J/w/prod-v2/BuildSingleReference/p/t/cppun6140e627ade00/b/build-release/examples'
    make[3]: Nothing to be done for 'install-exec-am'.
    make[3]: Nothing to be done for 'install-data-am'.
    make[3]: Leaving directory '/c/J/w/prod-v2/BuildSingleReference/p/t/cppun6140e627ade00/b/build-release/examples'
    make[2]: Leaving directory '/c/J/w/prod-v2/BuildSingleReference/p/t/cppun6140e627ade00/b/build-release/examples'
    make[1]: Leaving directory '/c/J/w/prod-v2/BuildSingleReference/p/t/cppun6140e627ade00/b/build-release/examples'
    Making install in doc
    make[1]: Entering directory '/c/J/w/prod-v2/BuildSingleReference/p/t/cppun6140e627ade00/b/build-release/doc'
    make[2]: Entering directory '/c/J/w/prod-v2/BuildSingleReference/p/t/cppun6140e627ade00/b/build-release/doc'
    make[2]: Nothing to be done for 'install-exec-am'.
    make  install-data-hook
    make[3]: Entering directory '/c/J/w/prod-v2/BuildSingleReference/p/t/cppun6140e627ade00/b/build-release/doc'
    make[3]: Nothing to be done for 'install-data-hook'.
    make[3]: Leaving directory '/c/J/w/prod-v2/BuildSingleReference/p/t/cppun6140e627ade00/b/build-release/doc'
    make[2]: Leaving directory '/c/J/w/prod-v2/BuildSingleReference/p/t/cppun6140e627ade00/b/build-release/doc'
    make[1]: Leaving directory '/c/J/w/prod-v2/BuildSingleReference/p/t/cppun6140e627ade00/b/build-release/doc'
    make[1]: Entering directory '/c/J/w/prod-v2/BuildSingleReference/p/t/cppun6140e627ade00/b/build-release'
    make[2]: Entering directory '/c/J/w/prod-v2/BuildSingleReference/p/t/cppun6140e627ade00/b/build-release'
    make[2]: Nothing to be done for 'install-exec-am'.
     /c/j/w/prod-v2/buildsinglereference/p/msys280d8cd7b89549/p/bin/msys64/usr/bin/mkdir -p '/c/j/w/prod-v2/buildsinglereference/p/t/cppun6140e627ade00/p//share/doc/cppunit'
     /c/j/w/prod-v2/buildsinglereference/p/msys280d8cd7b89549/p/bin/msys64/usr/bin/mkdir -p '/c/j/w/prod-v2/buildsinglereference/p/t/cppun6140e627ade00/p/lib/pkgconfig'
     /usr/bin/install -c -m 644 /c/j/w/prod-v2/buildsinglereference/p/t/cppun6140e627ade00/b/src/BUGS /c/j/w/prod-v2/buildsinglereference/p/t/cppun6140e627ade00/b/src/INSTALL /c/j/w/prod-v2/buildsinglereference/p/t/cppun6140e627ade00/b/src/INSTALL-unix /c/j/w/prod-v2/buildsinglereference/p/t/cppun6140e627ade00/b/src/INSTALL-WIN32.txt /c/j/w/prod-v2/buildsinglereference/p/t/cppun6140e627ade00/b/src/CodingGuideLines.txt /c/j/w/prod-v2/buildsinglereference/p/t/cppun6140e627ade00/b/src/AUTHORS /c/j/w/prod-v2/buildsinglereference/p/t/cppun6140e627ade00/b/src/doc/FAQ '/c/j/w/prod-v2/buildsinglereference/p/t/cppun6140e627ade00/p//share/doc/cppunit'
     /usr/bin/install -c -m 644 cppunit.pc '/c/j/w/prod-v2/buildsinglereference/p/t/cppun6140e627ade00/p/lib/pkgconfig'
    make[2]: Leaving directory '/c/J/w/prod-v2/BuildSingleReference/p/t/cppun6140e627ade00/b/build-release'
    make[1]: Leaving directory '/c/J/w/prod-v2/BuildSingleReference/p/t/cppun6140e627ade00/b/build-release'
    cppunit/1.15.1: [HOOK - hook_conan-center-v2.py] post_package(): [PACKAGE LICENSE (KB-H012)] OK
    cppunit/1.15.1: [HOOK - hook_conan-center-v2.py] post_package(): [DEFAULT PACKAGE LAYOUT (KB-H013)] OK
    cppunit/1.15.1: [HOOK - hook_conan-center-v2.py] post_package(): [MATCHING CONFIGURATION (KB-H014)] OK
    cppunit/1.15.1: [HOOK - hook_conan-center-v2.py] post_package(): [SHARED ARTIFACTS (KB-H015)] OK
    cppunit/1.15.1: [HOOK - hook_conan-center-v2.py] post_package(): [STATIC ARTIFACTS (KB-H074)] OK
    cppunit/1.15.1: [HOOK - hook_conan-center-v2.py] post_package(): [PC-FILES (KB-H020)] OK
    cppunit/1.15.1: [HOOK - hook_conan-center-v2.py] post_package(): [CMAKE-MODULES-CONFIG-FILES (KB-H016)] OK
    cppunit/1.15.1: [HOOK - hook_conan-center-v2.py] post_package(): [PDB FILES NOT ALLOWED (KB-H017)] OK
    cppunit/1.15.1: [HOOK - hook_conan-center-v2.py] post_package(): [LIBTOOL FILES PRESENCE (KB-H018)] OK
    cppunit/1.15.1: [HOOK - hook_conan-center-v2.py] post_package(): [MS RUNTIME FILES (KB-H021)] OK
    cppunit/1.15.1: [HOOK - hook_conan-center-v2.py] post_package(): [SHORT_PATHS USAGE (KB-H066)] OK
    cppunit/1.15.1: [HOOK - hook_conan-center-v2.py] post_package(): ERROR: [MISSING SYSTEM LIBS (KB-H043)] Exception raised from hook: run() got an unexpected keyword argument 'output' (type=TypeError) (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H043)
    ERROR: [HOOK - hook_conan-center-v2.py] post_package(): run() got an unexpected keyword argument 'output'
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit 31d6b4b into conan-io:master Feb 20, 2023
@SpaceIm SpaceIm deleted the cppunit-modernize-more branch February 20, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants