zstd: add version 1.5.4 #15856

toge · 2023-02-10T05:58:39Z

Specify library name and version: zstd/1.5.4

I've read the contributing guidelines.
I've used a recent Conan client version close to the currently deployed.
I've tried at least one configuration locally with the conan-center hook activated.

github-actions · 2023-02-10T05:59:57Z

🤖 Beep Boop! This pull request is making changes to 'recipes/zstd//'.

👋 @Hopobcn you might be interested. 😉

Hopobcn · 2023-02-10T08:01:23Z

recipes/zstd/all/conanfile.py

+            import re
+            from io import StringIO
+            output = StringIO()
+            self.run("cmake --version", output=output)


Would it make sense for conan.tools.cmake.CMake wrapper to have a "version()" ?

@prince-chrismc

No :) the graph should be more deterministic regardless of the user's tools.

This version check will go away with new rules in the near future...

The team wants the portable binaries from kitware so it works regardless and doesn't need to be built (which are the reasons this is here)

conan-center-bot · 2023-02-10T21:54:42Z

Conan v1 pipeline ✔️

All green in build 3 (ede1ef3dafdafe814d79fe4b9809b419c15b90fd):

zstd/1.5.2@:
All packages built successfully! (All logs)
zstd/1.4.9@:
All packages built successfully! (All logs)
zstd/1.4.4@:
All packages built successfully! (All logs)
zstd/1.5.1@:
All packages built successfully! (All logs)
zstd/1.4.5@:
All packages built successfully! (All logs)
zstd/1.4.3@:
All packages built successfully! (All logs)
zstd/1.5.0@:
All packages built successfully! (All logs)
zstd/1.4.7@:
All packages built successfully! (All logs)
zstd/1.3.8@:
All packages built successfully! (All logs)
zstd/1.3.5@:
All packages built successfully! (All logs)
zstd/1.4.8@:
All packages built successfully! (All logs)
zstd/1.5.4@:
All packages built successfully! (All logs)

Conan v2 pipeline (informative, not required for merge) ❌

Note: Conan v2 builds are informative and they are not required for the PR to be merged.

The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future.

See details:

Failure in build 3 (ede1ef3dafdafe814d79fe4b9809b419c15b90fd):

zstd/1.5.2@:
All packages built successfully! (All logs)
zstd/1.5.1@:
All packages built successfully! (All logs)
zstd/1.3.8@:
All packages built successfully! (All logs)
zstd/1.4.7@:
All packages built successfully! (All logs)
zstd/1.4.9@:
All packages built successfully! (All logs)
zstd/1.4.3@:
All packages built successfully! (All logs)
zstd/1.4.5@:
All packages built successfully! (All logs)
zstd/1.4.8@:
All packages built successfully! (All logs)
zstd/1.5.0@:
Didn't run or was cancelled before finishing
zstd/1.3.5@:
Didn't run or was cancelled before finishing
zstd/1.4.4@:
Didn't run or was cancelled before finishing

zstd/1.5.4@:
CI failed to create some packages (All logs)

Logs for packageID 668e7888fadd10ea273722487025fa96b62e2a52:

[settings]
arch=x86_64
build_type=Release
compiler=gcc
compiler.libcxx=libstdc++11
compiler.version=11
os=Linux
[options]
*/*:shared=False

[...]
cmake/3.25.2: Trying with 'conan-center-v2'...
Downloading conanfile.py
Downloading conanmanifest.txt
Downloading conan_export.tgz
Decompressing conan_export.tgz
cmake/3.25.2: Downloaded recipe revision e43eea9bd5a2364a4914b2161e832488
openssl/1.1.1s: Not found in local cache, looking in remotes...
openssl/1.1.1s: Checking remote: conan-center-v2
openssl/1.1.1s: Trying with 'conan-center-v2'...
Downloading conan_export.tgz
Downloading conanmanifest.txt
Downloading conanfile.py
Decompressing conan_export.tgz
openssl/1.1.1s: Downloaded recipe revision b13395eb9813fcb36aeb957a6716ad77
Graph root
    virtual
Requirements
    zstd/1.5.4#8000dcd4e4cbcbdb8114fb684a6801a9 - Cache
Build requirements
    cmake/3.25.2#e43eea9bd5a2364a4914b2161e832488 - Downloaded (conan-center-v2)
    openssl/1.1.1s#b13395eb9813fcb36aeb957a6716ad77 - Downloaded (conan-center-v2)

-------- Computing necessary packages --------
zstd/1.5.4: Forced build from source
Requirements
    zstd/1.5.4#8000dcd4e4cbcbdb8114fb684a6801a9:668e7888fadd10ea273722487025fa96b62e2a52 - Build
Build requirements
    cmake/3.25.2#e43eea9bd5a2364a4914b2161e832488:0d9766aa04d2f78f851636278486318527679777 - Missing
    openssl/1.1.1s#b13395eb9813fcb36aeb957a6716ad77:980b46eebc57d8a974a25eb4eba020c6b88ad1b9#ef240f5a87820604e5e27ce1d7da45f0 - Skip (conan-center-v2)

-------- Installing packages --------

-------- Installing (downloading, building) binaries... --------
ERROR: Missing binary: cmake/3.25.2:0d9766aa04d2f78f851636278486318527679777

cmake/3.25.2: WARN: Can't find a 'cmake/3.25.2' package binary '0d9766aa04d2f78f851636278486318527679777' for the configuration:
[settings]
arch=x86_64
build_type=Release
os=Linux
[options]
with_openssl=True
[requires]
openssl/1.1.1s#b13395eb9813fcb36aeb957a6716ad77:980b46eebc57d8a974a25eb4eba020c6b88ad1b9

ERROR: Missing prebuilt package for 'cmake/3.25.2'
Use 'conan list packages cmake/3.25.2 --format=html -r=remote > table.html' and open the table.html file to see available packages
Or try to build locally from sources with '--build=cmake/3.25.2'

More Info at 'https://docs.conan.io/en/latest/faq/troubleshooting.html#error-missing-prebuilt-package'

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

SpaceIm · 2023-02-11T16:20:03Z

recipes/zstd/all/conanfile.py

+        # zstd/>=1.5.4 uses `check_linker_flag` which is introduced since cmake 3.1.8.
+        if Version(self.version) >= "1.5.4" and not self._cmake_new_enough("3.18"):
+            self.tool_requires("cmake/3.25.2")


Shouldn't it be reported to zstd repo because it may be unintentional? Their min CMake version is still 2.8.12, so they may not want such very high min CMake version. If they want to revert, we could patch it. It's something I've seen in vulkan-loader for example, maintainers inadvertently used a recent feature in a new release, and reverted this change because they wanted to support default CMake versions of several Linux distro.

I've opened facebook/zstd#3500

@SpaceIm Thanks!

So facebook/zstd#3510 should be backported to 1.5.4 and cmake removed from tool_requires, so that we can keep a clean conanfile.py

zstd: add version 1.5.4

9ba115d

github-actions bot mentioned this pull request Feb 10, 2023

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

fix patch_types

1294cfd

conan-center-bot added the Failed label Feb 10, 2023

This comment has been minimized.

Sign in to view

require cmake/>= 3.18 in zstd/1.5.4

ede1ef3

This was referenced Feb 10, 2023

Updatable recipes qchateau/conan-center-bot#1

Open

[request] Updatable recipes #3470

Closed

Hopobcn reviewed Feb 10, 2023

View reviewed changes

conan-center-bot removed the Failed label Feb 10, 2023

prince-chrismc approved these changes Feb 10, 2023

View reviewed changes

SpaceIm reviewed Feb 11, 2023

View reviewed changes

jwillikers approved these changes Feb 13, 2023

View reviewed changes

conan-center-bot merged commit aca585b into conan-io:master Feb 13, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

zstd: add version 1.5.4 #15856

zstd: add version 1.5.4 #15856

toge commented Feb 10, 2023

github-actions bot commented Feb 10, 2023

This comment has been minimized.

Hopobcn Feb 10, 2023

prince-chrismc Feb 10, 2023

conan-center-bot commented Feb 10, 2023

SpaceIm Feb 11, 2023 •

edited

Loading

SpaceIm Feb 11, 2023

jwillikers Feb 13, 2023

SpaceIm Feb 16, 2023

zstd: add version 1.5.4 #15856

zstd: add version 1.5.4 #15856

Conversation

toge commented Feb 10, 2023

github-actions bot commented Feb 10, 2023

This comment has been minimized.

Hopobcn Feb 10, 2023

Choose a reason for hiding this comment

prince-chrismc Feb 10, 2023

Choose a reason for hiding this comment

conan-center-bot commented Feb 10, 2023

Conan v1 pipeline ✔️

Conan v2 pipeline (informative, not required for merge) ❌

SpaceIm Feb 11, 2023 • edited Loading

Choose a reason for hiding this comment

SpaceIm Feb 11, 2023

Choose a reason for hiding this comment

jwillikers Feb 13, 2023

Choose a reason for hiding this comment

SpaceIm Feb 16, 2023

Choose a reason for hiding this comment

SpaceIm Feb 11, 2023 •

edited

Loading