Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bgfx #16134

Merged
merged 15 commits into from
Aug 16, 2023
Merged

Add bgfx #16134

merged 15 commits into from
Aug 16, 2023

Conversation

RazielXYZ
Copy link
Contributor

Specify library name and version: bgfx/cci.20230216

This is the bgfx library, a powerful cross-platform rendering library that can handle all common rendering backends from a common codebase.

Similarly to bimg (#15317), this requires bx source to build, as well as bimg source. I've mapped versions the same way as in the bimg package.
Other than that, the only main difference between this package and those of bx and bimg is that bgfx does support being built and used as a shared library.

Notes from bx (#13866) and bimg still apply.


Add required system libs
Better shared lib support
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit 67e6176
bgfx/cci.20230216
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libbgfx.dylib' links to system library 'AppKit' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libbgfx.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libbgfx.dylib

… older than 11

Add apparently missing macOS frameworks
@conan-center-bot

This comment has been minimized.

@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit 2f465ee
bgfx/cci.20230216
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libbgfx.dylib

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit 2104acb
bgfx/cci.20230216
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libbgfx-shared-libRelease.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libbgfx-shared-libRelease.so' links to system library 'rt' but it is not in cpp_info.system_libs.

@conan-center-bot

This comment has been minimized.

@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit eb682a1
bgfx/cci.20230216
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libbgfx-shared-libRelease.dylib
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libbgfx-shared-libDebug.dylib

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit 6e34368
bgfx/cci.20230216
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libbgfx-shared-libRelease.dylib
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libbgfx-shared-libDebug.dylib

@stale
Copy link

stale bot commented Apr 25, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 25, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2023

Hooks produced the following warnings for commit eed0585
bgfx/cci.20230216
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libbgfx.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libbgfx.so' links to system library 'rt' but it is not in cpp_info.system_libs.

@conan-center-bot conan-center-bot requested review from jcar87 and danimtb May 5, 2023 11:59
@CLAassistant
Copy link

CLAassistant commented May 18, 2023

CLA assistant check
All committers have signed the CLA.

@RazielXYZ
Copy link
Contributor Author

Any chance we can take a look at this?

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@franramirez688
Copy link
Contributor

This PR is failing for Conan v2 because of some missing binaries. This PR is needed #19026 to build one of them, so let's wait for it and update the branch after that to see if it's already solved.

@uilianries uilianries mentioned this pull request Aug 3, 2023
3 tasks
@conan-center-bot

This comment has been minimized.

@RazielXYZ
Copy link
Contributor Author

I thought the v2 pipeline succeeding wasn't required (yet)? Either way, I agree that we should make everything compatible with v2 regardless. I also plan on touching up the bx, bimg and bgfx recipes again after they're all here in this initial form.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 6 (8bbacdb537c09d6f5ae4776334f2f7ddbda90517):

  • bgfx/cci.20230216@:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds may be required once they are on the v2 ready list

All green in build 9 (8bbacdb537c09d6f5ae4776334f2f7ddbda90517):

  • bgfx/cci.20230216@:
    All packages built successfully! (All logs)

@danimtb danimtb self-assigned this Aug 16, 2023
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice trick with getting the dependencies sources!

@conan-center-bot conan-center-bot merged commit da7183d into conan-io:master Aug 16, 2023
@RazielXYZ RazielXYZ deleted the bgfx branch August 16, 2023 17:23
ericLemanissier pushed a commit to ericLemanissier/conan-center-index that referenced this pull request Sep 15, 2023
* Add bgfx with locally tested files

* Fix projs list
Add required system libs
Better shared lib support

* Add opengl/system requirement

* Minimum apple-clang to 12 for now to keep CCI from compiling on macOS older than 11
Add apparently missing macOS frameworks

* Apparently apple dylibs break if renamed

* Fix oops of using settings instead of options

* Fix conditional logic

* Why is macos so difficult?

* Fix test for Conan 2.x

* Maybe this helps on macos

* Make suggested changes

* Update recipes/bgfx/all/test_package/conanfile.py

Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>

* Fix shared some more

---------

Co-authored-by: Raziel Alphadios <raziely@gmail.com>
Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>
Co-authored-by: Francisco Ramírez <franchuti688@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants