-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bgfx #16134
Add bgfx #16134
Conversation
Add required system libs Better shared lib support
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 67e6176bgfx/cci.20230216
|
… older than 11 Add apparently missing macOS frameworks
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 2f465eebgfx/cci.20230216
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 2104acbbgfx/cci.20230216
|
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit eb682a1bgfx/cci.20230216
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 6e34368bgfx/cci.20230216
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Hooks produced the following warnings for commit eed0585bgfx/cci.20230216
|
Any chance we can take a look at this? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This PR is failing for Conan v2 because of some missing binaries. This PR is needed #19026 to build one of them, so let's wait for it and update the branch after that to see if it's already solved. |
This comment has been minimized.
This comment has been minimized.
I thought the v2 pipeline succeeding wasn't required (yet)? Either way, I agree that we should make everything compatible with v2 regardless. I also plan on touching up the bx, bimg and bgfx recipes again after they're all here in this initial form. |
Conan v1 pipeline ✔️All green in build 6 (
Conan v2 pipeline ✔️
All green in build 9 (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice trick with getting the dependencies sources!
* Add bgfx with locally tested files * Fix projs list Add required system libs Better shared lib support * Add opengl/system requirement * Minimum apple-clang to 12 for now to keep CCI from compiling on macOS older than 11 Add apparently missing macOS frameworks * Apparently apple dylibs break if renamed * Fix oops of using settings instead of options * Fix conditional logic * Why is macos so difficult? * Fix test for Conan 2.x * Maybe this helps on macos * Make suggested changes * Update recipes/bgfx/all/test_package/conanfile.py Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com> * Fix shared some more --------- Co-authored-by: Raziel Alphadios <raziely@gmail.com> Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com> Co-authored-by: Francisco Ramírez <franchuti688@gmail.com>
Specify library name and version: bgfx/cci.20230216
This is the bgfx library, a powerful cross-platform rendering library that can handle all common rendering backends from a common codebase.
Similarly to bimg (#15317), this requires bx source to build, as well as bimg source. I've mapped versions the same way as in the bimg package.
Other than that, the only main difference between this package and those of bx and bimg is that bgfx does support being built and used as a shared library.
Notes from bx (#13866) and bimg still apply.