opentelemetry: export with_examples parameter #16220
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
ghost
mentioned this pull request
|
I detected other pull requests that are modifying opentelemetry-cpp/all recipe:
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This comment has been minimized.
This comment has been minimized.
jcar87
reviewed
Mar 2, 2023
| @@ -61,6 +62,7 @@ class OpenTelemetryCppConan(ConanFile): | |||
| "with_logs_preview": False, | |||
| "with_async_export_preview": False, | |||
| "with_metrics_exemplar_preview": False, | |||
| "with_examples": True, | |||
There was a problem hiding this comment.
hi @jiaoew1991 - thanks for opening this PR.
We typically exclude building examples, most recipes where the underlying build scripts build examples by default would have them explicitly disabled. The rationale is that they are not part of the public API of the library and thus not necessary for consumers, and the Conan test package serves as a minimal example to cover this - Is it not the case with opentelemetry-cpp?
Trying to understand the use
There was a problem hiding this comment.
I want to disable the examples too, but in the original recipe the example was not disabled and the cmake of opentelemetry-cpp build the examples by default. I do not want to break the compatibility so keep building the example 😅
|
Hi @jcar87 , it seems the CI env still not ready 😭 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Hi all, I opened a Github #16296 recently related to an issue I discovered that was introduced to the package recipe recently. Namely, a change was made that to the recipe that caused Conan to build the example files in the OpenTelemetry repo. Unfortunately, there is a mistake in one of their example files that prevents it from building in C++ 20. It seems like this PR would at least expose the ability to turn off the building of examples. However, it might be best to just set What will it take to get this PR over the line? (I'm unfamiliar with contributing to this repo) Thank you! |
jiaoew1991
force-pushed
the
opentelemetry-examples
branch
from
5a99496
to
3716dfc
Compare
This comment has been minimized.
This comment has been minimized.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>
jiaoew1991
force-pushed
the
opentelemetry-examples
branch
from
3716dfc
to
6536e4a
Compare
This comment has been minimized.
This comment has been minimized.
|
|
Conan v1 pipeline ❌Failure in build 7 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. Conan v2 pipeline ❌
The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future. See details:Failure in build 7 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
This was referenced Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: opentelemetry/all