-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boost: add official patches #16930
boost: add official patches #16930
Conversation
🤖 Beep Boop! This pull request is making changes to 'recipes/boost//'. 👋 @grafikrobot @Hopobcn @jwillikers you might be interested. 😉 |
I detected other pull requests that are modifying boost/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This comment has been minimized.
This comment has been minimized.
This is a very old problem 😄 Since these issues are already fixed in newer versions of boost we have not accept them. Given one of the patches is so massive it too big, you will need to delete that for the build to at least pass. As for the two for 80, they are for portability and more inline without patching rules so I'd be include to accept those since they are very small. |
5803544
to
072243e
Compare
@grafikrobot can you comment on this one? |
Hello, thanks for the quick feedback.
I was working on that because I went over the open issues. If you don't intend to accept it, could you please close #2163?
I removed the patches for 1.73 and only kept the ones for 1.80. Thanks, |
I can't check all the patches that are in this. But my general opinion is that we prefer to not have patches applied. Un-integrated patches means they are not tested on the release form. Hence I would be against accepting this PR. Having said that.. I would be okay if users could opt-in to getting patches. Having different, additional, patched versions is one way. A likely better way though is to add a package option to create a patched version. Adding the option has the benefit that it doesn't create extra CCI binaries as users would be required to do their own source builds. NOTE: The only published Boost patches are here: https://www.boost.org/patches/ |
Done! |
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 072243eboost/1.80.0
|
Conan v1 pipeline ✔️All green in build 3 (
Conan v2 pipeline (informative, not required for merge) ✔️
All green in build 3 (
|
Hooks produced the following warnings for commit d705b1dboost/1.80.0
|
Add missing upstream patches for Boost 1.73 - 1.80.
Fixes: #2163