qt 5.x: several fixes for conan v2 #17030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- inject VirtualRunEnv in build scope since path to shared libs of requirements is required when executables built during qt build process are executed. - also remove some build requirements, they are requirements actually, but their shared libs must be visible as describe in previous point. - don't rely on is_msvc in package_id, it's forbidden in conan v2
|
🤖 Beep Boop! This pull request is making changes to 'recipes/qt//'. 👋 @ericLemanissier @jwillikers @MartinDelille you might be interested. 😉 |
ghost
mentioned this pull request
|
I detected other pull requests that are modifying qt/5.x.x recipe:
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This was referenced Apr 14, 2023
jwillikers
previously approved these changes
Apr 14, 2023
|
Converted to draft, v2 pipeline still fails, but I can't see the log yet. |
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 745523cqt/5.15.8qt/5.15.7qt/5.15.6qt/5.15.5qt/5.15.9 |
This comment has been minimized.
This comment has been minimized.
|
test_package folder still relies on legacy generators, so it can't work in v2 pipeline. |
This comment has been minimized.
This comment has been minimized.
I've opened #17035 |
It's not sufficient on macOS when dependencies are shared (SIP my love...), and the workaround with |
|
Is there a c3i maintenance? |
MartinDelille
previously approved these changes
Apr 18, 2023
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jwillikers
previously approved these changes
May 7, 2023
jwillikers
approved these changes
May 11, 2023
jwillikers
approved these changes
May 11, 2023
jwillikers
approved these changes
May 11, 2023
jwillikers
approved these changes
May 11, 2023
jwillikers
approved these changes
May 11, 2023
Conan v1 pipeline ✔️All green in build 11 (
Conan v2 pipeline ❌
The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future. See details:Failure in build 10 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
Hooks produced the following warnings for commit 706b4e8qt/5.15.8qt/5.15.7qt/5.15.6qt/5.15.5qt/5.15.9 |
MartinDelille
approved these changes
May 12, 2023
prince-chrismc
approved these changes
May 12, 2023
With Visual Studio only, and I can't reproduce this issue locally. |
|
According to Google it's a "path too long" issue |
pezy
pushed a commit
to pezy/conan-center-index
that referenced
this pull request
Jun 1, 2023
* fix for conan v2 - inject VirtualRunEnv in build scope since path to shared libs of requirements is required when executables built during qt build process are executed. - also remove some build requirements, they are requirements actually, but their shared libs must be visible as describe in previous point. - don't rely on is_msvc in package_id, it's forbidden in conan v2 * move package_id() (sort by order of execution) * add test package for new generators * lowercase system libs for Windows * fix build on macOS when dependencies are shared * bump dependencies and prefer openal-soft over deprecated openal recipe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VirtualRunEnvinbuildscope (in case of native build) since path to shared libs of several requirements must be visible when executables built during qt build process are executed (because these executables link to some requirements).DYLD_LIBRARY_PATHworkaround on macOS, it was broken (it's the same usage than previous point, but as usual SIP defeats everything, leading to this workaround).is_msvc()inpackage_id()method, it's forbidden in conan v2.uxthemeinstead ofUxTheme)openal-softin requirements over deprecatedopenalrecipe