Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add qhull/7.3.2 #1728

Merged
merged 1 commit into from
May 27, 2020
Merged

add qhull/7.3.2 #1728

merged 1 commit into from
May 27, 2020

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented May 25, 2020

Specify library name and version: qhull/7.3.2

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

closes #1725

@conan-center-bot
Copy link
Collaborator

Some configurations of 'qhull/7.3.2' failed in build 1 (e09eda0822a401d4629538ce149b5e683013971a):

  • Linux x86_64, Release, gcc 5, libstdc++ . Options: qhull:shared-True
    • Hooks errors detected:
      • [HOOK - conan-center.py] post_package(): ERROR: [DEFAULT PACKAGE LAYOUT (KB-H013)] Unknown folder 'share' in the package (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H013)
    • Log download
    • Log error Download
    • Profile
  • Access to all the logs

@conan-center-bot
Copy link
Collaborator

All green in build 2 (ad07344b64327e0b9850fb41980630ec3b637d30)! 😊

@SpaceIm
Copy link
Contributor Author

SpaceIm commented May 25, 2020

I've patched CMakeLists to only install non reentrant version of qhull. It's the one used by gdal AFAIK.

Basically, qhull has:

  • a non reentrant version (C API)
  • a reentrant version (another lib and another similar C API than non-reentrant version)
  • a C++ version, incomplete, always static, which always needs the static reentrant version

It was easier to just remove reentrant and C++ libs, because consumers can't have both reentrant and non-reentrant version linked (duplicated symbols), and reentrant lib is really another lib: different namespaced header files.

@SSE4 SSE4 requested review from danimtb and uilianries May 26, 2020 08:08
@uilianries uilianries requested a review from jgsogo May 26, 2020 14:06
@jgsogo jgsogo merged commit 1ef94c0 into conan-io:master May 27, 2020
@SpaceIm SpaceIm deleted the qhull/7.3.2 branch May 27, 2020 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[request] qhull/7.3.2
5 participants