Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avahi/0.8: Disable the use of the setproctitle function on Linux #17355

Merged

Conversation

jwillikers
Copy link
Contributor

@jwillikers jwillikers commented May 1, 2023

This function is not declared on Linux.
Configure ignores warnings about the missing declaration. This causes issues when building with recent versions of Clang. Support for implicit declarations was removed in newer C standards in Clang. Telling configure that the setproctitle function is not available disables the use of this function in Avahi.

Fixes #17354.

Specify library name and version: avahi/0.8

Note that setproctitle is correctly disabled on Linux in Avahi's master branch, so no upstream patches are necessary. I tested this in commit 6395c45 of Avahi locally.
Using both GCC and Clang, results in ac_cv_func_setproctitle=no in config.log without any manual intervention.


This function is not declared on Linux.
Configure ignores warnings about the missing declaration.
This causes issues when building with recent versions of Clang.
Support for implicit declarations was removed in newer C standards in Clang.
Telling configure that the setproctitle function is not available disables the use of this function in Avahi.
@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2023

🤖 Beep Boop! This pull request is making changes to 'recipes/avahi//'.

👋 @jwillikers you might be interested. 😉

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

jwillikers added a commit to jwillikers/conan-center-index that referenced this pull request May 2, 2023
jwillikers added a commit to jwillikers/conan-center-index that referenced this pull request May 2, 2023
jwillikers added a commit to jwillikers/conan-center-index that referenced this pull request May 2, 2023
Required for PR conan-io#17355.

Also, add version 1.23.
@jwillikers jwillikers mentioned this pull request May 2, 2023
3 tasks
conan-center-bot pushed a commit that referenced this pull request May 11, 2023
* gdbm: Support Conan V2

Required for PR #17355.

Also, add version 1.23.

* Fixes

* Make sure that YYDEBUG is defined when gdbmtool_debug is enabled

* Fix v1 package

* Try changing the name of the top-level CMake project

---------

Co-authored-by: Rubén Rincón Blanco <rubenrb@jfrog.com>
@jwillikers jwillikers closed this May 11, 2023
@jwillikers jwillikers reopened this May 11, 2023
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 4 (424ae1ec24229a7e7abcda755198106a1167aec1):

  • avahi/0.8@:
    All packages built successfully! (All logs)

Conan v2 pipeline ❌

Note: Conan v2 builds may be required once they are on the v2 ready list

The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future.

See details:

Failure in build 3 (424ae1ec24229a7e7abcda755198106a1167aec1):

  • avahi/0.8@:
    CI failed to create some packages (All logs)

    Logs for packageID 1da117ea2faaf5c067eb20bafc030f3b285e8e0d:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.cppstd=17
    compiler.libcxx=libstdc++11
    compiler.version=11
    os=Linux
    [options]
    */*:shared=False
    
    [...]
        glib/2.75.2#f557edc40ee93adbbd933126a19f5ea0:237027f68dbdf9bc451dd138d5baf1733f26cb21#77badd538918d997856142b6b84e5a5d - Download (conan-center)
        libdaemon/0.14#0eb527aaa9c1c48668779756cf47be6c:b647c43bfefae3f830561ca202b6cfd935b56205 - Missing
        libelf/0.8.13#4f70a3555809ae50cc8add44f0f84288:b647c43bfefae3f830561ca202b6cfd935b56205#320ff43905aa624744ff7d433a228f1f - Download (conan-center)
        libevent/2.1.12#b6333a128075d75a3614bd8418bf2099:af2de5bd29922997cf19508c118422d4798d7f0d#3b6ef9f4d719ec9b7ebf29693fa7121a - Download (conan-center)
        libffi/3.4.4#35eb63842b505824b70aedc1baefc916:b647c43bfefae3f830561ca202b6cfd935b56205#7b5469e918452bad6747b9fd478b37a7 - Download (conan-center)
        libmount/2.36.2#a5c932e8f220bde1f375be0db7ed5800:b647c43bfefae3f830561ca202b6cfd935b56205#e70e59ad4f25724ae3255a1854d55a0e - Download (conan-center)
        libselinux/3.3#1bb9670b14ef607941dd43bf155ce7e3:efc2988dafc5280ea79762e0f609c41b520649f5#4b85801e3ac66ecf3ef16ecbfec9975f - Download (conan-center)
        openssl/3.1.0#25925a18588e030e406a15da96c4d32b:b23402676a8897e538b5392074e693be3e0d8262#5bcf75cfcca1289d10f98000906f1d88 - Download (conan-center)
        pcre2/10.42#2079a0447f9652dffcbbf1eb73ae2d4e:dec24e389821756f046850665ac2dc2e4fb7634e#64f895bdde4679765feed0e494deb7f7 - Download (conan-center)
        zlib/1.2.13#e377bee636333ae348d51ca90874e353:b647c43bfefae3f830561ca202b6cfd935b56205#c68df5ae1b6d523306693ef4295b670f - Download (conan-center)
    Build requirements
        autoconf/2.71#f4e2bd681d49b4b80761aa587bde94d5:da39a3ee5e6b4b0d3255bfef95601890afd80709#5c53a519d70fdb79d3cd4145e9f0355f - Skip
        bison/3.8.2#a8e86b304f8085ddbb22395c99a9a0a8:500c2a3f502e0ca7d4a4c65cb2a4a0b0a24994f5#6e426a4fff8e364779169ab986a1daa3 - Skip
        bzip2/1.0.8#411fc05e80d47a89045edc1ee6f23c1d:763ddd53d7a4775fe84a285f56005a096d9786fd#3c39f4d84b7d234e9632c57059cc49f5 - Skip
        flex/2.6.4#e35bc44b3fcbcd661e0af0dc5b5b1ad4:b647c43bfefae3f830561ca202b6cfd935b56205#d18545ed84d684e0090595f1eb0d23c5 - Skip
        glib/2.75.2#f557edc40ee93adbbd933126a19f5ea0:7faac6d5fef76ccc2f04b6c6e0474773b95352a4 - Missing
        gnu-config/cci.20210814#15c3bf7dfdb743977b84d0321534ad90:da39a3ee5e6b4b0d3255bfef95601890afd80709#22618e30bd9e326eb95e824dc90cc860 - Skip
        libelf/0.8.13#4f70a3555809ae50cc8add44f0f84288:b647c43bfefae3f830561ca202b6cfd935b56205#320ff43905aa624744ff7d433a228f1f - Skip
        libffi/3.4.4#35eb63842b505824b70aedc1baefc916:b647c43bfefae3f830561ca202b6cfd935b56205#7b5469e918452bad6747b9fd478b37a7 - Skip
        libmount/2.36.2#a5c932e8f220bde1f375be0db7ed5800:b647c43bfefae3f830561ca202b6cfd935b56205#e70e59ad4f25724ae3255a1854d55a0e - Skip
        libselinux/3.3#1bb9670b14ef607941dd43bf155ce7e3:efc2988dafc5280ea79762e0f609c41b520649f5#4b85801e3ac66ecf3ef16ecbfec9975f - Skip
        m4/1.4.19#c1c4b1ee919e34630bb9b50046253d3c:3593751651824fb813502c69c971267624ced41a#c69dc2230d016a77b5514d9916b14714 - Skip
        meson/1.0.0#15586c0ac6f682805875ef903dbe7ee2:da39a3ee5e6b4b0d3255bfef95601890afd80709#5c8fd51fc33f12e26519674d99afd0e5 - Skip
        meson/1.1.0#6176e4f21370f5820c27da02836c32c9:da39a3ee5e6b4b0d3255bfef95601890afd80709#b61703d57cd9717c5c171ccde71d4c1c - Skip
        ninja/1.11.1#63bca91350508f335754f5f9e17ec989:3593751651824fb813502c69c971267624ced41a#a53f170b60a46aef75ead8658bdeae05 - Skip
        pcre2/10.42#2079a0447f9652dffcbbf1eb73ae2d4e:dec24e389821756f046850665ac2dc2e4fb7634e#64f895bdde4679765feed0e494deb7f7 - Skip
        pkgconf/1.9.3#a920b5c7f8d04f22b9fe03db91a864dd:c0b621fd4b3199fe05075171573398833dba85f4#a231c33e360d8be4e90467b36b88f027 - Download (conan-center)
        zlib/1.2.13#e377bee636333ae348d51ca90874e353:b647c43bfefae3f830561ca202b6cfd935b56205#c68df5ae1b6d523306693ef4295b670f - Skip
    
    ======== Installing packages ========
    ERROR: Missing binary: dbus/1.15.2:de23ce391f90b9d2112c64f1b261bdec296ec2dd
    ERROR: Missing binary: glib/2.75.2:7faac6d5fef76ccc2f04b6c6e0474773b95352a4
    ERROR: Missing binary: libdaemon/0.14:b647c43bfefae3f830561ca202b6cfd935b56205
    
    libdaemon/0.14: WARN: Can't find a 'libdaemon/0.14' package binary 'b647c43bfefae3f830561ca202b6cfd935b56205' for the configuration:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.version=11
    os=Linux
    [options]
    fPIC=True
    shared=False
    
    ERROR: Missing prebuilt package for 'dbus/1.15.2', 'glib/2.75.2', 'libdaemon/0.14'
    Check the available packages using 'conan list libdaemon/0.14:* -r=remote'
    or try to build locally from sources using the '--build=dbus/1.15.2 --build=glib/2.75.2 --build=libdaemon/0.14' argument
    
    More Info at 'https://docs.conan.io/2/knowledge/faq.html#error-missing-prebuilt-package'
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@CLAassistant
Copy link

CLAassistant commented May 18, 2023

CLA assistant check
All committers have signed the CLA.

pezy pushed a commit to pezy/conan-center-index that referenced this pull request Jun 1, 2023
* gdbm: Support Conan V2

Required for PR conan-io#17355.

Also, add version 1.23.

* Fixes

* Make sure that YYDEBUG is defined when gdbmtool_debug is enabled

* Fix v1 package

* Try changing the name of the top-level CMake project

---------

Co-authored-by: Rubén Rincón Blanco <rubenrb@jfrog.com>
@conan-center-bot conan-center-bot merged commit 7668745 into conan-io:master Jun 3, 2023
@jwillikers jwillikers deleted the avahi-no-setproctitle-on-linux branch June 4, 2023 14:45
datalogics-kam added a commit to datalogics-kam/conan-center-index that referenced this pull request Jun 5, 2023
…cmake-combined-recipe

- Resolved conflicts.

- Updated recipes/cmake/combined/conandata.yml to use CMake 3.26.4
  instead of 3.26.3

* 'master' of github.com:conan-io/conan-center-index: (219 commits)
  (conan-io#17379) zpp_bits: add version 4.4.17, add package_type
  (conan-io#17811) mongo-c-driver: add version 1.23.4
  (conan-io#17824) [bot] Update list of references (prod-v2/ListPackages)
  (conan-io#17827) [bot] Update authorized users list (2023-06-05)
  (conan-io#17791) c4core: update fast_float
  (conan-io#17447) llhttp: conan v2 support
  (conan-io#17821) daw_utf_range: update daw_header_libraries
  (conan-io#17819) add mbits-diags/0.9.5
  (conan-io#17471) Add Boost 1.82.0
  (conan-io#17816) uni-algo: add version 0.8.1
  (conan-io#17815) flatbuffers: add version 23.5.26
  (conan-io#17801) Bring tl-function to conan2
  (conan-io#17802) Bring ring-span-lite to conan2
  (conan-io#16572) ragel: support conan v2
  (conan-io#17244) Z3: Revise the recipe to support Conan v2 and add the latest four minor releases.
  (conan-io#17355) avahi/0.8: Disable the use of the setproctitle function on Linux
  (conan-io#17744) Bumped CMake to 3.26.4
  (conan-io#17763) Libwebsockets support for conan2
  (conan-io#17808) octo-logger-cpp: add version 1.4.0
  (conan-io#17428) Add libmemcached library
  ...
pezy pushed a commit to pezy/conan-center-index that referenced this pull request Jul 15, 2023
…ion on Linux

* avahi/0.8: Disable the use of the setproctitle function on Linux

This function is not declared on Linux.
Configure ignores warnings about the missing declaration.
This causes issues when building with recent versions of Clang.
Support for implicit declarations was removed in newer C standards in Clang.
Telling configure that the setproctitle function is not available disables the use of this function in Avahi.

* Capitalize Linux
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[package] avahi/0.8: Fails to build with Clang 16 on Linux
5 participants