-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OPENCV] Fix double del when setting dnn option to False #17367
Conversation
This comment has been minimized.
This comment has been minimized.
I detected other pull requests that are modifying opencv/4.x recipe:
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Thanks a lot for your contribution. Please remember to request access here for the PR to be mergeable :) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit a3dd650opencv/4.5.5
opencv/4.5.3
opencv/4.1.2
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
If opnecv is built with both dnn and with_cuda False, the build fails, because the conanfile.py execute del self.options.dnn_cuda twice. This fixes the issue.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ❌Sorry, the system is under maintenance and it doesn't accept builds right now. Conan v2 pipeline ❌
The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future. See details:Sorry, the system is under maintenance and it doesn't accept builds right now. |
I am going to close this as solved as https://github.com/conan-io/conan-center-index/blame/master/recipes/opencv/4.x/conanfile.py#L995 has correct the issue |
If opnecv is built with both dnn and with_cuda False, the build fails, because the conanfile.py execute del self.options.dnn_cuda twice.
This fixes the issue.
Specify library name and version: opencv/4.5.5