-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
itk: migrate to Conan v2 #18298
itk: migrate to Conan v2 #18298
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I'm trying to reproduce problems locally and on Windows with conan 2.0.7 hdf5 doesn't have any include directories. I can't understand what is wrong. I've already tried using different target names with no success.
With itk test_package include dirs are empty. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
dcmtk isn't conan v2 ready |
@uilianries @SpaceIm @jgsogo Could someone please review? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 7 (
Conan v2 pipeline ✔️
All green in build 5 ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Nekto89 Thank you for updating this recipe, it's not a regular project and demanded a lot of effort!
* itk: migrate to Conan v2 * Delete CMakeLists.txt * Remove hdf5 from test * bump libtiff to 4.5.1 * Add empty EOL to test_package.cpp * Replace CRLF with LF in test_package.cpp * itksys: link with dl
Specify library name and version: itk/all
Use CMakeToolchain and update dependencies.
dcmtk had to be turned off because of OpenSSL conflict - Windows version uses openssl 1.0.2 for some reason and gdcm can use 1.1.1 or 3+.