Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

itk: migrate to Conan v2 #18298

Merged
merged 7 commits into from
Aug 22, 2023
Merged

Conversation

Nekto89
Copy link
Contributor

@Nekto89 Nekto89 commented Jul 3, 2023

Specify library name and version: itk/all

Use CMakeToolchain and update dependencies.
dcmtk had to be turned off because of OpenSSL conflict - Windows version uses openssl 1.0.2 for some reason and gdcm can use 1.1.1 or 3+.


@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@Nekto89
Copy link
Contributor Author

Nekto89 commented Jul 3, 2023

I'm trying to reproduce problems locally and on Windows with conan 2.0.7 hdf5 doesn't have any include directories. I can't understand what is wrong. I've already tried using different target names with no success.
I've tried building hdf5 and there I don't have any problems -
recipes\hdf5\all>conan create --version 1.14.1 --build=missing -s compiler.cppstd=17 .
hdf5\all\test_package\build\msvc-193-x86_64-17-release\generators\HDF5-release-x86_64-data.cmake

set(hdf5_INCLUDE_DIRS_RELEASE "${hdf5_PACKAGE_FOLDER_RELEASE}/include"
			"${hdf5_PACKAGE_FOLDER_RELEASE}/include/hdf5")

With itk test_package include dirs are empty.
conan create --version 5.1.0 --build=missing -s compiler.cppstd=17 .
itk\all\test_package\build\msvc-193-x86_64-17-release\generators\HDF5-release-x86_64-data.cmake
set(hdf5_INCLUDE_DIRS_RELEASE )

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@Nekto89
Copy link
Contributor Author

Nekto89 commented Jul 7, 2023

dcmtk isn't conan v2 ready

@Nekto89
Copy link
Contributor Author

Nekto89 commented Jul 11, 2023

@uilianries @SpaceIm @jgsogo Could someone please review?

recipes/itk/all/conanfile.py Show resolved Hide resolved
@conan-center-bot

This comment has been minimized.

@uilianries uilianries self-assigned this Jul 21, 2023
@conan-center-bot

This comment has been minimized.

1 similar comment
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 7 (186919c94e5e94fa277bd944a9eb1d1606e40734):

  • itk/5.1.0@:
    All packages built successfully! (All logs)

  • itk/5.1.2@:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds may be required once they are on the v2 ready list

All green in build 5 (186919c94e5e94fa277bd944a9eb1d1606e40734):

  • itk/5.1.2@:
    All packages built successfully! (All logs)

  • itk/5.1.0@:
    All packages built successfully! (All logs)

@Nekto89 Nekto89 requested a review from uilianries August 21, 2023 14:37
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nekto89 Thank you for updating this recipe, it's not a regular project and demanded a lot of effort!

@conan-center-bot conan-center-bot merged commit a065baf into conan-io:master Aug 22, 2023
ericLemanissier pushed a commit to ericLemanissier/conan-center-index that referenced this pull request Sep 15, 2023
* itk: migrate to Conan v2

* Delete CMakeLists.txt

* Remove hdf5 from test

* bump libtiff to 4.5.1

* Add empty EOL to test_package.cpp

* Replace CRLF with LF in test_package.cpp

* itksys: link with dl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants