-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openmvg: add with_jpeg option #18400
openmvg: add with_jpeg option #18400
Conversation
I detected other pull requests that are modifying openmvg/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
Could the default be switched to libjpeg-turbo as well, perhaps? |
@valgur I don't think so. Other recipes have |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
v2 pipeline is waiting for #17436 |
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Martin Valgur <martin.valgur@gmail.com>
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 5 (
Conan v2 pipeline ✔️
All green in build 5 (
|
Thanks @maksim-petukhov - I've amended the description of this PR to ensure the changes are motivated and explained, and closed the other PR as the changes are now in this one. Thanks for caring! :) |
* add jpeg option * fix * review * Update recipes/openmvg/all/conanfile.py Co-authored-by: Martin Valgur <martin.valgur@gmail.com> * add workaround for build rpath issue on Linux --------- Co-authored-by: Martin Valgur <martin.valgur@gmail.com> Co-authored-by: Luis Caro Campos <3535649+jcar87@users.noreply.github.com>
Specify library name and version: openmvg/*
CMAKE_BUILD_RPATH
to point to the list of all library directories from all dependencies, as a workaround for [bug] conan 2.x: linking against a shared lib with private shared dependencies fails on Linux (again) conan#13560