Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openmvg: add with_jpeg option #18400

Merged
merged 8 commits into from
Aug 16, 2023

Conversation

maksim-petukhov
Copy link
Contributor

@maksim-petukhov maksim-petukhov commented Jul 7, 2023

Specify library name and version: openmvg/*


@ghost
Copy link

ghost commented Jul 7, 2023

I detected other pull requests that are modifying openmvg/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@valgur
Copy link
Contributor

valgur commented Jul 7, 2023

Could the default be switched to libjpeg-turbo as well, perhaps?

@maksim-petukhov
Copy link
Contributor Author

@valgur I don't think so. Other recipes have libjpeg as a default, so we shouldn't use libjpeg-turbo as a default there because it might result in a conflict.

@conan-center-bot

This comment has been minimized.

@maksim-petukhov maksim-petukhov changed the title openmvg: add jpeg option openmvg: add with_jpeg option Jul 7, 2023
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@ghost ghost mentioned this pull request Jul 12, 2023
3 tasks
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@maksim-petukhov
Copy link
Contributor Author

v2 pipeline is waiting for #17436

@conan-center-bot

This comment has been minimized.

1 similar comment
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

Co-authored-by: Martin Valgur <martin.valgur@gmail.com>
@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 5 (b041cb2e0062210eae7991f7283d527624ec7394):

  • openmvg/2.0@:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds may be required once they are on the v2 ready list

All green in build 5 (b041cb2e0062210eae7991f7283d527624ec7394):

  • openmvg/2.0@:
    All packages built successfully! (All logs)

@maksim-petukhov
Copy link
Contributor Author

@jcar87 There is a #17436 PR from @SpaceIm and I think your changes make it unnecessary. Should I mention #17436 in initial PR message?

@conan-center-bot conan-center-bot merged commit d29f906 into conan-io:master Aug 16, 2023
@jcar87
Copy link
Contributor

jcar87 commented Aug 16, 2023

Thanks @maksim-petukhov - I've amended the description of this PR to ensure the changes are motivated and explained, and closed the other PR as the changes are now in this one. Thanks for caring! :)

ericLemanissier pushed a commit to ericLemanissier/conan-center-index that referenced this pull request Sep 15, 2023
* add jpeg option

* fix

* review

* Update recipes/openmvg/all/conanfile.py

Co-authored-by: Martin Valgur <martin.valgur@gmail.com>

* add workaround for build rpath issue on Linux

---------

Co-authored-by: Martin Valgur <martin.valgur@gmail.com>
Co-authored-by: Luis Caro Campos <3535649+jcar87@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants