Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add freexl/1.0.5 #1846

Merged
merged 2 commits into from
Jun 10, 2020
Merged

add freexl/1.0.5 #1846

merged 2 commits into from
Jun 10, 2020

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Jun 5, 2020

Specify library name and version: freexl/1.0.5

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@SpaceIm SpaceIm mentioned this pull request Jun 5, 2020
Closed
@conan-center-bot
Copy link
Collaborator

All green in build 1 (689cf135d7b6c6c0aeb555f56b385f27b91fbaef)! 😊

@SpaceIm @uilianries @madebr
freexl: remove pkg_config name and fPIC if shared
e670b8c 
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>
@SpaceIm SpaceIm requested a review from uilianries June 9, 2020 18:16
@conan-center-bot
Copy link
Collaborator

All green in build 2 (e670b8cac176faa42b299e81d8933e76e6519b2a)! 😊

uilianries
uilianries approved these changes Jun 9, 2020
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@uilianries uilianries requested review from danimtb, jgsogo and SSE4 June 9, 2020 19:07
@SSE4 SSE4 merged commit a3118c5 into conan-io:master Jun 10, 2020
@SpaceIm SpaceIm deleted the freexl/1.0.5 branch June 10, 2020 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madebr madebr madebr left review comments

@uilianries uilianries uilianries approved these changes

@jgsogo jgsogo jgsogo approved these changes

@SSE4 SSE4 SSE4 approved these changes

@danimtb danimtb Awaiting requested review from danimtb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@SpaceIm @conan-center-bot @SSE4 @jgsogo @madebr @uilianries