uvwasi: add recipe #18522

toge · 2023-07-13T07:29:53Z

Specify library name and version: uvwasi/*

uvwasi is required by wasm-micro-runtime with libc=uvwasi.

I've read the contributing guidelines.
I've used a recent Conan client version close to the currently deployed.
I've tried at least one configuration locally with the conan-center hook activated.

AbrilRBS

Looks good! The patch seems to be a subset of the changes in the linked URL, but I think that's ok :)

Other than that, I like this simple recipe, congrats!

pending team discussion

jcar87 · 2023-07-14T15:13:42Z

recipes/uvwasi/all/patches/0.0.18-0001-fix-cmake.patch

+ set(CMAKE_RUNTIME_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/out)
+
+-if(CMAKE_C_COMPILER_ID MATCHES "AppleClang|Clang|GNU")
+if(0)


@toge, thanks for your contribution.

What is the motivation behind this change? The patch mentions nodejs/uvwasi#210 but I cannot see this change there.

Sorry for the wrong information.
uswasi#210 only adds the installer.

I split the patch file in two.

jcar87 · 2023-07-14T15:15:33Z

recipes/uvwasi/all/patches/0.0.18-0001-fix-cmake.patch

+ endif()
+
+-if(APPLE)
+if(0)


This is probably unnecessary - CMAKE_MACOSX_RPATH is ON by default if the cmake minimum required is recent enough, and ON is the value we want - I suspect that even without this change, the dylib would have an install name that starts with @rpath

@jcar87
Thank you for your review!
I disable this patch.

jcar87 · 2023-07-17T15:43:49Z

Thanks @toge ! It's still not clear why disabling visibility=hidden is needed?

toge · 2023-07-17T16:29:54Z

@jcar87
Sorry, I overlooked this.
When compiled with visibility=hidden, there is no uvwasi symbol in the shared library.
I think the only solution is to remove visibility=hidden.

jcar87 · 2023-07-17T16:54:59Z

@jcar87 Sorry, I overlooked this. When compiled with visibility=hidden, there is no uvwasi symbol in the shared library. I think the only solution is to remove visibility=hidden.

I see @toge, thanks for providing a rationale behind this. In this case, and given that the upstream uvwasi repository already bundles a shared library, this seems like an issue in the upstream code that has nothing to do with Conan. My concern with the patch (that is, removing the hidden visibility compiler flag), is that if in the future this issue is addressed by the library authors by marking the exported symbols with the default visibility attribute, Conan Center would be generating a library that exports all symbols. In this case before accepting this particular patch, I would report this issue to upstream first, since it appears their shared library is not usable due to a bug (and if that is the case, I'd rather this recipe not provide a shared library at all).

toge · 2023-07-17T17:18:53Z

I agree with you.
Please wait a moment to do so.

AbrilRBS · 2023-08-09T14:41:55Z

Any updates @toge? :)

toge · 2023-09-18T14:09:36Z

In gcc <= 10.0, uvwasi's test_package.cpp returns 134 error code.
It worked fine on uvwasi/0.0.18.

I'm investigating.

uvwasi/0.0.19 (test package): RUN: ./test_package
Segmentation fault (core dumped)

ERROR: uvwasi/0.0.19 (test package): Error in test() method, line 26
        self.run(bin_path, env="conanrun")
        ConanException: Error 139 while executing

github-actions · 2024-04-20T06:36:33Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions · 2024-06-04T06:37:03Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

AbrilRBS · 2024-06-08T11:45:47Z

recipes/uvwasi/all/conanfile.py

+        cmake_layout(self, src_folder="src")
+
+    def requirements(self):
+        self.requires("libuv/1.48.0", transitive_headers=True)


We're going to allow version ranges for this library in the form of [>=1 <2] :)

github-actions · 2024-07-14T06:39:27Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

conan-center-bot · 2024-08-11T05:38:59Z

Conan v1 pipeline ❌

Failure in build 3 (9329996b9e720ec7a2e2dd59ace6cb5c90dc2724):

uvwasi/0.0.21:
CI failed to create some packages (All logs)

Logs for packageID a29621e36b84bd974c7a9e90e81864d910970f1a:

[settings]
arch=x86_64
build_type=Debug
compiler=gcc
compiler.libcxx=libstdc++11
compiler.version=11
os=Linux
[options]
uvwasi:shared=True

[...]
[HOOK - conan-center.py] pre_build(): [FPIC MANAGEMENT (KB-H007)] 'fPIC' option not found
[HOOK - conan-center.py] pre_build(): [FPIC MANAGEMENT (KB-H007)] OK
uvwasi/0.0.21 (test package): Calling build()
uvwasi/0.0.21 (test package): CMake command: cmake -G "Unix Makefiles" -DCMAKE_TOOLCHAIN_FILE="/home/conan/workspace/prod-v1/bsr/cci-86e52200/recipes/uvwasi/all/test_package/build/Debug/generators/conan_toolchain.cmake" -DCMAKE_POLICY_DEFAULT_CMP0091="NEW" -DCMAKE_BUILD_TYPE="Debug" "/home/conan/workspace/prod-v1/bsr/cci-86e52200/recipes/uvwasi/all/test_package/."

----Running------
> cmake -G "Unix Makefiles" -DCMAKE_TOOLCHAIN_FILE="/home/conan/workspace/prod-v1/bsr/cci-86e52200/recipes/uvwasi/all/test_package/build/Debug/generators/conan_toolchain.cmake" -DCMAKE_POLICY_DEFAULT_CMP0091="NEW" -DCMAKE_BUILD_TYPE="Debug" "/home/conan/workspace/prod-v1/bsr/cci-86e52200/recipes/uvwasi/all/test_package/."
-----------------
-- Using Conan toolchain: /home/conan/workspace/prod-v1/bsr/cci-86e52200/recipes/uvwasi/all/test_package/build/Debug/generators/conan_toolchain.cmake
-- The C compiler identification is GNU 11.4.0
-- Check for working C compiler: /usr/local/bin/cc
-- Check for working C compiler: /usr/local/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Conan: Target declared 'uvwasi::uvwasi'
-- Conan: Target declared 'uv'
-- Configuring done
-- Generating done
-- Build files have been written to: /home/conan/workspace/prod-v1/bsr/cci-86e52200/recipes/uvwasi/all/test_package/build/Debug
uvwasi/0.0.21 (test package): CMake command: cmake --build "/home/conan/workspace/prod-v1/bsr/cci-86e52200/recipes/uvwasi/all/test_package/build/Debug" '--' '-j3'

----Running------
> cmake --build "/home/conan/workspace/prod-v1/bsr/cci-86e52200/recipes/uvwasi/all/test_package/build/Debug" '--' '-j3'
-----------------
Scanning dependencies of target test_package
[ 50%] Building C object CMakeFiles/test_package.dir/test_package.c.o
[100%] Linking C executable test_package
[100%] Built target test_package
uvwasi/0.0.21 (test package): Running test()

----Running------
> . "/home/conan/workspace/prod-v1/bsr/cci-86e52200/recipes/uvwasi/all/test_package/build/Debug/generators/conanrun.sh" && ./test_package
-----------------
CMake Warning:
  Manually-specified variables were not used by the project:

    CMAKE_POLICY_DEFAULT_CMP0091


test_package: /home/conan/workspace/prod-v1/bsr/cci-86e52200/recipes/uvwasi/all/test_package/test_package.c:29: main: Assertion `err == UVWASI_ESUCCESS' failed.
Aborted
WARN: *** Conan 1 is legacy and on a deprecation path ***
WARN: *** Please upgrade to Conan 2 ***
uvwasi/0.0.21 (test package): WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
uvwasi/0.0.21 (test package): WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
ERROR: uvwasi/0.0.21 (test package): Error in test() method, line 26
	self.run(bin_path, env="conanrun")
	ConanException: Error 134 while executing ./test_package

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

uvwasi: add recipe

95cd9b2

prince-chrismc mentioned this pull request Jul 13, 2023

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

conan-center-bot added the Failed label Jul 13, 2023

This comment has been minimized.

Sign in to view

export all symbols

1d53b47

conan-center-bot removed the Failed label Jul 13, 2023

This comment has been minimized.

Sign in to view

AbrilRBS previously approved these changes Jul 14, 2023

View reviewed changes

AbrilRBS self-assigned this Jul 14, 2023

danimtb previously approved these changes Jul 14, 2023

View reviewed changes

jcar87 self-assigned this Jul 14, 2023

jcar87 reviewed Jul 14, 2023

View reviewed changes

separate patch files

3bd995b

This comment has been minimized.

Sign in to view

conan-center-bot added the Service Under Maintenance label Jul 24, 2023

This comment has been minimized.

Sign in to view

conan-center-bot removed the Service Under Maintenance label Aug 9, 2023

This comment has been minimized.

Sign in to view

update 0.0.19

75c7020

conan-center-bot added the Failed label Sep 16, 2023

This comment has been minimized.

Sign in to view

rm cmake, pkgconfig files

eb2cc2a

This comment has been minimized.

Sign in to view

github-actions bot added the stale label Apr 20, 2024

updat e0.0.21

4ac3aa3

conan-center-bot removed the stale label May 4, 2024

This comment has been minimized.

Sign in to view

update 0.0.21

82a5673

This comment has been minimized.

Sign in to view

github-actions bot added the stale label Jun 4, 2024

AbrilRBS reviewed Jun 13, 2024

View reviewed changes

github-actions bot removed the stale label Jun 14, 2024

github-actions bot added the stale label Jul 14, 2024

make libuv version range

9329996

conan-center-bot removed the stale label Aug 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

uvwasi: add recipe #18522

uvwasi: add recipe #18522

toge commented Jul 13, 2023

This comment has been minimized.

This comment has been minimized.

AbrilRBS left a comment

jcar87 Jul 14, 2023

toge Jul 17, 2023

jcar87 Jul 14, 2023

toge Jul 17, 2023

jcar87 commented Jul 17, 2023

This comment has been minimized.

toge commented Jul 17, 2023

jcar87 commented Jul 17, 2023

toge commented Jul 17, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

AbrilRBS commented Aug 9, 2023

This comment has been minimized.

This comment has been minimized.

toge commented Sep 18, 2023

github-actions bot commented Apr 20, 2024

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Jun 4, 2024

AbrilRBS Jun 8, 2024

github-actions bot commented Jul 14, 2024

conan-center-bot commented Aug 11, 2024

uvwasi: add recipe #18522

Are you sure you want to change the base?

uvwasi: add recipe #18522

Conversation

toge commented Jul 13, 2023

This comment has been minimized.

This comment has been minimized.

AbrilRBS left a comment

Choose a reason for hiding this comment

jcar87 Jul 14, 2023

Choose a reason for hiding this comment

toge Jul 17, 2023

Choose a reason for hiding this comment

jcar87 Jul 14, 2023

Choose a reason for hiding this comment

toge Jul 17, 2023

Choose a reason for hiding this comment

jcar87 commented Jul 17, 2023

This comment has been minimized.

toge commented Jul 17, 2023

jcar87 commented Jul 17, 2023

toge commented Jul 17, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

AbrilRBS commented Aug 9, 2023

This comment has been minimized.

This comment has been minimized.

toge commented Sep 18, 2023

github-actions bot commented Apr 20, 2024

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Jun 4, 2024

AbrilRBS Jun 8, 2024

Choose a reason for hiding this comment

github-actions bot commented Jul 14, 2024

conan-center-bot commented Aug 11, 2024

Conan v1 pipeline ❌