Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdl_mixer/all: migrate to Conan v2 #18836

Merged
merged 8 commits into from
Aug 30, 2024

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Jul 22, 2023

Linking in test_package currently fails for GCC due to #12826.

@conan-center-bot

This comment has been minimized.

@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit 60c8ca2
sdl_mixer/2.0.4
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2_mixer.dylib' links to system library 'CoreServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2_mixer.dylib' links to system library 'AppKit' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2_mixer.dylib' links to system library 'CoreGraphics' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2_mixer.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libSDL2_mixer.dylib

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@valgur
Copy link
Contributor Author

valgur commented Jul 26, 2023

Closing temporarily to avoid unnecessary load on the CI. Will reopen when I'm actively working on the PR again.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@stale
Copy link

stale bot commented Oct 15, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 15, 2023
@conan-center-bot conan-center-bot added Version conflict There is a version conflict when solving the dependencies graph and removed stale labels Oct 25, 2023
@conan-center-bot

This comment has been minimized.

valgur added a commit to valgur/conan-center-index that referenced this pull request Oct 25, 2023
@valgur valgur mentioned this pull request Oct 25, 2023
@valgur valgur marked this pull request as ready for review October 25, 2023 12:38
conan-center-bot pushed a commit that referenced this pull request Oct 26, 2023
For sdl_mixer #18836.

Co-authored-by: Rubén Rincón Blanco <rubenrb@jfrog.com>
@conan-center-bot conan-center-bot removed the Version conflict There is a version conflict when solving the dependencies graph label Oct 26, 2023
@conan-center-bot

This comment has been minimized.

@github-actions github-actions bot removed the stale label Jun 13, 2024
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

Copy link
Contributor

Hooks produced the following warnings for commit 9098e39
sdl_mixer/2.0.4@#d6252b6bc7e2dd44c6b078254f7f20c3
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2_mixer.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2_mixer.dylib' links to system library 'AppKit' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2_mixer.dylib' links to system library 'CoreGraphics' but it is not in cpp_info.frameworks.

Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Aug 24, 2024
@valgur
Copy link
Contributor Author

valgur commented Aug 24, 2024

Don't close.

@github-actions github-actions bot removed the stale label Aug 25, 2024
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for providing this migration. Some considerations:

  • Remove fluidsynth as requirement, and its option too. It's not available in CCI and trying to use will break the package.

Regards.

@uilianries uilianries self-assigned this Aug 29, 2024
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 13 (505a6b407559e99f85a8920501b958bbb98a2e41):

  • sdl_mixer/2.0.4:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 11 (505a6b407559e99f85a8920501b958bbb98a2e41):

  • sdl_mixer/2.0.4:
    All packages built successfully! (All logs)

Copy link
Contributor

Hooks produced the following warnings for commit 505a6b4
sdl_mixer/2.0.4@#8dbc6fb56b9c3650f5bd04ad3e23a356
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2_mixer.dylib' links to system library 'AppKit' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2_mixer.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSDL2_mixer.dylib' links to system library 'CoreGraphics' but it is not in cpp_info.frameworks.

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit 043f04f into conan-io:master Aug 30, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants