Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mpdecimal/2.4.2: migrate to Conan v2 #18901

Merged
merged 7 commits into from
Jan 10, 2024
Merged

mpdecimal/2.4.2: migrate to Conan v2 #18901

merged 7 commits into from
Jan 10, 2024

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Jul 25, 2023

No description provided.

@prince-chrismc prince-chrismc mentioned this pull request Jul 25, 2023
Open
@valgur
Copy link
Contributor Author

valgur commented Jul 26, 2023

Closing temporarily to avoid unnecessary load on the CI. Will reopen when I'm actively working on the PR again.

@valgur valgur closed this Jul 26, 2023
@valgur valgur reopened this Aug 16, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@stale
Copy link

stale bot commented Sep 17, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 17, 2023
@valgur valgur closed this Sep 17, 2023
@valgur valgur reopened this Sep 17, 2023
@stale stale bot removed the stale label Sep 17, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

Hooks produced the following warnings for commit 68eff4e
mpdecimal/2.4.2@#703397f27da7f2b29711b0f9ad7c7e1c 
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libmpdec.dylib

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 5 (65d834f604a0cef23e4d82744fca5c595664763c):

  • mpdecimal/2.5.1:
    All packages built successfully! (All logs)

  • mpdecimal/2.5.0:
    All packages built successfully! (All logs)

  • mpdecimal/2.4.2:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 5 (65d834f604a0cef23e4d82744fca5c595664763c):

  • mpdecimal/2.5.1:
    All packages built successfully! (All logs)

  • mpdecimal/2.5.0:
    All packages built successfully! (All logs)

  • mpdecimal/2.4.2:
    All packages built successfully! (All logs)

@valgur
Copy link
Contributor Author

valgur commented Oct 24, 2023

@RubenRBS Pinging just in case. Should be ready to be merged.

@valgur valgur mentioned this pull request Nov 8, 2023
Open
@Ahajha
Copy link
Contributor

Ahajha commented Dec 2, 2023

@RubenRBS Another bump on this one, it will be necessary for the CPython migration

@AbrilRBS AbrilRBS self-assigned this Jan 8, 2024
AbrilRBS
AbrilRBS reviewed Jan 9, 2024
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good, but I have a suggestion for removing 2.4.2, let me know what you think @valgur

recipes/mpdecimal/2.4.2/conanfile.py Show resolved Hide resolved
@conan-center-bot conan-center-bot merged commit 757a1f6 into conan-io:master Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ahajha Ahajha Ahajha left review comments

@samuel-emrys samuel-emrys samuel-emrys approved these changes

@jwillikers jwillikers jwillikers approved these changes

@AbrilRBS AbrilRBS AbrilRBS approved these changes

Assignees

@AbrilRBS AbrilRBS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@valgur @conan-center-bot @Ahajha @AbrilRBS @jwillikers @samuel-emrys