[docs] Change conan v2 feedback message #19522
Conversation
Signed-off-by: Uilian Ries <uilianries@gmail.com>
.c3i/config_v2.yml
Outdated
| regression: "> **Regression**: Conan v2 builds are mandatory and they are required for the PR to be merged, because this recipe worked with Conan v2 previously." | ||
| text_on_failure: "The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future." | ||
| text_on_failure: "The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, comment on the PR and we will help you." |
There was a problem hiding this comment.
maybe we need a more specific message to ask for help. Maybe a gh mention with "@___" do we have a @<maintainers> group?
There was a problem hiding this comment.
Yes, so far we have Barbarians group, but it alerts everyone. We could provide another group. As groups are created by organization, @maintainers would be too generic, what about @cci-maintainers then?
There was a problem hiding this comment.
let's start with @conan-io/barbarians
There was a problem hiding this comment.
Done, included conan/barbarians
There was a problem hiding this comment.
You wont get notifications from non-members of the group AFAIK on GitHub
There was a problem hiding this comment.
@prince-chrismc I didn't know about that. Checking the documentation, it seems we can configure notifications: https://docs.github.com/en/organizations/organizing-members-into-teams/configuring-team-notifications
There was a problem hiding this comment.
Ohhh perfect! Glad they changed that
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Daniel <danimanzaneque@gmail.com>
* change conan v2 feedback message Signed-off-by: Uilian Ries <uilianries@gmail.com> * ping conan-io/barbarians Signed-off-by: Uilian Ries <uilianries@gmail.com> * Update .c3i/config_v2.yml Co-authored-by: Daniel <danimanzaneque@gmail.com> --------- Signed-off-by: Uilian Ries <uilianries@gmail.com> Co-authored-by: Daniel <danimanzaneque@gmail.com>
Following Conan 2.x migration schedule. From now, all PRs should pass by Conan 2.x CI build.
More information in #19104
Most of recipes are ported now to Conan 2.x, and the recommendation for those that are still missing is pinging us in the PR, so we can help to migrate it too.
This PR only updates the feedback message, not the CI behavior. The behavior should be done in a separated PR.
/cc @jcar87 @danimtb @RubenRBS