Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add snitch 1.2.3 #19551

Merged
merged 26 commits into from
Nov 17, 2023
Merged

Add snitch 1.2.3 #19551

merged 26 commits into from
Nov 17, 2023

Conversation

cschreib
Copy link
Contributor

@cschreib cschreib commented Sep 1, 2023

Specify library name and version: snitch/1.2.3

Hi there, I am the author of this library and would like to contribute a recipe for it.


@CLAassistant
Copy link

CLAassistant commented Sep 1, 2023

CLA assistant check
All committers have signed the CLA.

@conan-center-bot

This comment has been minimized.

@cschreib
Copy link
Contributor Author

cschreib commented Sep 2, 2023

I will add a patch to lower the minimum CMake version. That should fix the v1 pipeline. For the v2 pipeline, I don't know yet.

Edit: I think the v2 issue can be solved by replacing "ANY" with ["ANY"], as suggested in the migration guide. I will try this locally and push an updated commit when I get this working.

@cschreib cschreib changed the title Add snitch 1.2.0 Add snitch 1.2.1 Sep 3, 2023
@conan-center-bot

This comment has been minimized.

@cschreib
Copy link
Contributor Author

cschreib commented Sep 3, 2023

For v1 pipeline: No idea at this stage. I will look at the logs further and see if I can replicate the error on my end. Edit: Yes, the test_v1_package/conanfile.py was using v2 stuff. I have fixed that locally.

For v2 pipeline: I don't know how this slipped through the cracks, but it seems my CMake scripts actually still require CMake 3.19 features. I will add more thorough tests with CMake 3.14, which is the advertised minimum version. Then patch or issue another release.

@cschreib cschreib changed the title Add snitch 1.2.1 Add snitch 1.2.2 Sep 5, 2023
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2023

Hooks produced the following warnings for commit 55463d1
snitch/1.2.2@#191bf06aca2e21318a49301d66ad79d3
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libsnitch.so' links to system library 'm' but it is not in cpp_info.system_libs.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@cschreib cschreib changed the title Add snitch 1.2.2 Add snitch 1.2.3 Oct 15, 2023
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 10 (dafed1dd66ac73593a63bffdf59a02635818a7eb):

  • snitch/1.2.3:
    All packages built successfully! (All logs)

  • snitch/1.2.2:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 10 (dafed1dd66ac73593a63bffdf59a02635818a7eb):

  • snitch/1.2.3:
    All packages built successfully! (All logs)

  • snitch/1.2.2:
    All packages built successfully! (All logs)

@cschreib
Copy link
Contributor Author

Note: I have migrated the library from my personal GitHub account to a dedicated organization, to allow for more than one maintainer. Hence all the URLs have been updated.

@uilianries uilianries self-assigned this Nov 17, 2023
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uilianries
Copy link
Member

@cschreib Thank you for your first contribution here in ConanCenterIndex! I see your recipe is looking real good. We still need one more positive review to be merged.

More info about our review process: https://github.com/conan-io/conan-center-index/blob/master/docs/review_process.md

@conan-center-bot conan-center-bot merged commit 4bc6126 into conan-io:master Nov 17, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants