Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

godot-cpp: add version 4.1.1 #19920

Closed
wants to merge 12 commits into from

Conversation

fmorgner
Copy link
Contributor

@fmorgner fmorgner commented Sep 17, 2023

Specify library name and version: godot-cpp/4.1.1


@CLAassistant
Copy link

CLAassistant commented Sep 17, 2023

CLA assistant check
All committers have signed the CLA.

@conan-center-bot

This comment has been minimized.

@fmorgner
Copy link
Contributor Author

I will look into the V2 build/lint of the old versions on the weekend.

@conan-center-bot

This comment has been minimized.

@ghost ghost mentioned this pull request Sep 21, 2023
@fmorgner
Copy link
Contributor Author

I fixed the linter issues in 3.x.x (and one in 4.x.x). I tried to keep the changes small (although i did fix the format string warnings as well), since this PR is primarily focused on adding 4.1.1. I think that modernizing the 3.x.x conanfile should be done separately in a future PR (or by rebasing and adjusting #18862).

@fmorgner fmorgner marked this pull request as ready for review September 28, 2023 11:12
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@fmorgner
Copy link
Contributor Author

fmorgner commented Oct 8, 2023

Is the v2 build expected to be re-triggered automatically (like the v1 one) or is there something I (or someone else) has to do?

@Croydon
Copy link
Contributor

Croydon commented Feb 28, 2024

Can we pls get a CI re-run here? @uilianries @RubenRBS

ConanV2 was in maintenance when it did run

@uilianries uilianries self-assigned this Mar 1, 2024
@uilianries
Copy link
Member

@Croydon Danke! I just re-triggered now.

@Croydon
Copy link
Contributor

Croydon commented Mar 4, 2024

No new CI feedback?

@uilianries
Copy link
Member

I just fixed some git conflicts, it triggers a new CI build that should post the result now.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 11 (f880fdef700631ff28ae065930e4f033f01de751):

  • godot-cpp/3.5.1:
    All packages built successfully! (All logs)

  • godot-cpp/4.1.1:
    All packages built successfully! (All logs)

  • godot-cpp/3.3.4:
    All packages built successfully! (All logs)

  • godot-cpp/cci.3.2-20200130:
    All packages built successfully! (All logs)


Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

See details:

Failure in build 7 (f880fdef700631ff28ae065930e4f033f01de751):

  • godot-cpp/3.5.1:
    All packages built successfully! (All logs)

  • godot-cpp/cci.3.2-20200130:
    All packages built successfully! (All logs)

  • godot-cpp/3.3.4:
    All packages built successfully! (All logs)

  • godot-cpp/4.1.1:
    CI failed to create some packages (All logs)

    Logs for packageID 2068baaab67a8d1ae925bbe12c37df5b885a6d56:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=msvc
    compiler.cppstd=17
    compiler.runtime=dynamic
    compiler.runtime_type=Release
    compiler.version=193
    os=Windows
    
    [...]
    godot-cpp.windows.release.64.lib(stream_peer_extension.obj) : error LNK2038: mismatch detected for '_ITERATOR_DEBUG_LEVEL': value '2' doesn't match value '0' in test_package.obj [C:\J2\w\prod-v2\bsr\cci-1d4c2ae5\recipes\godot-cpp\4.x.x\test_package\build\msvc-193-x86_64-17-release\test_package.vcxproj]
    godot-cpp.windows.release.64.lib(stream_peer_extension.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MDd_DynamicDebug' doesn't match value 'MD_DynamicRelease' in test_package.obj [C:\J2\w\prod-v2\bsr\cci-1d4c2ae5\recipes\godot-cpp\4.x.x\test_package\build\msvc-193-x86_64-17-release\test_package.vcxproj]
    godot-cpp.windows.release.64.lib(style_box.obj) : error LNK2038: mismatch detected for '_ITERATOR_DEBUG_LEVEL': value '2' doesn't match value '0' in test_package.obj [C:\J2\w\prod-v2\bsr\cci-1d4c2ae5\recipes\godot-cpp\4.x.x\test_package\build\msvc-193-x86_64-17-release\test_package.vcxproj]
    godot-cpp.windows.release.64.lib(style_box.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MDd_DynamicDebug' doesn't match value 'MD_DynamicRelease' in test_package.obj [C:\J2\w\prod-v2\bsr\cci-1d4c2ae5\recipes\godot-cpp\4.x.x\test_package\build\msvc-193-x86_64-17-release\test_package.vcxproj]
    godot-cpp.windows.release.64.lib(text_server_extension.obj) : error LNK2038: mismatch detected for '_ITERATOR_DEBUG_LEVEL': value '2' doesn't match value '0' in test_package.obj [C:\J2\w\prod-v2\bsr\cci-1d4c2ae5\recipes\godot-cpp\4.x.x\test_package\build\msvc-193-x86_64-17-release\test_package.vcxproj]
    godot-cpp.windows.release.64.lib(text_server_extension.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MDd_DynamicDebug' doesn't match value 'MD_DynamicRelease' in test_package.obj [C:\J2\w\prod-v2\bsr\cci-1d4c2ae5\recipes\godot-cpp\4.x.x\test_package\build\msvc-193-x86_64-17-release\test_package.vcxproj]
    godot-cpp.windows.release.64.lib(tile_map.obj) : error LNK2038: mismatch detected for '_ITERATOR_DEBUG_LEVEL': value '2' doesn't match value '0' in test_package.obj [C:\J2\w\prod-v2\bsr\cci-1d4c2ae5\recipes\godot-cpp\4.x.x\test_package\build\msvc-193-x86_64-17-release\test_package.vcxproj]
    godot-cpp.windows.release.64.lib(tile_map.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MDd_DynamicDebug' doesn't match value 'MD_DynamicRelease' in test_package.obj [C:\J2\w\prod-v2\bsr\cci-1d4c2ae5\recipes\godot-cpp\4.x.x\test_package\build\msvc-193-x86_64-17-release\test_package.vcxproj]
    godot-cpp.windows.release.64.lib(video_stream.obj) : error LNK2038: mismatch detected for '_ITERATOR_DEBUG_LEVEL': value '2' doesn't match value '0' in test_package.obj [C:\J2\w\prod-v2\bsr\cci-1d4c2ae5\recipes\godot-cpp\4.x.x\test_package\build\msvc-193-x86_64-17-release\test_package.vcxproj]
    godot-cpp.windows.release.64.lib(video_stream.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MDd_DynamicDebug' doesn't match value 'MD_DynamicRelease' in test_package.obj [C:\J2\w\prod-v2\bsr\cci-1d4c2ae5\recipes\godot-cpp\4.x.x\test_package\build\msvc-193-x86_64-17-release\test_package.vcxproj]
    godot-cpp.windows.release.64.lib(video_stream_playback.obj) : error LNK2038: mismatch detected for '_ITERATOR_DEBUG_LEVEL': value '2' doesn't match value '0' in test_package.obj [C:\J2\w\prod-v2\bsr\cci-1d4c2ae5\recipes\godot-cpp\4.x.x\test_package\build\msvc-193-x86_64-17-release\test_package.vcxproj]
    godot-cpp.windows.release.64.lib(video_stream_playback.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MDd_DynamicDebug' doesn't match value 'MD_DynamicRelease' in test_package.obj [C:\J2\w\prod-v2\bsr\cci-1d4c2ae5\recipes\godot-cpp\4.x.x\test_package\build\msvc-193-x86_64-17-release\test_package.vcxproj]
    godot-cpp.windows.release.64.lib(visual_shader_node_custom.obj) : error LNK2038: mismatch detected for '_ITERATOR_DEBUG_LEVEL': value '2' doesn't match value '0' in test_package.obj [C:\J2\w\prod-v2\bsr\cci-1d4c2ae5\recipes\godot-cpp\4.x.x\test_package\build\msvc-193-x86_64-17-release\test_package.vcxproj]
    godot-cpp.windows.release.64.lib(visual_shader_node_custom.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MDd_DynamicDebug' doesn't match value 'MD_DynamicRelease' in test_package.obj [C:\J2\w\prod-v2\bsr\cci-1d4c2ae5\recipes\godot-cpp\4.x.x\test_package\build\msvc-193-x86_64-17-release\test_package.vcxproj]
    godot-cpp.windows.release.64.lib(web_rtc_data_channel_extension.obj) : error LNK2038: mismatch detected for '_ITERATOR_DEBUG_LEVEL': value '2' doesn't match value '0' in test_package.obj [C:\J2\w\prod-v2\bsr\cci-1d4c2ae5\recipes\godot-cpp\4.x.x\test_package\build\msvc-193-x86_64-17-release\test_package.vcxproj]
    godot-cpp.windows.release.64.lib(web_rtc_data_channel_extension.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MDd_DynamicDebug' doesn't match value 'MD_DynamicRelease' in test_package.obj [C:\J2\w\prod-v2\bsr\cci-1d4c2ae5\recipes\godot-cpp\4.x.x\test_package\build\msvc-193-x86_64-17-release\test_package.vcxproj]
    godot-cpp.windows.release.64.lib(web_rtc_peer_connection_extension.obj) : error LNK2038: mismatch detected for '_ITERATOR_DEBUG_LEVEL': value '2' doesn't match value '0' in test_package.obj [C:\J2\w\prod-v2\bsr\cci-1d4c2ae5\recipes\godot-cpp\4.x.x\test_package\build\msvc-193-x86_64-17-release\test_package.vcxproj]
    godot-cpp.windows.release.64.lib(web_rtc_peer_connection_extension.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MDd_DynamicDebug' doesn't match value 'MD_DynamicRelease' in test_package.obj [C:\J2\w\prod-v2\bsr\cci-1d4c2ae5\recipes\godot-cpp\4.x.x\test_package\build\msvc-193-x86_64-17-release\test_package.vcxproj]
    godot-cpp.windows.release.64.lib(xr_interface_extension.obj) : error LNK2038: mismatch detected for '_ITERATOR_DEBUG_LEVEL': value '2' doesn't match value '0' in test_package.obj [C:\J2\w\prod-v2\bsr\cci-1d4c2ae5\recipes\godot-cpp\4.x.x\test_package\build\msvc-193-x86_64-17-release\test_package.vcxproj]
    godot-cpp.windows.release.64.lib(xr_interface_extension.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MDd_DynamicDebug' doesn't match value 'MD_DynamicRelease' in test_package.obj [C:\J2\w\prod-v2\bsr\cci-1d4c2ae5\recipes\godot-cpp\4.x.x\test_package\build\msvc-193-x86_64-17-release\test_package.vcxproj]
    godot-cpp.windows.release.64.lib(method_bind.obj) : error LNK2038: mismatch detected for '_ITERATOR_DEBUG_LEVEL': value '2' doesn't match value '0' in test_package.obj [C:\J2\w\prod-v2\bsr\cci-1d4c2ae5\recipes\godot-cpp\4.x.x\test_package\build\msvc-193-x86_64-17-release\test_package.vcxproj]
    godot-cpp.windows.release.64.lib(method_bind.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MDd_DynamicDebug' doesn't match value 'MD_DynamicRelease' in test_package.obj [C:\J2\w\prod-v2\bsr\cci-1d4c2ae5\recipes\godot-cpp\4.x.x\test_package\build\msvc-193-x86_64-17-release\test_package.vcxproj]
    godot-cpp.windows.release.64.lib(packed_arrays.obj) : error LNK2038: mismatch detected for '_ITERATOR_DEBUG_LEVEL': value '2' doesn't match value '0' in test_package.obj [C:\J2\w\prod-v2\bsr\cci-1d4c2ae5\recipes\godot-cpp\4.x.x\test_package\build\msvc-193-x86_64-17-release\test_package.vcxproj]
    godot-cpp.windows.release.64.lib(packed_arrays.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MDd_DynamicDebug' doesn't match value 'MD_DynamicRelease' in test_package.obj [C:\J2\w\prod-v2\bsr\cci-1d4c2ae5\recipes\godot-cpp\4.x.x\test_package\build\msvc-193-x86_64-17-release\test_package.vcxproj]
    godot-cpp.windows.release.64.lib(plane.obj) : error LNK2038: mismatch detected for '_ITERATOR_DEBUG_LEVEL': value '2' doesn't match value '0' in test_package.obj [C:\J2\w\prod-v2\bsr\cci-1d4c2ae5\recipes\godot-cpp\4.x.x\test_package\build\msvc-193-x86_64-17-release\test_package.vcxproj]
    godot-cpp.windows.release.64.lib(plane.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MDd_DynamicDebug' doesn't match value 'MD_DynamicRelease' in test_package.obj [C:\J2\w\prod-v2\bsr\cci-1d4c2ae5\recipes\godot-cpp\4.x.x\test_package\build\msvc-193-x86_64-17-release\test_package.vcxproj]
    godot-cpp.windows.release.64.lib(basis.obj) : error LNK2038: mismatch detected for '_ITERATOR_DEBUG_LEVEL': value '2' doesn't match value '0' in test_package.obj [C:\J2\w\prod-v2\bsr\cci-1d4c2ae5\recipes\godot-cpp\4.x.x\test_package\build\msvc-193-x86_64-17-release\test_package.vcxproj]
    godot-cpp.windows.release.64.lib(basis.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MDd_DynamicDebug' doesn't match value 'MD_DynamicRelease' in test_package.obj [C:\J2\w\prod-v2\bsr\cci-1d4c2ae5\recipes\godot-cpp\4.x.x\test_package\build\msvc-193-x86_64-17-release\test_package.vcxproj]
    godot-cpp.windows.release.64.lib(ref_counted.obj) : error LNK2038: mismatch detected for '_ITERATOR_DEBUG_LEVEL': value '2' doesn't match value '0' in test_package.obj [C:\J2\w\prod-v2\bsr\cci-1d4c2ae5\recipes\godot-cpp\4.x.x\test_package\build\msvc-193-x86_64-17-release\test_package.vcxproj]
    godot-cpp.windows.release.64.lib(ref_counted.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MDd_DynamicDebug' doesn't match value 'MD_DynamicRelease' in test_package.obj [C:\J2\w\prod-v2\bsr\cci-1d4c2ae5\recipes\godot-cpp\4.x.x\test_package\build\msvc-193-x86_64-17-release\test_package.vcxproj]
    godot-cpp.windows.release.64.lib(vector3.obj) : error LNK2038: mismatch detected for '_ITERATOR_DEBUG_LEVEL': value '2' doesn't match value '0' in test_package.obj [C:\J2\w\prod-v2\bsr\cci-1d4c2ae5\recipes\godot-cpp\4.x.x\test_package\build\msvc-193-x86_64-17-release\test_package.vcxproj]
    godot-cpp.windows.release.64.lib(vector3.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MDd_DynamicDebug' doesn't match value 'MD_DynamicRelease' in test_package.obj [C:\J2\w\prod-v2\bsr\cci-1d4c2ae5\recipes\godot-cpp\4.x.x\test_package\build\msvc-193-x86_64-17-release\test_package.vcxproj]
    godot-cpp.windows.release.64.lib(quaternion.obj) : error LNK2038: mismatch detected for '_ITERATOR_DEBUG_LEVEL': value '2' doesn't match value '0' in test_package.obj [C:\J2\w\prod-v2\bsr\cci-1d4c2ae5\recipes\godot-cpp\4.x.x\test_package\build\msvc-193-x86_64-17-release\test_package.vcxproj]
    godot-cpp.windows.release.64.lib(quaternion.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MDd_DynamicDebug' doesn't match value 'MD_DynamicRelease' in test_package.obj [C:\J2\w\prod-v2\bsr\cci-1d4c2ae5\recipes\godot-cpp\4.x.x\test_package\build\msvc-193-x86_64-17-release\test_package.vcxproj]
    LINK : warning LNK4098: defaultlib 'MSVCRTD' conflicts with use of other libs; use /NODEFAULTLIB:library [C:\J2\w\prod-v2\bsr\cci-1d4c2ae5\recipes\godot-cpp\4.x.x\test_package\build\msvc-193-x86_64-17-release\test_package.vcxproj]
    godot-cpp.windows.release.64.lib(method_bind.obj) : error LNK2001: unresolved external symbol __imp__invalid_parameter [C:\J2\w\prod-v2\bsr\cci-1d4c2ae5\recipes\godot-cpp\4.x.x\test_package\build\msvc-193-x86_64-17-release\test_package.vcxproj]
    godot-cpp.windows.release.64.lib(register_engine_classes.obj) : error LNK2001: unresolved external symbol __imp__invalid_parameter [C:\J2\w\prod-v2\bsr\cci-1d4c2ae5\recipes\godot-cpp\4.x.x\test_package\build\msvc-193-x86_64-17-release\test_package.vcxproj]
    godot-cpp.windows.release.64.lib(class_db.obj) : error LNK2001: unresolved external symbol __imp__invalid_parameter [C:\J2\w\prod-v2\bsr\cci-1d4c2ae5\recipes\godot-cpp\4.x.x\test_package\build\msvc-193-x86_64-17-release\test_package.vcxproj]
    godot-cpp.windows.release.64.lib(editor_plugin.cpp.obj) : error LNK2001: unresolved external symbol __imp__invalid_parameter [C:\J2\w\prod-v2\bsr\cci-1d4c2ae5\recipes\godot-cpp\4.x.x\test_package\build\msvc-193-x86_64-17-release\test_package.vcxproj]
    godot-cpp.windows.release.64.lib(object.cpp.obj) : error LNK2001: unresolved external symbol __imp__invalid_parameter [C:\J2\w\prod-v2\bsr\cci-1d4c2ae5\recipes\godot-cpp\4.x.x\test_package\build\msvc-193-x86_64-17-release\test_package.vcxproj]
    godot-cpp.windows.release.64.lib(method_bind.obj) : error LNK2001: unresolved external symbol __imp__CrtDbgReport [C:\J2\w\prod-v2\bsr\cci-1d4c2ae5\recipes\godot-cpp\4.x.x\test_package\build\msvc-193-x86_64-17-release\test_package.vcxproj]
    godot-cpp.windows.release.64.lib(register_engine_classes.obj) : error LNK2001: unresolved external symbol __imp__CrtDbgReport [C:\J2\w\prod-v2\bsr\cci-1d4c2ae5\recipes\godot-cpp\4.x.x\test_package\build\msvc-193-x86_64-17-release\test_package.vcxproj]
    godot-cpp.windows.release.64.lib(class_db.obj) : error LNK2001: unresolved external symbol __imp__CrtDbgReport [C:\J2\w\prod-v2\bsr\cci-1d4c2ae5\recipes\godot-cpp\4.x.x\test_package\build\msvc-193-x86_64-17-release\test_package.vcxproj]
    godot-cpp.windows.release.64.lib(editor_plugin.cpp.obj) : error LNK2001: unresolved external symbol __imp__CrtDbgReport [C:\J2\w\prod-v2\bsr\cci-1d4c2ae5\recipes\godot-cpp\4.x.x\test_package\build\msvc-193-x86_64-17-release\test_package.vcxproj]
    godot-cpp.windows.release.64.lib(object.cpp.obj) : error LNK2001: unresolved external symbol __imp__CrtDbgReport [C:\J2\w\prod-v2\bsr\cci-1d4c2ae5\recipes\godot-cpp\4.x.x\test_package\build\msvc-193-x86_64-17-release\test_package.vcxproj]
    C:\J2\w\prod-v2\bsr\cci-1d4c2ae5\recipes\godot-cpp\4.x.x\test_package\build\msvc-193-x86_64-17-release\Release\test_package.exe : fatal error LNK1120: 2 unresolved externals [C:\J2\w\prod-v2\bsr\cci-1d4c2ae5\recipes\godot-cpp\4.x.x\test_package\build\msvc-193-x86_64-17-release\test_package.vcxproj]
    
    ERROR: godot-cpp/4.1.1 (test package): Error in build() method, line 15
    	cmake.build()
    	ConanException: Error 1 while executing
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

Copy link
Contributor

github-actions bot commented Sep 4, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Sep 4, 2024
Copy link
Contributor

github-actions bot commented Oct 4, 2024

This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions.

@github-actions github-actions bot closed this Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants