-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
godot-cpp: add version 4.1.1 #19920
godot-cpp: add version 4.1.1 #19920
Conversation
This comment has been minimized.
This comment has been minimized.
I will look into the V2 build/lint of the old versions on the weekend. |
This comment has been minimized.
This comment has been minimized.
I fixed the linter issues in 3.x.x (and one in 4.x.x). I tried to keep the changes small (although i did fix the format string warnings as well), since this PR is primarily focused on adding 4.1.1. I think that modernizing the 3.x.x conanfile should be done separately in a future PR (or by rebasing and adjusting #18862). |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Is the v2 build expected to be re-triggered automatically (like the v1 one) or is there something I (or someone else) has to do? |
Can we pls get a CI re-run here? @uilianries @RubenRBS ConanV2 was in maintenance when it did run |
@Croydon Danke! I just re-triggered now. |
No new CI feedback? |
…recipe/godot-cpp-4.1.1
…recipe/godot-cpp-4.1.1
I just fixed some git conflicts, it triggers a new CI build that should post the result now. |
Conan v1 pipeline ✔️All green in build 11 (
Conan v2 pipeline ❌
The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping See details:Failure in build 7 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions. |
Specify library name and version: godot-cpp/4.1.1