-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
protobuf: improve discovery of protoc executable in build context #20089
protobuf: improve discovery of protoc executable in build context #20089
Conversation
🤖 Beep Boop! This pull request is making changes to 'recipes/protobuf//'. 👋 @Hopobcn you might be interested. 😉 |
I detected other pull requests that are modifying protobuf/all recipe:
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@RubenRBS @danimtb @uilianries Is c3i logic broken? There should be a "lock" delaying execution of test package for For example here c3i complains that A solution for v2 pipeline might be to inject shared value in requirements AND build requirements.. BUT, it may lead to many issues on macOS due to SIP. |
I guess that it should pass if I trigger c3i again, since package is available now... |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Well, it's super tedious. I've opened #20534 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
It's a bug of v2 pipeline: #19501 (comment) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 19 (
Conan v2 pipeline ✔️
All green in build 19 (
|
is there a way to roll back this? as this causing more harm than good #21737 |
…build context * improve discovery of protoc executable in build context * addd more comments * fix test package
…build context * improve discovery of protoc executable in build context * addd more comments * fix test package
…build context * improve discovery of protoc executable in build context * addd more comments * fix test package (cherry picked from commit 7b25813)
While building googleapis shared against protobuf shared, and protobuf static in build requirements, I've realized that the protoc flavor linked to shared protobuf was used, instead of the static flavor.
So this PR fixes this issue, by ensuring that even for native build, protoc from build requirements is used when available, instead of protoc from requirements.