new library: Simage #20197

weatherhead99 · 2023-09-29T04:04:01Z

Specify library name and version: simage/1.8.3

This is a package for the coin3D simage library (https://www.coin3d.org/simage/html/), I am planning to package Coin3D itself (though likely not all the libraries) in order to tackle larger packaging projects e.g. CERN Geant4 which for many of their functions depend on coin3D. I have no affiliation personally with coin3D library developers.

[ X ] I've read the contributing guidelines.
[ X ] I've used a recent Conan client version close to the currently deployed.
[ X ] I've tried at least one configuration locally with the conan-center hook activated.

valgur

LGTM in general, except for the probably buggy Qt option handling.

Also, looks like a useful library. Thanks! 😃

recipes/simage/all/conanfile.py

valgur · 2023-10-02T11:54:04Z

recipes/simage/all/conanfile.py

+        tc.cache_variables["VORBIS_ROOT"] = get_include_root(self, "vorbis")
+        #same for Ogg
+        tc.cache_variables["OGG_ROOT"] = get_include_root(self, "ogg")


Suggested change

tc.cache_variables["VORBIS_ROOT"] = get_include_root(self, "vorbis")

#same for Ogg

tc.cache_variables["OGG_ROOT"] = get_include_root(self, "ogg")

tc.cache_variables["VORBIS_ROOT"] = conanfile.dependencies["vorbis"].package_folder

#same for Ogg

tc.cache_variables["OGG_ROOT"] = conanfile.dependencies["ogg"].package_folder

on thinking about this, I actually feel like I want to keep get_include_root for the following reason:
if it so happens that you are working on "ogg" or "vorbis" in a local folderf and have them in "editable" mode, then getting the parent directory of the includes will still work, whereas package_folder will be None, right?

valgur · 2023-10-02T11:54:19Z

recipes/simage/all/conanfile.py

+
+def get_include_root(conanfile: ConanFile, depname: str) -> str:
+    pth = pathlib.Path(conanfile.dependencies[depname].cpp_info.includedirs[0]).parent
+    return str(pth)


Suggested change

def get_include_root(conanfile: ConanFile, depname: str) -> str:

pth = pathlib.Path(conanfile.dependencies[depname].cpp_info.includedirs[0]).parent

return str(pth)

will fix these together in one commit

recipes/simage/all/conanfile.py

you can use pathlib.Path objects directly Co-authored-by: Martin Valgur <martin.valgur@gmail.com>

remove properties that will be correct defaults anyway Co-authored-by: Martin Valgur <martin.valgur@gmail.com>

weatherhead99 · 2023-10-05T01:42:00Z

question: this package by default includes stuff licensed under ISC, and also a folder of MPEG decoders which has the following dubious license text:

Copyright (C) 1996, MPEG Software Simulation Group. All Rights Reserved.

Disclaimer of Warranty

These software programs are available to the user without any license fee or
royalty on an "as is" basis. The MPEG Software Simulation Group disclaims
any and all warranties, whether express, implied, or statuary, including any
implied warranties or merchantability or of fitness for a particular
purpose. In no event shall the copyright-holder be liable for any
incidental, punitive, or consequential damages of any kind whatsoever
arising from the use of these programs.

This disclaimer of warranty extends to the user of these programs and user's
customers, employees, agents, transferees, successors, and assigns.

The MPEG Software Simulation Group does not represent or warrant that the
programs furnished hereunder are free of infringement of any third-party
patents.

Commercial implementations of MPEG-1 and MPEG-2 video, including shareware,
are subject to royalty fees to patent holders. Many of these patents are
general enough such that they are unavoidable regardless of implementation
design.

Please visit MPEGLA at http://www.mpegla.com/ for more information about
licensing.

I suppose these are not valid to be includeed in a CCI package recipe? If not, can I delete this folder from the packaged package and implement extra logic so it can be downloaded and built from the user's side if they want it (kind of like how some linux packages work with downloading stuff at RPM install time or similar?)

conan-center-bot · 2023-10-05T03:37:08Z

Conan v1 pipeline ❌

Failure in build 9 (71caa9f2f6782ae4641c2a4569330ebee0980008):

simage/1.8.3:
CI failed to create some packages (All logs)

Logs for packageID 271601b91addbf8dd7a4aa9834568c5a4ef93c44:

[settings]
arch=x86_64
build_type=Release
compiler=apple-clang
compiler.libcxx=libc++
compiler.version=13.0
os=Macos
[options]
simage:shared=False

[...]
-- Looking for include file strings.h
-- Looking for include file strings.h - found
-- Looking for include file string.h
-- Looking for include file string.h - found
-- Looking for include file sys/stat.h
-- Looking for include file sys/stat.h - found
-- Looking for include file sys/types.h
-- Looking for include file sys/types.h - found
-- Looking for include file unistd.h
-- Looking for include file unistd.h - found
-- Looking for include file windows.h
-- Looking for include file windows.h - not found
-- Looking for 15 include files assert.h, ..., time.h
-- Looking for 15 include files assert.h, ..., time.h - found
-- Configuring done
-- Generating done
-- Build files have been written to: /Users/jenkins/w/prod-v1/bsr/20803/acbae/.conan/data/simage/1.8.3/_/_/build/271601b91addbf8dd7a4aa9834568c5a4ef93c44/build/Release
simage/1.8.3: CMake command: cmake --build "/Users/jenkins/w/prod-v1/bsr/20803/acbae/.conan/data/simage/1.8.3/_/_/build/271601b91addbf8dd7a4aa9834568c5a4ef93c44/build/Release" '--' '-j4'

----Running------
> cmake --build "/Users/jenkins/w/prod-v1/bsr/20803/acbae/.conan/data/simage/1.8.3/_/_/build/271601b91addbf8dd7a4aa9834568c5a4ef93c44/build/Release" '--' '-j4'
-----------------
[ 10%] Building C object CMakeFiles/simage.dir/src/resize.c.o
[ 10%] Building C object CMakeFiles/simage.dir/src/params.c.o
[ 10%] Building C object CMakeFiles/simage.dir/src/avi_encode.c.o
[ 10%] Building C object CMakeFiles/simage.dir/src/movie.c.o
[ 13%] Building C object CMakeFiles/simage.dir/src/simage.c.o
[ 16%] Building C object CMakeFiles/simage.dir/src/simage_avi.c.o
[ 18%] Building C object CMakeFiles/simage.dir/src/simage_eps.c.o
[ 21%] Building C object CMakeFiles/simage.dir/src/simage_jasper.c.o
[ 24%] Building C object CMakeFiles/simage.dir/src/simage_libsndfile.c.o
[ 27%] Building C object CMakeFiles/simage.dir/src/simage_oggvorbis_reader.c.o
simage/1.8.3: 
/Users/jenkins/w/prod-v1/bsr/20803/acbae/.conan/data/simage/1.8.3/_/_/build/271601b91addbf8dd7a4aa9834568c5a4ef93c44/src/src/simage_libsndfile.c:31:10: fatal error: 'sndfile.h' file not found
#include <sndfile.h>
         ^~~~~~~~~~~
1 error generated.
make[2]: *** [CMakeFiles/simage.dir/src/simage_libsndfile.c.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/simage.dir/all] Error 2
make: *** [all] Error 2
WARN: libpng/1.6.40: requirement zlib/[>=1.2.11 <2] overridden by simage/1.8.3 to zlib/1.2.13 
WARN: libtiff/4.6.0: requirement zlib/[>=1.2.11 <2] overridden by simage/1.8.3 to zlib/1.2.13 
simage/1.8.3: WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
simage/1.8.3: WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
simage/1.8.3: ERROR: Package '271601b91addbf8dd7a4aa9834568c5a4ef93c44' build failed
simage/1.8.3: WARN: Build folder /Users/jenkins/w/prod-v1/bsr/20803/acbae/.conan/data/simage/1.8.3/_/_/build/271601b91addbf8dd7a4aa9834568c5a4ef93c44/build/Release
ERROR: simage/1.8.3: Error in build() method, line 88
	cm.build()
	ConanException: Error 2 while executing cmake --build "/Users/jenkins/w/prod-v1/bsr/20803/acbae/.conan/data/simage/1.8.3/_/_/build/271601b91addbf8dd7a4aa9834568c5a4ef93c44/build/Release" '--' '-j4'

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

See details:

Failure in build 9 (71caa9f2f6782ae4641c2a4569330ebee0980008):

simage/1.8.3:
CI failed to create some packages (All logs)

Logs for packageID 97b5e2a4a1ec245fbd535274de26e4be86a05146:

[settings]
arch=x86_64
build_type=Release
compiler=gcc
compiler.cppstd=17
compiler.libcxx=libstdc++11
compiler.version=11
os=Linux
[options]
*/*:shared=False

[...]
libtiff/4.6.0: '6a65a96da33d3f9468135086deabd649a5814311': compiler.cppstd=23
libtiff/4.6.0: 'c6de83621cc54829d74bb78631aee8a58c38dee9': compiler.cppstd=gnu23
simage/1.8.3: Forced build from source
Requirements
    flac/1.4.2#5f7bfc8579a458e0a8bc36595c48106f:01fe6dbfc4b61d1b87e784b3d1d1803b74a38466#fd92015a2f892c072919ae8cb9b8ac08 - Download (conan-center)
    giflib/5.2.1#15033c544d771fa992cda180c0a1f8e0:20edc2d7ad41c415355b4fd4a1ea0419c72d7a95#6aef0ae700595f72964ef63f0ae31883 - Download (conan-center)
    jbig/20160605#2d29fa02aacd76902e0d2cbbc24631ef:d529a33abf04a079c05de395d985d1a67619d741#3f360af5e9436f349a68fa935680ed69 - Download (conan-center)
    libdeflate/1.18#3697b637656a9af04cabcbed50db9a7e:b647c43bfefae3f830561ca202b6cfd935b56205#e0a3cb9dcec4fffa76e000528d45bcf3 - Download (conan-center)
    libjpeg/9e#68269859e4325ddc3f995d1fd3fc9187:b647c43bfefae3f830561ca202b6cfd935b56205#56f2c1d03929a9c088a0994c1be8f0b8 - Download (conan-center)
    libmp3lame/3.100#44b12d19316eb2b223d98d3e75dae438:b647c43bfefae3f830561ca202b6cfd935b56205#82323ff769c108f6dfb11bab369186b1 - Download (conan-center)
    libpng/1.6.40#0337b7b87ac125307ed70fd064c31eea:52e28526917bc008177a3c5cf92ea21144c3ecd5 - Missing
    libsndfile/1.2.2#a5a93fb8f35fb5fba00552b2b3144db7:f908b994399fc4c25d1bb440f118f76f7ad7d99f#178a0d83d158492e6085bd3d65d91075 - Download (conan-center)
    libtiff/4.6.0#7b38b6577b722edb1c3dd9d01ac543ef:c8e091d122e92e6b94a7b875fb0b03e5b7d485fc - Missing
    libwebp/1.3.2#52f69c4a31c5cf033fdd9230d77a8e38:18f01a3f175888d5e3d128efe30c14773afadc83#e55816e5d48a3854454abdc32720bcad - Download (conan-center)
    mpg123/1.31.2#6cd0a70e992eca044b874e561db2c062:cd3321362832070e917e6965cd88f846ae82dcde#de442cbfe4e0a2b2c08cc77a28ff9897 - Download (conan-center)
    ogg/1.3.5#062626875f5c8c59f069f76f148098ef:b647c43bfefae3f830561ca202b6cfd935b56205#eb65b3e6ebe9c8667bc03f5638e4b3dd - Download (conan-center)
    opus/1.4#54631f551fc450783fb2df8cd63f80a2:4df585f63ebee00f46c117ab89b69f931e4b3d26#ea184fe0fbc1bb3e18c551df32da5002 - Download (conan-center)
    simage/1.8.3#8a0083eea4e92b2d362ef10258e9e3e5:97b5e2a4a1ec245fbd535274de26e4be86a05146 - Build
    vorbis/1.3.7#d936fd8c850f0c7c4021e24e55e6352c:a7b68b4d31174eb97fff2f0a35ab28a9c1fd5e42#c9e6f0ec6bcea5c7d7bbb33d2557bdc7 - Download (conan-center)
    xz_utils/5.4.4#f7cff24c0eadb6e51001dd86695e823d:b647c43bfefae3f830561ca202b6cfd935b56205#569498d63ba3ad9bdb8aa8ee09948a05 - Download (conan-center)
    zlib/1.2.13#97d5730b529b4224045fe7090592d4c1:b647c43bfefae3f830561ca202b6cfd935b56205#193bca86926abaf79971c774228e6249 - Download (conan-center)
    zstd/1.5.5#93372fe14bb7883bd4de82914e0a1841:668e7888fadd10ea273722487025fa96b62e2a52#293969474624c87af50d805e497561d1 - Download (conan-center)
Build requirements
Skipped binaries
    cmake/3.27.6, gnu-config/cci.20210814, meson/1.0.0, ninja/1.11.1, pkgconf/2.0.3, yasm/1.3.0

======== Installing packages ========
ERROR: Missing binary: libpng/1.6.40:52e28526917bc008177a3c5cf92ea21144c3ecd5
ERROR: Missing binary: libtiff/4.6.0:c8e091d122e92e6b94a7b875fb0b03e5b7d485fc

libpng/1.6.40: WARN: Can't find a 'libpng/1.6.40' package binary '52e28526917bc008177a3c5cf92ea21144c3ecd5' for the configuration:
[settings]
arch=x86_64
build_type=Release
compiler=gcc
compiler.version=11
os=Linux
[options]
api_prefix=
fPIC=True
shared=False
sse=True
[requires]
zlib/1.2.Z

ERROR: Missing prebuilt package for 'libpng/1.6.40', 'libtiff/4.6.0'
Check the available packages using 'conan list libpng/1.6.40:* -r=remote'
or try to build locally from sources using the '--build=libpng/1.6.40 --build=libtiff/4.6.0' argument

More Info at 'https://docs.conan.io/2/knowledge/faq.html#error-missing-prebuilt-package'

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

github-actions · 2024-09-08T06:37:57Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions · 2024-10-08T06:40:44Z

This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions.

weatherhead99 added 4 commits September 29, 2023 01:21

recipe for simage library, building works so far

b7baf01

basic package test done

9af08e2

more metadata in conanfile

3ca0692

add missing config.yml

24d993e

prince-chrismc mentioned this pull request Sep 29, 2023

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

weatherhead99 added 2 commits September 29, 2023 05:27

rename options to follow CCI conventions

95c720f

fix yaml file lint

53bce7e

conan-center-bot added the Failed label Sep 29, 2023

This comment has been minimized.

Sign in to view

add missing topic attribute

543d05e

This comment has been minimized.

Sign in to view

fix qt option checking

b4b4eb7

This comment has been minimized.

Sign in to view

copy licenses

63fdc1c

This comment has been minimized.

Sign in to view

valgur suggested changes Oct 2, 2023

View reviewed changes

weatherhead99 and others added 2 commits October 5, 2023 02:22

Update recipes/simage/all/conanfile.py

9922b48

you can use pathlib.Path objects directly Co-authored-by: Martin Valgur <martin.valgur@gmail.com>

Update recipes/simage/all/conanfile.py

71caa9f

remove properties that will be correct defaults anyway Co-authored-by: Martin Valgur <martin.valgur@gmail.com>

AbrilRBS self-assigned this Oct 10, 2023

perseoGI self-assigned this Jun 14, 2024

ErniGH mentioned this pull request Jun 14, 2024

Prioritization of new recipe PRs #24327

Open

github-actions bot added the stale label Sep 8, 2024

github-actions bot closed this Oct 8, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

new library: Simage #20197

new library: Simage #20197

weatherhead99 commented Sep 29, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

valgur left a comment •

edited

Loading

valgur Oct 2, 2023

weatherhead99 Oct 5, 2023

valgur Oct 2, 2023

weatherhead99 Oct 5, 2023

weatherhead99 commented Oct 5, 2023

conan-center-bot commented Oct 5, 2023

github-actions bot commented Sep 8, 2024

github-actions bot commented Oct 8, 2024

new library: Simage #20197

new library: Simage #20197

Conversation

weatherhead99 commented Sep 29, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

valgur left a comment • edited Loading

Choose a reason for hiding this comment

valgur Oct 2, 2023

Choose a reason for hiding this comment

weatherhead99 Oct 5, 2023

Choose a reason for hiding this comment

valgur Oct 2, 2023

Choose a reason for hiding this comment

weatherhead99 Oct 5, 2023

Choose a reason for hiding this comment

weatherhead99 commented Oct 5, 2023

conan-center-bot commented Oct 5, 2023

Conan v1 pipeline ❌

Conan v2 pipeline ❌

github-actions bot commented Sep 8, 2024

github-actions bot commented Oct 8, 2024

valgur left a comment •

edited

Loading