-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pipes: move checks to validate()
instead of configure()
and add msvc min version
#20369
base: master
Are you sure you want to change the base?
Conversation
I've won the race to post the build results against the bot, here are the v2 errors https://c3i.jfrog.io/c3i/misc-v2/summary.html?json=https://c3i.jfrog.io/c3i/misc-v2/logs/pr/20369/1-linux-gcc/pipes/1.0.0//summary.json |
I could restore hardcoded CMAKE_CXX_STANDARD 14 in test package just to pass pipeline, but it would be a lie because compiler.cppstd would not be honored in test package. It seems that this header-only lib doesn't work with C++17, it's bad. |
This comment has been minimized.
This comment has been minimized.
Oh that's a pitty that it can't compile in C++17 - I'm ok having a check for max_cppstd in the validate too even if it then only creates binaries for msvc |
Conan v1 pipeline ❌Warning Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement. Failure in build 1 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. Conan v2 pipeline ❌
The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping Failure in build 1 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
Specify library name and version: lib/1.0