qt6: do not define default_options for modules #20587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Beep Boop! This pull request is making changes to 'recipes/qt//'. 👋 @ericLemanissier @jwillikers @MartinDelille you might be interested. 😉 |
This was referenced Oct 16, 2023
closes conan-io#20565 fixes conan-io#20383 also, be a little more strict with options usage
|
@matheusgomes28 this should hopefully be a more general solution than #20565. Can you please try it and confirm ? |
|
@ericLemanissier I'll try a clean build after work today. I see you haven't yet changed the module dependency lists on the top of the file. Maybe I can push that later on. |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Do you mean the addition of |
jwillikers
approved these changes
Oct 16, 2023
@ericLemanissier I assumed it was necessary as the dependency is declared in And as described in #20383 , you cannot build |
|
Not always, it can be used only at compile time |
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 77e85feqt/6.5.1@#5f5b75866175a9b71b6a248eb48f8ba7qt/6.3.2@#b55ba1cbd9be9b4edecd70041fc88224qt/6.6.0@#80fe22d598639d5ee1e46f6cc7b64923qt/6.4.2@#aa7d60f41bd3d1af6b1aee49c68820b0qt/6.5.3@#4c09fd8733459e6959aeded9e7b2f0faqt/6.5.0@#a3639ec296a79cfab87dab813895f1a5qt/6.5.2@#4bbca01ce3e8de6d8e456fbadce2c3f1 |
|
The build is now finished. You can take a look at the results here |
|
|
||
| # enable all modules which are | ||
| # - required by a module explicitely enabled by the consumer |
There was a problem hiding this comment.
Suggested change
| # - required by a module explicitely enabled by the consumer | |
| # - required by a module explicitly enabled by the consumer |
| _enablemodule(module) | ||
|
|
||
| # disable all modules which are: | ||
| # - not explicitely enabled by the consumer and |
There was a problem hiding this comment.
Suggested change
| # - not explicitely enabled by the consumer and | |
| # - not explicitly enabled by the consumer and |
@ericLemanissier Yes, you can have build dependency & also runtime dependencies... The lines in question (calling the Furthermore, I have tried the new recipe just now (replacing the cached one with the recipe in this PR). Seems to work fine on |
|
@matheusgomes28 OK, so I understand the misunderstanding: the |
This comment has been minimized.
This comment has been minimized.
MartinDelille
approved these changes
Oct 21, 2023
MartinDelille
approved these changes
Oct 25, 2023
danimtb
approved these changes
Oct 26, 2023
jwillikers
approved these changes
Oct 26, 2023
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 5 (
Conan v2 pipeline ✔️
All green in build 4 (
|
Hooks produced the following warnings for commit 77e85feqt/6.6.0@#eb0db889522a0ac3b7c8b40170af4b73qt/6.5.3@#6466cb0c69b3a23de2e015cc938e3ddcqt/6.5.2@#ec61659460d2009e599c60cc3da2e74dqt/6.5.1@#eea6338e7b999306c03ddb87b1e4c2b1qt/6.4.2@#3f706815965621bc5fe686362c646545qt/6.3.2@#2f391b655727031105beb7e6536c6e8dqt/6.5.0@#169dece636d2a4fb2919b2e6c5a5c001 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #20565
fixes #20383
Specify library name and version: qt/6.*