userver: add unspecified version #20712

Jihadist · 2023-10-20T19:42:10Z

Specify library name and version: userver/cci.20231018

I understand recipe looks like a bit bloated and test package too, but both of them require a lot of thirdparty libraries and specific options so it's nontrivial task.

I've read the contributing guidelines.
I've used a recent Conan client version close to the currently deployed.
I've tried at least one configuration locally with the conan-center hook activated.

Jihadist · 2023-10-20T20:58:10Z

Waiting for #19971 in order to resolve version conflict.

AbrilRBS · 2023-10-23T12:38:44Z

Retriggered again, linked PR has now been merged

Jihadist · 2023-10-24T12:40:12Z

Waiting for #20091

Jihadist · 2023-10-24T12:41:55Z

@RubenRBS is there any way to build mogo-c-driver with_sasl=cyrus?

AbrilRBS · 2023-10-26T15:45:44Z

@RubenRBS is there any way to build mogo-c-driver with_sasl=cyrus?

@Jihadist for cci no, it's not currently possible to build configurations other than the defaul ones defined in the recipe - this is something we're currently looking into allowing, but for now checks should be made in the validate method to ensure that the expected options have been activated by the user. This means that no binaries will be made for that configuration, so please do provide local logs of your builds when testing them, as it makes reviewing and future maintenance way easier :)

AbrilRBS

Thanks a lot for your contribution @Jihadist - we really appreciate it.

This is a first review (Thanks for your patience while I got around to it!), and I have some comments and suggestions. My biggest doubt right now is about the need for a non default option on the dependency, which right now generates no binaries here, happy to discuss it further

recipes/userver/all/conanfile.py

github-actions · 2024-02-19T13:00:14Z

Hooks produced the following warnings for commit d061d1d

userver/cci.20240219@#c5a0d7390d2a66f7ee41123a52a3f25c

post_package_info(): WARN: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] The *.cmake files have to be placed in a folder declared as `cpp_info.builddirs`. Currently folders declared: {'/home/conan/w/prod-v1/bsr/108650/bdbda/.conan/data/userver/cci.20240219/_/_/package/d8f57b86b628c8981c03bc3fed1fba16c77c9cd8/'}
post_package_info(): WARN: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] Found files: ./lib/cmake/conan_helper.cmake

github-actions · 2024-02-19T13:23:17Z

Hooks produced the following warnings for commit a50b380

userver/cci.20240219@#c5a0d7390d2a66f7ee41123a52a3f25c

post_package_info(): WARN: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] The *.cmake files have to be placed in a folder declared as `cpp_info.builddirs`. Currently folders declared: {'/home/conan/w/prod-v1/bsr/108664/bbebb/.conan/data/userver/cci.20240219/_/_/package/d8f57b86b628c8981c03bc3fed1fba16c77c9cd8/'}
post_package_info(): WARN: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] Found files: ./lib/cmake/conan_helper.cmake

disable DWCAS

github-actions · 2024-02-19T14:00:22Z

Hooks produced the following warnings for commit d50f904

userver/cci.20240219@#c16fae17b9ce7248dbdcd46316f3396a

post_package_info(): WARN: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] The *.cmake files have to be placed in a folder declared as `cpp_info.builddirs`. Currently folders declared: {'/home/conan/w/prod-v1/bsr/108683/dbfaf/.conan/data/userver/cci.20240219/_/_/package/d8f57b86b628c8981c03bc3fed1fba16c77c9cd8/'}
post_package_info(): WARN: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] Found files: ./lib/cmake/conan_helper.cmake

github-actions · 2024-02-19T14:45:26Z

Hooks produced the following warnings for commit 07f23e8

userver/cci.20240219@#a45b62ac9dbfc1add5f719aff4dafc2c

post_package_info(): WARN: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] The *.cmake files have to be placed in a folder declared as `cpp_info.builddirs`. Currently folders declared: {'/home/conan/w/prod-v1/bsr/108747/abced/.conan/data/userver/cci.20240219/_/_/package/d8f57b86b628c8981c03bc3fed1fba16c77c9cd8/'}
post_package_info(): WARN: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] Found files: ./lib/cmake/conan_helper.cmake

github-actions · 2024-02-19T15:10:13Z

Hooks produced the following warnings for commit d6abf62

userver/cci.20240219@#078e749cd0ec6cf84f43f0df37c307e7

post_package_info(): WARN: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] The *.cmake files have to be placed in a folder declared as `cpp_info.builddirs`. Currently folders declared: {'/home/conan/w/prod-v1/bsr/108766/acbda/.conan/data/userver/cci.20240219/_/_/package/d8f57b86b628c8981c03bc3fed1fba16c77c9cd8/'}
post_package_info(): WARN: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] Found files: ./lib/cmake/conan_helper.cmake

conan-center-bot · 2024-02-19T18:58:13Z

Conan v1 pipeline ❌

Failure in build 33 (059422cbcd149e95ebb30a327736b5b4940721db):

userver/cci.20240219:
CI failed to create some packages (All logs)

Logs for packageID d8f57b86b628c8981c03bc3fed1fba16c77c9cd8:

[settings]
arch=x86_64
build_type=Release
compiler=gcc
compiler.libcxx=libstdc++11
compiler.version=9
os=Linux

[...]
-- Conan: Target declared 'concurrentqueue::concurrentqueue'
-- Conan: Target declared 'yaml-cpp::yaml-cpp'
-- Conan: Target declared 'libev::libev'
-- Conan: Target declared 'http_parser::http_parser'
-- Conan: Component target declared 'libnghttp2::nghttp2'
-- Conan: Target declared 'libnghttp2::libnghttp2'
-- Conan: Component target declared 'CURL::libcurl'
-- Conan: Component target declared 'OpenSSL::Crypto'
-- Conan: Component target declared 'OpenSSL::SSL'
-- Conan: Target declared 'openssl::openssl'
-- Conan: Including build module from '/home/conan/w/prod-v1/bsr/108868/dbbff/.conan/data/openssl/3.2.1/_/_/package/a16868cdc757ddd2bddffb90f6893124d3bb4c42/lib/cmake/conan-official-openssl-variables.cmake'
-- Conan: Component target declared 'cryptopp::cryptopp'
-- Conan: Component target declared 'c-ares::cares'
-- Conan: Target declared 'rapidjson'
-- Conan: Including build module from '/home/conan/w/prod-v1/bsr/108868/dbbff/.conan/data/userver/cci.20240219/_/_/package/d8f57b86b628c8981c03bc3fed1fba16c77c9cd8/lib/cmake/conan_helper.cmake'
-- Found Python: /opt/pyenv/versions/3.7.13/bin/python3.7 (found version "3.7.13") found components: Interpreter Development Development.Module Development.Embed 
-- Configuring done
-- Generating done
-- Build files have been written to: /home/conan/w/prod-v1/bsr/cci-b77d90d9/recipes/userver/all/test_package/build/Release
userver/cci.20240219 (test package): CMake command: cmake --build "/home/conan/w/prod-v1/bsr/cci-b77d90d9/recipes/userver/all/test_package/build/Release" '--' '-j3'

----Running------
> cmake --build "/home/conan/w/prod-v1/bsr/cci-b77d90d9/recipes/userver/all/test_package/build/Release" '--' '-j3'
-----------------
Scanning dependencies of target PackageTest_objs
[ 20%] Building CXX object CMakeFiles/PackageTest_objs.dir/hello.cpp.o
[ 20%] Built target PackageTest_objs
Scanning dependencies of target PackageTest_universal
[ 40%] Building CXX object CMakeFiles/PackageTest_universal.dir/test_universal.cpp.o
Scanning dependencies of target PackageTest_core
[ 60%] Building CXX object CMakeFiles/PackageTest_core.dir/test_core.cpp.o
[ 80%] Linking CXX executable PackageTest_universal
[100%] Linking CXX executable PackageTest_core
[100%] Built target PackageTest_universal
[100%] Built target PackageTest_core
userver/cci.20240219 (test package): Running test()

----Running------
> . "/home/conan/w/prod-v1/bsr/cci-b77d90d9/recipes/userver/all/test_package/build/Release/generators/conanrun.sh" && ./PackageTest_core
-----------------
15
WARN: boost/1.79.0: requirement zlib/[>=1.2.11 <2] overridden by userver/cci.20240219 to zlib/1.3.1 
WARN: libcurl/7.88.1: requirement openssl/[>=1.1 <4] overridden by userver/cci.20240219 to openssl/3.2.1 
WARN: libcurl/7.88.1: requirement zlib/[>=1.2.11 <2] overridden by userver/cci.20240219 to zlib/1.3.1 
WARN: openssl/3.2.1: requirement zlib/[>=1.2.11 <2] overridden by libcurl/7.88.1 to zlib/1.3.1 
userver/cci.20240219 (test package): WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
userver/cci.20240219 (test package): WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
ERROR: userver/cci.20240219 (test package): Error in test() method, line 32
	if self.dependencies[self.tested_reference_str].options.with_utest:
	AttributeError: 'NoneType' object has no attribute 'dependencies'

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 33 (059422cbcd149e95ebb30a327736b5b4940721db):

userver/cci.20240219:
All packages built successfully! (All logs)

github-actions · 2024-02-19T18:58:23Z

Hooks produced the following warnings for commit 059422c

userver/cci.20240219@#778ffbba5410f4380729522e6d28ca26

post_package_info(): WARN: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] The *.cmake files have to be placed in a folder declared as `cpp_info.builddirs`. Currently folders declared: {'/home/conan/w/prod-v1/bsr/108868/dbbff/.conan/data/userver/cci.20240219/_/_/package/d8f57b86b628c8981c03bc3fed1fba16c77c9cd8/'}
post_package_info(): WARN: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] Found files: ./lib/cmake/conan_helper.cmake

Jihadist · 2024-02-19T19:58:39Z

I disabled all additional modules now. When (or if ) pr is merged, I'll enable modules one by one. Some can work in this recipe without changes, some not. Everyone can try to build recipe locally for another platforms with additional modules, I left tests for that purposes.

Jihadist · 2024-04-15T19:27:51Z

@RubenRBS can you review this?

AbrilRBS · 2024-04-15T19:49:03Z

Hi! Thanks for the ping, sorry that this one got lost among the rest of PRs: Note that opening and closing PRs makes Github Projects set the status to "Done", which we don't often check, so it's easier that the PR gets delayed if you do that :)

if you ever need to rebuild, pressing the "Update branch" button usually works best!

AbrilRBS

Ok, after going again thru this, it looks mostly good, but I'll ask someone else from the team to check a few extra things tomororw, sorry for such a long delay, thanks a lot for your patience :)

AbrilRBS · 2024-04-15T19:51:25Z

recipes/userver/all/conanfile.py

+    default_options = {
+        'fPIC': True,
+        'lto': True,
+        'with_jemalloc': False, # Disabled dy default due to jemalloc recipe does not support Conan v2


Jemalloc is now available in Conan 2, feel free to make this True by default if upstream following https://github.com/userver-framework/userver/blob/13ca039791f9dbaa9da36e3e55e86451516dfa7f/CMakeLists.txt#L96 :)

I know but I fixed this recipe so many tries that now I have no desire to do it again

Jihadist · 2024-04-16T17:27:58Z

Hi! Thanks for the ping, sorry that this one got lost among the rest of PRs: Note that opening and closing PRs makes Github Projects set the status to "Done", which we don't often check, so it's easier that the PR gets delayed if you do that :)

if you ever need to rebuild, pressing the "Update branch" button usually works best!

Oh, now I understand why my other prs have been waiting review for months

conan-center-bot added Failed Missing dependencies Build failed due missing dependencies in Conan Center labels Oct 20, 2023

This comment has been minimized.

Sign in to view

Jihadist force-pushed the userver branch from 025e616 to 60e68fe Compare October 20, 2023 20:17

conan-center-bot added Version conflict There is a version conflict when solving the dependencies graph and removed Missing dependencies Build failed due missing dependencies in Conan Center labels Oct 20, 2023

This comment has been minimized.

Sign in to view

add userver recipe

1f63b03

Jihadist force-pushed the userver branch from 60e68fe to 1f63b03 Compare October 20, 2023 20:28

conan-center-bot added the Missing dependencies Build failed due missing dependencies in Conan Center label Oct 20, 2023

This comment has been minimized.

Sign in to view

Jihadist mentioned this pull request Oct 20, 2023

Add userver to conan-center userver-framework/userver#384

Open

Merge branch 'master' into userver

16cffa1

AbrilRBS self-assigned this Oct 23, 2023

AbrilRBS removed Missing dependencies Build failed due missing dependencies in Conan Center Version conflict There is a version conflict when solving the dependencies graph labels Oct 23, 2023

conan-center-bot added Missing dependencies Build failed due missing dependencies in Conan Center Version conflict There is a version conflict when solving the dependencies graph labels Oct 23, 2023

This comment has been minimized.

Sign in to view

bump deps

23201d8

This comment has been minimized.

Sign in to view

AbrilRBS reviewed Oct 26, 2023

View reviewed changes

AbrilRBS removed the Missing dependencies Build failed due missing dependencies in Conan Center label Oct 26, 2023

Jihadist added 2 commits October 31, 2023 19:16

review fixes

07d041f

disable mongo, optional conan tests

c87b55f

Jihadist force-pushed the userver branch from c243d1f to 2075047 Compare February 19, 2024 12:31

This comment has been minimized.

Sign in to view

Jihadist added 2 commits February 19, 2024 15:43

Update config.yml

662e214

Update CMakeLists.txt

d061d1d

This comment has been minimized.

Sign in to view

Fix testsuite test

a50b380

This comment has been minimized.

Sign in to view

Update conanfile.py

d50f904

disable DWCAS

This comment has been minimized.

Sign in to view

Update conanfile.py

07f23e8

This comment has been minimized.

Sign in to view

another attempt to disable dwcas

d6abf62

This comment has been minimized.

Sign in to view

Disable cross

059422c

Jihadist requested a review from AbrilRBS February 19, 2024 19:03

AbrilRBS reviewed Apr 15, 2024

View reviewed changes

Jihadist mentioned this pull request Jun 1, 2024

[question] Pr review is so slow #24186

Open

Jihadist mentioned this pull request Jun 9, 2024

Migrate Conan to 2.0+ userver-framework/userver#540

Open

ErniGH mentioned this pull request Jun 14, 2024

Prioritization of new recipe PRs #24327

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

userver: add unspecified version #20712

userver: add unspecified version #20712

Jihadist commented Oct 20, 2023 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Jihadist commented Oct 20, 2023

AbrilRBS commented Oct 23, 2023

This comment has been minimized.

This comment has been minimized.

Jihadist commented Oct 24, 2023

Jihadist commented Oct 24, 2023

AbrilRBS commented Oct 26, 2023

AbrilRBS left a comment

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Feb 19, 2024

This comment has been minimized.

github-actions bot commented Feb 19, 2024

This comment has been minimized.

github-actions bot commented Feb 19, 2024

This comment has been minimized.

github-actions bot commented Feb 19, 2024

This comment has been minimized.

github-actions bot commented Feb 19, 2024

conan-center-bot commented Feb 19, 2024

github-actions bot commented Feb 19, 2024

Jihadist commented Feb 19, 2024

Jihadist commented Apr 15, 2024

AbrilRBS commented Apr 15, 2024

AbrilRBS left a comment

AbrilRBS Apr 15, 2024

Jihadist Apr 16, 2024

Jihadist commented Apr 16, 2024

userver: add unspecified version #20712

Are you sure you want to change the base?

userver: add unspecified version #20712

Conversation

Jihadist commented Oct 20, 2023 • edited Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Jihadist commented Oct 20, 2023

AbrilRBS commented Oct 23, 2023

This comment has been minimized.

This comment has been minimized.

Jihadist commented Oct 24, 2023

Jihadist commented Oct 24, 2023

AbrilRBS commented Oct 26, 2023

AbrilRBS left a comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Feb 19, 2024

This comment has been minimized.

github-actions bot commented Feb 19, 2024

This comment has been minimized.

github-actions bot commented Feb 19, 2024

This comment has been minimized.

github-actions bot commented Feb 19, 2024

This comment has been minimized.

github-actions bot commented Feb 19, 2024

conan-center-bot commented Feb 19, 2024

Conan v1 pipeline ❌

Conan v2 pipeline ✔️

github-actions bot commented Feb 19, 2024

Jihadist commented Feb 19, 2024

Jihadist commented Apr 15, 2024

AbrilRBS commented Apr 15, 2024

AbrilRBS left a comment

Choose a reason for hiding this comment

AbrilRBS Apr 15, 2024

Choose a reason for hiding this comment

Jihadist Apr 16, 2024

Choose a reason for hiding this comment

Jihadist commented Apr 16, 2024

Jihadist commented Oct 20, 2023 •

edited

Loading