-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opencascade: fix compilation when with_tbb=True #20781
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for including the patch_sources, they are super useful for future maintenance.
Could you please post your local build logs for the case they fix it? While we run them locally too (As the CCI's CI won't), we prefer to have also the contributor's logs to ensure it's working in a variety of machines - just in case, and it aids with future maintenance of the recipe if we log them in the PRs :)
This comment has been minimized.
This comment has been minimized.
Hi @RubenRBS Click to expand log
|
a3ccb6e
to
03df7b9
Compare
Spoilers for the v2 failure (I checked before the bot got time to show it) https://c3i.jfrog.io/c3i/misc-v2/summary.html?json=https://c3i.jfrog.io/c3i/misc-v2/logs/pr/20781/3-linux-gcc/opencascade/7.6.2//summary.json It's weird because locally this configuration builds fine for me |
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 03df7b9opencascade/7.6.2@#5d4d67872491d89bdae47e4be0c5e9ab
opencascade/7.6.0@#548a55a9d15770377399ed96f3b756a4
opencascade/7.5.0@#4aeb250a323f940c1f6a4c3a8e4b192e
|
I tried on WSL Rocky 8 with gcc-11 and shared=True --> the package build locally, too. I do not understand the error on conan2 pipeline :-/ Click to expand log
|
03df7b9
to
c902a0a
Compare
This comment has been minimized.
This comment has been minimized.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
c902a0a
to
2ea30e6
Compare
Conan v1 pipeline ✔️All green in build 5 (
Conan v2 pipeline ❌
The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping See details:Failure in build 6 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
Library name and version: opencascade/7.6.2
This adds two patches from upstream, making possible to use onetbb >= 2021 with opencascade 7.6.2
fixes #20776