Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

joltphysics: add version 4.0.2 #21080

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Conversation

toge
Copy link
Contributor

@toge toge commented Nov 12, 2023

Specify library name and version: joltphysics/4.0.2


@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

Copy link
Contributor

Hooks produced the following warnings for commit 894dcb2
joltphysics/4.0.0@#f7b3aa5b7490df47a68b2bc0c18e525c
post_package_info(): WARN: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] The *.cmake files have to be placed in a folder declared as `cpp_info.builddirs`. Currently folders declared: {'/home/conan/w/prod-v1/bsr/49736/deaad/.conan/data/joltphysics/4.0.0/_/_/package/9fc3b08bb12e11168e6e921fec76acd988f4b3fb/'}
post_package_info(): WARN: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] Found files: ./include/Jolt/Jolt.cmake

@conan-center-bot

This comment has been minimized.

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Maybe spotted a typo?

@@ -133,6 +133,8 @@ def generate(self):
tc.variables["JPH_PROFILE_ENABLED"] = self.options.profile
if Version(self.version) >= "3.0.0":
tc.variables["ENABLE_ALL_WARNINGS"] = False
if Version(self.version) >= "3.0.0":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.0.0? Or 4.0.0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RubenRBS
INTERPROCEDURAL_OPTIMIZATION has been introduced since 3.0.0.
I merged these version checks.
Thank you for your review!

@AbrilRBS AbrilRBS self-assigned this Nov 23, 2023
@toge toge changed the title joltphysics: add version 4.0.0 joltphysics: add version 4.0.1 Nov 25, 2023
@conan-center-bot

This comment has been minimized.

Copy link
Contributor

Hooks produced the following warnings for commit 5b0d39e
joltphysics/4.0.1@#5c21c1d6317691f0aa4fc8bc491689ff
post_package_info(): WARN: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] The *.cmake files have to be placed in a folder declared as `cpp_info.builddirs`. Currently folders declared: {'/home/conan/w/prod-v1/bsr/59571/dcddb/.conan/data/joltphysics/4.0.1/_/_/package/229e1ebc9c5a323db91ee6216d64905f92d1256f/'}
post_package_info(): WARN: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] Found files: ./include/Jolt/Jolt.cmake
post_package_info(): WARN: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] The *.cmake files have to be placed in a folder declared as `cpp_info.builddirs`. Currently folders declared: {'/home/conan/w/prod-v1/bsr/59571/aabeb/.conan/data/joltphysics/4.0.1/_/_/package/1f94749c2c67118073d7b9e3eff54a45ea8703de/'}
post_package_info(): WARN: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] The *.cmake files have to be placed in a folder declared as `cpp_info.builddirs`. Currently folders declared: {'/home/conan/w/prod-v1/bsr/59571/ecbbd/.conan/data/joltphysics/4.0.1/_/_/package/3eaae933d7a6f1c8b967a860e68a8632ec1b09a0/'}
post_package_info(): WARN: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] The *.cmake files have to be placed in a folder declared as `cpp_info.builddirs`. Currently folders declared: {'/home/conan/w/prod-v1/bsr/59571/fdfea/.conan/data/joltphysics/4.0.1/_/_/package/883bfa34e2a84ff0136efc868fff2cdf75d6d61c/'}
post_package_info(): WARN: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] The *.cmake files have to be placed in a folder declared as `cpp_info.builddirs`. Currently folders declared: {'/home/conan/w/prod-v1/bsr/59571/dcfbd/.conan/data/joltphysics/4.0.1/_/_/package/e01943e562b53211aaf1d581a75ceebb3f55d7b8/'}
post_package_info(): WARN: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] The *.cmake files have to be placed in a folder declared as `cpp_info.builddirs`. Currently folders declared: {'/home/conan/w/prod-v1/bsr/59571/dceec/.conan/data/joltphysics/4.0.1/_/_/package/2e605a9bdd821b78183e6793f1af44215e06447f/'}

@conan-center-bot

This comment has been minimized.

@toge toge changed the title joltphysics: add version 4.0.1 joltphysics: add version 4.0.2 Jan 7, 2024
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ❌

Failure in build 10 (91c48ea552a00919ccf8739edf27a6c094eb134e):

  • joltphysics/3.0.1:
    Didn't run or was cancelled before finishing

  • joltphysics/4.0.2:
    CI failed to create some packages (All logs)

    Logs for packageID dda52791cd8b1befae9fa9bc68678cbd0c72d7df:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=apple-clang
    compiler.libcxx=libc++
    compiler.version=13.0
    os=Macos
    [options]
    joltphysics:shared=True
    
    [...]
    /Users/jenkins/w/prod-v1/bsr/88923/dabce/.conan/data/joltphysics/4.0.2/_/_/build/dda52791cd8b1befae9fa9bc68678cbd0c72d7df/src/Build/../Jolt/Math/Real.h:10:1: warning: unknown warning group '-Wdeprecated-copy-with-dtor', ignored [-Wunknown-warning-option]
    JPH_NAMESPACE_BEGIN
    ^
    /Users/jenkins/w/prod-v1/bsr/88923/dabce/.conan/data/joltphysics/4.0.2/_/_/build/dda52791cd8b1befae9fa9bc68678cbd0c72d7df/src/Build/../Jolt/Core/Core.h:350:2: note: expanded from macro 'JPH_NAMESPACE_BEGIN'
            JPH_SUPPRESS_WARNINGS                                                                                                                                           \
            ^
    /Users/jenkins/w/prod-v1/bsr/88923/dabce/.conan/data/joltphysics/4.0.2/_/_/build/dda52791cd8b1befae9fa9bc68678cbd0c72d7df/src/Build/../Jolt/Core/Core.h:290:2: note: expanded from macro 'JPH_SUPPRESS_WARNINGS'
            JPH_CLANG_13_PLUS_SUPPRESS_WARNING("-Wdeprecated-copy-with-dtor")                                                       \
            ^
    /Users/jenkins/w/prod-v1/bsr/88923/dabce/.conan/data/joltphysics/4.0.2/_/_/build/dda52791cd8b1befae9fa9bc68678cbd0c72d7df/src/Build/../Jolt/Core/Core.h:231:48: note: expanded from macro 'JPH_CLANG_13_PLUS_SUPPRESS_WARNING'
            #define JPH_CLANG_13_PLUS_SUPPRESS_WARNING(w) JPH_CLANG_SUPPRESS_WARNING(w)
                                                          ^
    /Users/jenkins/w/prod-v1/bsr/88923/dabce/.conan/data/joltphysics/4.0.2/_/_/build/dda52791cd8b1befae9fa9bc68678cbd0c72d7df/src/Build/../Jolt/Core/Core.h:229:39: note: expanded from macro 'JPH_CLANG_SUPPRESS_WARNING'
    #define JPH_CLANG_SUPPRESS_WARNING(w)   JPH_PRAGMA(clang diagnostic ignored w)
                                            ^
    /Users/jenkins/w/prod-v1/bsr/88923/dabce/.conan/data/joltphysics/4.0.2/_/_/build/dda52791cd8b1befae9fa9bc68678cbd0c72d7df/src/Build/../Jolt/Core/Core.h:226:27: note: expanded from macro 'JPH_PRAGMA'
    #define JPH_PRAGMA(x)                                   _Pragma(#x)
                                                            ^
    <scratch space>:48:27: note: expanded from here
     clang diagnostic ignored "-Wdeprecated-copy-with-dtor"
                              ^
    /Users/jenkins/w/prod-v1/bsr/88923/dabce/.conan/data/joltphysics/4.0.2/_/_/build/dda52791cd8b1befae9fa9bc68678cbd0c72d7df/src/Jolt/Core/Memory.cpp:12:1: warning: unknown warning group '-Wdeprecated-copy-with-dtor', ignored [-Wunknown-warning-option]
    JPH_NAMESPACE_BEGIN
    ^
    /Users/jenkins/w/prod-v1/bsr/88923/dabce/.conan/data/joltphysics/4.0.2/_/_/build/dda52791cd8b1befae9fa9bc68678cbd0c72d7df/src/Build/../Jolt/Core/Core.h:350:2: note: expanded from macro 'JPH_NAMESPACE_BEGIN'
            JPH_SUPPRESS_WARNINGS                                                                                                                                           \
            ^
    /Users/jenkins/w/prod-v1/bsr/88923/dabce/.conan/data/joltphysics/4.0.2/_/_/build/dda52791cd8b1befae9fa9bc68678cbd0c72d7df/src/Build/../Jolt/Core/Core.h:290:2: note: expanded from macro 'JPH_SUPPRESS_WARNINGS'
            JPH_CLANG_13_PLUS_SUPPRESS_WARNING("-Wdeprecated-copy-with-dtor")                                                       \
            ^
    /Users/jenkins/w/prod-v1/bsr/88923/dabce/.conan/data/joltphysics/4.0.2/_/_/build/dda52791cd8b1befae9fa9bc68678cbd0c72d7df/src/Build/../Jolt/Core/Core.h:231:48: note: expanded from macro 'JPH_CLANG_13_PLUS_SUPPRESS_WARNING'
            #define JPH_CLANG_13_PLUS_SUPPRESS_WARNING(w) JPH_CLANG_SUPPRESS_WARNING(w)
                                                          ^
    /Users/jenkins/w/prod-v1/bsr/88923/dabce/.conan/data/joltphysics/4.0.2/_/_/build/dda52791cd8b1befae9fa9bc68678cbd0c72d7df/src/Build/../Jolt/Core/Core.h:229:39: note: expanded from macro 'JPH_CLANG_SUPPRESS_WARNING'
    #define JPH_CLANG_SUPPRESS_WARNING(w)   JPH_PRAGMA(clang diagnostic ignored w)
                                            ^
    /Users/jenkins/w/prod-v1/bsr/88923/dabce/.conan/data/joltphysics/4.0.2/_/_/build/dda52791cd8b1befae9fa9bc68678cbd0c72d7df/src/Build/../Jolt/Core/Core.h:226:27: note: expanded from macro 'JPH_PRAGMA'
    #define JPH_PRAGMA(x)                                   _Pragma(#x)
                                                            ^
    <scratch space>:9:27: note: expanded from here
     clang diagnostic ignored "-Wdeprecated-copy-with-dtor"
                              ^
    32 warnings generated.
    make[1]: *** [CMakeFiles/Jolt.dir/all] Error 2
    make: *** [all] Error 2
    joltphysics/4.0.2: ERROR: Package 'dda52791cd8b1befae9fa9bc68678cbd0c72d7df' build failed
    joltphysics/4.0.2: WARN: Build folder /Users/jenkins/w/prod-v1/bsr/88923/dabce/.conan/data/joltphysics/4.0.2/_/_/build/dda52791cd8b1befae9fa9bc68678cbd0c72d7df/build/Release
    ERROR: joltphysics/4.0.2: Error in build() method, line 148
    	cmake.build()
    	ConanException: Error 2 while executing cmake --build "/Users/jenkins/w/prod-v1/bsr/88923/dabce/.conan/data/joltphysics/4.0.2/_/_/build/dda52791cd8b1befae9fa9bc68678cbd0c72d7df/build/Release" '--' '-j8'
    
  • joltphysics/2.0.1:
    Didn't run or was cancelled before finishing


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.


Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

See details:

Failure in build 10 (91c48ea552a00919ccf8739edf27a6c094eb134e):

  • joltphysics/4.0.2:
    CI failed to create some packages (All logs)

    Logs for packageID 3626a272105409c9ee104cdfe382fb6cf1570a1a:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=apple-clang
    compiler.cppstd=17
    compiler.libcxx=libc++
    compiler.version=13
    os=Macos
    [options]
    */*:shared=True
    
    [...]
                              ^
    /Users/jenkins/w/prod-v2/bsr@3/74271/dcefc/p/b/joltpceaba1072bba0/b/src/Jolt/Core/JobSystemSingleThreaded.cpp:9:1: warning: unknown warning group '-Wdeprecated-copy-with-dtor', ignored [-Wunknown-warning-option]
    JPH_NAMESPACE_BEGIN
    ^
    /Users/jenkins/w/prod-v2/bsr@3/74271/dcefc/p/b/joltpceaba1072bba0/b/src/Build/../Jolt/Core/Core.h:350:2: note: expanded from macro 'JPH_NAMESPACE_BEGIN'
            JPH_SUPPRESS_WARNINGS                                                                                                                                           \
            ^
    /Users/jenkins/w/prod-v2/bsr@3/74271/dcefc/p/b/joltpceaba1072bba0/b/src/Build/../Jolt/Core/Core.h:290:2: note: expanded from macro 'JPH_SUPPRESS_WARNINGS'
            JPH_CLANG_13_PLUS_SUPPRESS_WARNING("-Wdeprecated-copy-with-dtor")                                                       \
            ^
    /Users/jenkins/w/prod-v2/bsr@3/74271/dcefc/p/b/joltpceaba1072bba0/b/src/Build/../Jolt/Core/Core.h:231:48: note: expanded from macro 'JPH_CLANG_13_PLUS_SUPPRESS_WARNING'
            #define JPH_CLANG_13_PLUS_SUPPRESS_WARNING(w) JPH_CLANG_SUPPRESS_WARNING(w)
                                                          ^
    /Users/jenkins/w/prod-v2/bsr@3/74271/dcefc/p/b/joltpceaba1072bba0/b/src/Build/../Jolt/Core/Core.h:229:39: note: expanded from macro 'JPH_CLANG_SUPPRESS_WARNING'
    #define JPH_CLANG_SUPPRESS_WARNING(w)   JPH_PRAGMA(clang diagnostic ignored w)
                                            ^
    /Users/jenkins/w/prod-v2/bsr@3/74271/dcefc/p/b/joltpceaba1072bba0/b/src/Build/../Jolt/Core/Core.h:226:27: note: expanded from macro 'JPH_PRAGMA'
    #define JPH_PRAGMA(x)                                   _Pragma(#x)
                                                            ^
    <scratch space>:84:27: note: expanded from here
     clang diagnostic ignored "-Wdeprecated-copy-with-dtor"
                              ^
    /Users/jenkins/w/prod-v2/bsr@3/74271/dcefc/p/b/joltpceaba1072bba0/b/src/Jolt/Core/JobSystemSingleThreaded.cpp:16:78: error: variable has incomplete type 'JPH::ColorArg' (aka 'JPH::Color')
    JobHandle JobSystemSingleThreaded::CreateJob(const char *inJobName, ColorArg inColor, const JobFunction &inJobFunction, uint32 inNumDependencies)
                                                                                 ^
    /Users/jenkins/w/prod-v2/bsr@3/74271/dcefc/p/b/joltpceaba1072bba0/b/src/Build/../Jolt/Core/Color.h:9:7: note: forward declaration of 'JPH::Color'
    class Color;
          ^
    50 warnings and 4 errors generated.
    46 warnings and 4 errors generated.
    make[2]: *** [CMakeFiles/Jolt.dir/Users/jenkins/w/prod-v2/bsr@3/74271/dcefc/p/b/joltpceaba1072bba0/b/src/Jolt/Core/JobSystemThreadPool.cpp.o] Error 1
    make[2]: *** [CMakeFiles/Jolt.dir/Users/jenkins/w/prod-v2/bsr@3/74271/dcefc/p/b/joltpceaba1072bba0/b/src/Jolt/Core/JobSystemSingleThreaded.cpp.o] Error 1
    41 warnings generated.
    39 warnings generated.
    make[1]: *** [CMakeFiles/Jolt.dir/all] Error 2
    make: *** [all] Error 2
    
    joltphysics/4.0.2: ERROR: 
    Package '3626a272105409c9ee104cdfe382fb6cf1570a1a' build failed
    joltphysics/4.0.2: WARN: Build folder /Users/jenkins/w/prod-v2/bsr@3/74271/dcefc/p/b/joltpceaba1072bba0/b/build/Release
    *********************************************************
    Recipe 'joltphysics/4.0.2' cannot build its binary
    It is possible that this recipe is not Conan 2.0 ready
    If the recipe comes from ConanCenter, report it at https://github.com/conan-io/conan-center-index/issues
    If it is your recipe, check if it is updated to 2.0
    *********************************************************
    
    ERROR: joltphysics/4.0.2: Error in build() method, line 148
    	cmake.build()
    	ConanException: Error 2 while executing
    
  • joltphysics/3.0.1:
    Didn't run or was cancelled before finishing

  • joltphysics/2.0.1:
    Didn't run or was cancelled before finishing


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@cuppajoeman
Copy link
Contributor

Hey I'm trying to improve the joltphysics package, does anyone know why these builds failed?

@AbrilRBS
Copy link
Member

Maybe @toge can shed some light, but this seems to be an issue with apple-clang 13 maybe not being supported?

@cuppajoeman
Copy link
Contributor

Maybe @toge can shed some light, but this seems to be an issue with apple-clang 13 maybe not being supported?

I looked into the build a bit:

https://c3i.jfrog.io/c3i/misc/logs/pr/21080/10-macos-clang/joltphysics/4.0.2//dda52791cd8b1befae9fa9bc68678cbd0c72d7df-build.txt

And the first thing I saw was this:

warning: unknown warning group '-Wdeprecated-copy-with-dtor', ignored [-Wunknown-warning-option]
JPH_NAMESPACE_BEGIN

Which might have to do with this:

https://stackoverflow.com/questions/40761120/unknown-warning-group-wmaybe-unintialized-mac-os-sierra

Is there a way to debug these problems? I don't have a mac computer so how do we change stuff and see if it builds iteratively?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants