-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
joltphysics: add version 4.0.2 #21080
base: master
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 894dcb2joltphysics/4.0.0@#f7b3aa5b7490df47a68b2bc0c18e525c
|
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Maybe spotted a typo?
recipes/joltphysics/all/conanfile.py
Outdated
@@ -133,6 +133,8 @@ def generate(self): | |||
tc.variables["JPH_PROFILE_ENABLED"] = self.options.profile | |||
if Version(self.version) >= "3.0.0": | |||
tc.variables["ENABLE_ALL_WARNINGS"] = False | |||
if Version(self.version) >= "3.0.0": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3.0.0
? Or 4.0.0
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RubenRBS
INTERPROCEDURAL_OPTIMIZATION
has been introduced since 3.0.0.
I merged these version checks.
Thank you for your review!
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 5b0d39ejoltphysics/4.0.1@#5c21c1d6317691f0aa4fc8bc491689ff
|
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ❌Failure in build 10 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. Conan v2 pipeline ❌
The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping See details:Failure in build 10 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
Hey I'm trying to improve the |
Maybe @toge can shed some light, but this seems to be an issue with apple-clang 13 maybe not being supported? |
I looked into the build a bit: And the first thing I saw was this:
Which might have to do with this: https://stackoverflow.com/questions/40761120/unknown-warning-group-wmaybe-unintialized-mac-os-sierra Is there a way to debug these problems? I don't have a mac computer so how do we change stuff and see if it builds iteratively? |
Specify library name and version: joltphysics/4.0.2